tsh / django-rest-framework-base64-fields

Django Rest Framework base64 fields Installation:

pip django-rest-framework-base64-fields

Usage:

class MySerializer(serializers.ModelSerializer): some_file = Base64FileField()

django-rest-framework-base64-fields's Issues

compatibility with django-rest-framework's APIRequestFactory

i'm having trouble writing integrations tests using Base64FileField because DRF's APIRequestFactory._encode_data converts string values in the data to unicode, which then fails the type check, since unicode is not str type.

class MyTests(APITestCase):
    def test_this(self):
        b64_encoded = b'data:application/pdf;base64,{}'.format(base64.b64encode('some data'))
        data = {'upload': b64_encoded}
        resp = self.client.post('/here', data=data)
        # resp.data is 400, on account of the value not being a `str` type

Any reason we couldn't check against basestring instead? That way, a unicode string could make it through. i know that technically we need byte characters (for the encoded part), so some unicode strings would be invalid, but i think that would be caught later in the decoding, anyway.