GithubHelp home page GithubHelp logo

django-rest-framework-base64-fields's People

Contributors

tsh avatar

Stargazers

 avatar

Watchers

 avatar

django-rest-framework-base64-fields's Issues

compatibility with django-rest-framework's APIRequestFactory

i'm having trouble writing integrations tests using Base64FileField because DRF's APIRequestFactory._encode_data converts string values in the data to unicode, which then fails the type check, since unicode is not str type.

class MyTests(APITestCase):
    def test_this(self):
        b64_encoded = b'data:application/pdf;base64,{}'.format(base64.b64encode('some data'))
        data = {'upload': b64_encoded}
        resp = self.client.post('/here', data=data)
        # resp.data is 400, on account of the value not being a `str` type

Any reason we couldn't check against basestring instead? That way, a unicode string could make it through. i know that technically we need byte characters (for the encoded part), so some unicode strings would be invalid, but i think that would be caught later in the decoding, anyway.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.