tungli / findpeaks.jl Goto Github PK

It is not great to fracture the Julia ecosystem on simple stuff like a simple peak-finding package. Would it be possible to implement any advantage in API/capabilities/performance over to https://github.com/halleysfifthinc/Peaks.jl to unite the implementations, and archive this repo?

The reason why I am suggesting that this one be deprecated, and not Peaks.jl, is because Peaks.jl

1. Is more starred
2. Is resistered
3. Has a better name (quite subjective)

I have already made two issues over there (halleysfifthinc/Peaks.jl#24 and halleysfifthinc/Peaks.jl#25) to improve their API and capabilities, inspired by this package.

Hello, I was trying to install the package and got this error message:
ERROR: The following package names could not be resolved: * Findpeaks (not found in project, manifest or registry)

Hey and thanks for this useful package! We would like to have it as a dependency to some of our packages, would you consider registering this package so that it can be automatically installed as a dependency?

Thank you.

thanks for this package!

i'd suggest providing links to these alternatives in your README and differentiating your features from them. or join forces to provide the ultimate peak finder!

https://github.com/halleysfifthinc/Peaks.jl

https://github.com/JuliaImages/Images.jl/blob/master/src/algorithms.jl#L464

Hi,
I just run your function findpeaks, and I can reproduce the results given by other libraries (scipy). However, I was wondering if by any change do you have some references(books or papers) to the method?

Best,
L