tvanc / lineclamp Goto Github PK

https://github.com/tvanc/lineclamp/blob/master/src/LineClamp.js#L262

at the moment the algorithm tries to cut one char after another until it can do its thing.
it's precise but it's heavy on the browser a bit, especially if the text is long and is expected to be longer than the expected amount of lines quite a bit

for 1000 char text that is likely to cut to 200, it does 800 measurements

what it could do instead (a divide and conquer solution)

1. receives a string with length 100
2. checks if 100 passes, if yes returns
3. if not tries 50
   4a) if 50 passess, tries 75, if passes, tries 87, keeps going until the delta is > 1. When the delta is 1, returns
   4b) if 50 does not pass, tries 25, then 12, then maybe 18 and so again until delta is 1.

This algorithm would radically reduce the amount of checks for long texts

It would be nice if this was debounced.
https://github.com/tvanc/lineclamp/blob/master/src/LineClamp.js#L182

Thanks for the lib, it seems to do the job well in quite a few lines of JS.

But since it replaces the text in place, it makes it a bit harder to implement any kind of toggling functionality. If there was a function to return the clamped text instead of mutating the element, it would make the toggling easier to implement for me in Vue.

https://github.com/tvanc/lineclamp/blob/master/src/LineClamp.js#L264