twenga / geoip-updater Goto Github PK

The validation process only runs the geoip_country_code_by_name() function. That's not enough to validate all databases!!!

We just had the issue, 2 db files were invalid, but geoip_country_code_by_name() still worked... And the db files were validated.

Validation process should run GeoIp functions that sollicitate all db files. The IP list should be extended to include more data to check (country name, isp, region, isp, city....), geoip_record_by_name() is a good candidate.

When unzipping DB files, gzread is currently limited to 2MB files! Larger files are truncated!

See : http://php.net/manual/fr/function.gzread.php and dynamic size.

Currently, errors are simply logged, they should make PHP return an error code to shell that could be caught by Puppet or some other program that executed GeoIp Updater.

Hello Nassim,

Line 383:
$aDbFiles = $this->_oFileSystem->glob($sPath.DIRECTORY_SEPARATOR."*".DIRECTORY_SEPARATOR);

$aDbFiles = $this->_oFileSystem->glob($sPath.DIRECTORY_SEPARATOR."*");

Can you please fix this ?

Thanks

A user modified the list and forgot to specify matching country codes for each IP, this made the validation fail and blacklist the db file!

Validation process should first check that it's got all the data it needs.