Comments (6)
Thanks for the report.
I don't think that we use soappy anymore as a dependency
I don't see it defined as a dependency
https://github.com/twisted/twisted/blob/trunk/pyproject.toml
But I do see that soappy is imported.
https://github.com/twisted/twisted/blob/trunk/src/twisted/web/soap.py
The source code for the documentation is at
https://github.com/twisted/twisted/blob/trunk/docs/installation/howto/optional.rst
My suggestion is to just deprecated the soap support in Twisted.
I see that the last important update was made 18 years ago
And the soap dependency was not defined for more than 4 years
https://github.com/twisted/twisted/blob/80b02d87adc48f813179aaa31ff5aaaa574200e6/setup.cfg
I could not find where the soap dependency was first defined.
By it looke like it was never defined in setup.cfg or pyproject.toml
Do you use the SOAP code with twisted ?
from twisted.
Thanks for the feedback.
I think that is safe to just remove the SOAP code
It is already broken.
It looks like we still have code that was not ported to py3 ... or for which we don't execute the tests.
If anyone want to have SOAP support in Twisted, they can send a PR
$ pip install soappy
$ python
Python 3.12.2 (main, Feb 25 2024, 16:35:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from twisted.web.soap import SOAPPublisher
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/adi/chevah/twisted/src/twisted/web/soap.py", line 19, in <module>
import SOAPpy
File "/home/adi/chevah/twisted/venv-3.12/lib/python3.12/site-packages/SOAPpy/__init__.py", line 3, in <module>
from version import __version__
ModuleNotFoundError: No module named 'version'
>>>
from twisted.
Normally I pop up to say how great some weird obscure ancient Twisted module is, but honestly the SOAP code was a bit of a sad afterthought even at the time, and clearly it doesn't really work now. I don't know if anyone ever used it. Obviously, do the usual mailing list thing, but unless there's some strenuous objection, let's dump it.
from twisted.
I plan to use this ticket to update the instalallation documentation.
I have created a separate ticket to track the removal of SOAP - #12146
I will send a message to the mailing list one the SOAP removal PR is ready to review
from twisted.
Also, maybe this should be updated as well? 😓 I'm not familiar enough if these packages are still relevant. But mentioning Python 2 is definitely not relevant anymore.
from twisted.
Do you use the SOAP code with twisted ?
Looking again at my code, we do use SOAP with twisted, but we don't use the soap
module from twisted at all. The code is based on https://github.com/fuzeman/PyUPnP with some custom modifications
What you say makes total sense :) To deprecate the soap module in twisted since I'm pretty sure it won't work on Python 3.10+.
I started a few months ago to port a project from Python 2.7 to 3.10, and SOAPpy did not handle it well (especially one of its dependencies wstools). If I recall correctly it was mainly due to changes in Python's standard library like collections
changed to collections.abc
. Thankfully someone had already made a fork with fixes for that.
from twisted.
Related Issues (20)
- Idea: Remove `_get_async_param` method HOT 1
- Verification: Ok even for protocols disabled HOT 5
- Speed up twisted.web, part 1 of N HOT 5
- Adding custom cipher list to serverFromString HOT 5
- Continued Use of Insecure Default Parameters HOT 8
- Deprecation of SSH ciphers HOT 1
- t.c.ssh.channel.SSHChannel.write has no limit to the buffer
- t.c.ssh.filetransferserver.FileTransferServer.packet_READ with unhandled error
- type confusion in KnownHosts.verifyHostKey traceback when adding ip key
- Compiled version of DelayedCall
- Remove the soap code
- `twisted.internet.test.test_tcp.AbortConnectionTests_*Tests.test_fullWriteBuffer` test timeout on macOS HOT 13
- TwistedWeb ReverseProxyResource example has string not bytes as third argument
- Setup benchmarks using Codspeed.io HOT 6
- Speed up twisted.web server, part 2 of N
- Deprecate t.w.h.HTTPClient HOT 4
- t.w.h.HTTPClient parses Content-Length laxly HOT 1
- disttrial / `trial -j` should support debug prints
- `twisted.python.test.test_sendmsg.SendmsgTests.test_sendSubProcessFD` is flaky HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twisted.