Comments (14)
Automation removed owner |
---|
from twisted.
@itamarst commented |
---|
#!html
<pre>
I'll look when I have some time, later in the week. Don't
commit to core twisted until I do? :)
</pre>
from twisted.
@glyph commented |
---|
#!html
<pre>
radix: try uncommenting that line and watch the traceback.
the DefaultOpenSSLContextFactory blows up if you create it
with an invalid filename.
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
The idea is to allow tap plugins to just use this instead of
duplicating the "choose which port and if it's unix socket
or tcp or ssl and what interface optionally" code for each
server. Probably other uses as well.
E.g. "mktap web --listen tcp:80:127.0.0.1" or something.
Format needs to be decided.
The scheme should be pluggable so you can add new
transports. I'd argue this shouldn't be done on reactor
level (why should cReactor need to parse this?) but as a
utility function.
</pre>
from twisted.
@glyph commented |
---|
#!html
<pre>
Just checked in an implementation of this to
sandbox/glyph/just.py (e.g. "just.listen(...)")
Let me know what you think.
</pre>
from twisted.
@glyph commented |
---|
#!html
<pre>
Comment on it, post-haste!
</pre>
from twisted.
@radix commented |
---|
#!html
<pre>
well, it looks fine to me. The little example section at the
bottom has the ssl bit commented out with something about
"needs a real server.pem", but it seems, from reading the
code, that it should work fine.. wouldn't you just say
ssl:80:privateKey=server.pem
?
Maybe it would also be cool to have that code that builds a
function call out of strings be moved into something like
twisted.python.util.stringToFunctionCall. Although, I guess
we can wait until we have a real use case for that :-)
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
I like.
Just don't add the stringfunction thing to t.p.util, new
module please. Enough crap there, radix.
</pre>
from twisted.
@glyph commented |
---|
#!html
<pre>
This has been sitting open forever. Since the code exists,
it should get resolved. I'd like to see this in 1.1,
especially in a more new-application-friendly format. Where
should it go and what remains to be done?
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
twisted.application.internet. It should be, of course, a
service :)
</pre>
from twisted.
@moshez commented |
---|
#!html
<pre>
Have a look at sandbox/moshez/ports.py for a different take on the same idea --
I seperated the listening and parsing aspects, so instead of creating a
server which chooses stuff at the last moment, the service created is already
the correct type. I'm not sure where this should go, maybe twisted.application
[even though it's not necessarily applicationy stuff, but internet is also
invalid -- though the service() function could go in t.application.internet
witht he rest of ports hanging in twisted.internet
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
The nice thing about choosing at the last minute is that you
can edit it with coil. Although I suppose coil ought to have
some of way of "turn this tcp service into ssl service" or
something anyway.
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
So, moshez has added this. Missing: update taps to use it,
and docstrings so tap users know about this, and a mini-howto.
</pre>
from twisted.
@glyph commented |
---|
#!html
<pre>
strports is awesome. I think this issue should be closed. Docstrings for taps
and howto can be separate issues. I'm resolving this.
</pre>
from twisted.
Related Issues (20)
- Deprecation of SSH ciphers HOT 1
- t.c.ssh.channel.SSHChannel.write has no limit to the buffer
- t.c.ssh.filetransferserver.FileTransferServer.packet_READ with unhandled error
- type confusion in KnownHosts.verifyHostKey traceback when adding ip key
- Compiled version of DelayedCall
- Change documentation for optional dependency SOAPpy to SOAPpy-py3 HOT 6
- Remove the soap code
- `twisted.internet.test.test_tcp.AbortConnectionTests_*Tests.test_fullWriteBuffer` test timeout on macOS HOT 13
- TwistedWeb ReverseProxyResource example has string not bytes as third argument
- Setup benchmarks using Codspeed.io HOT 6
- Speed up twisted.web server, part 2 of N
- Deprecate t.w.h.HTTPClient HOT 4
- t.w.h.HTTPClient parses Content-Length laxly HOT 1
- disttrial / `trial -j` should support debug prints
- `twisted.python.test.test_sendmsg.SendmsgTests.test_sendSubProcessFD` is flaky HOT 2
- Deprecation docs should use NEXT placeholders
- Improve defer.inlineCallbacks tests
- twisted.web generates deprecation warnings internally HOT 4
- Expand benchmarks to run on PyPy as well HOT 2
- ``twisted.python.code`` package proposal HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twisted.