GithubHelp home page GithubHelp logo

twitter / ios-twitter-image-pipeline Goto Github PK

View Code? Open in Web Editor NEW
1.9K 40.0 109.0 76.53 MB

Twitter Image Pipeline is a robust and performant image loading and caching framework for iOS clients

License: Apache License 2.0

Objective-C 21.83% Ruby 0.03% C 48.71% Shell 11.79% Swift 0.40% Makefile 15.30% CMake 0.53% M4 0.62% HTML 0.10% Roff 0.55% Go 0.02% Python 0.14%
image-pipeline ios swift objective-c twitter cache

ios-twitter-image-pipeline's Introduction

Twitter Image Pipeline (a.k.a. TIP)

Background

The Twitter Image Pipeline is a streamlined framework for fetching and storing images in an application. The high level concept is that all requests to fetch or store an image go through an image pipeline which encapsulates the work of checking the in memory caches and an on disk cache before retrieving the image from over the network as well as keeping the caches both up to date and pruned.

Goals and Requirements

Twitter Image Pipeline came to fruition as numerous needs rose out of Twitter for iOS use cases. The system for image loading prior to TIP was fragile and inefficient with some severe edge cases. Designing a new framework from the ground up to holistically approach the need for loading images was the best route and led to TIP.

  • Progressive image loading support (Progressive JPEG)
    • PJPEG can render progressive scans with a fraction of the bytes needed for the full image
    • Users can see a 35% to 65% improvement in how soon an image is visible (occasionally even better)
    • PJPEG images happen to be 10% smaller (on average) than their non-progressive counterparts
    • PJPEG is hardware decodable on iOS devices, just like non-progressive JPEG images
  • Resumable download support
    • If an image load is terminated (via failure or cancellation) when an image is partially loaded, the next load of that image should resume from where it left off saving on bytes needing to be transferred
    • Has a compounding benefit with Progressive JPEG as resuming an image that is partially loaded can render to screen with a progressive scan immediately while remaining bytes can be loaded to improve the quality
  • Support programmatically/manually storing images to the cache(s)
    • By being able to store images to the underlying cache(s), cases where images are uploaded can have those images in cache at the right location without having to make a fetch. (Ex// Post a Tweet with an image, that image can be stored to the cache before it is ever seen in the timeline making the timeline's fetch of that image immediate and avoids hitting the network.)
  • Support vending a larger variant when a smaller variant is fetched
    • By maintaining the largest variant in cache, we can merely scale the image (in the background) and vend that image instead of hitting the network
  • Support vending a smaller variant when a larger variant is fetched
    • When fetching a larger variant of an image when a smaller variant is in the cache, the smaller variant should be optionally be consumable as the larger variant is loaded over the network
    • This improves the user experience by providing an image at lower quality while loading the higher quality variant instead of just having an empty/blank UI or placeholder
  • Asynchronous architecture
    • Using requests to encapsulate what to load, using an operation for executing the asynchronous work, and having a delegate for callbacks we can provide a strong and scalable pattern for image loading
  • Cancellable fetches
    • When an image fetch is no longer relevant (such as navigating away from an image that hasn't finished loading), we should be permitted to cancel fetches
    • HTTP/1.1 based fetch downloads that are cancelled will have the negative side effect of tearing down that TCP connection which is expensive to re-establish at the tradeoff of saving on bandwidth and unnecessary network contention with other network requests
    • HTTP/2 (or SPDY) based fetch downloads will have no negative side effects since the protocol supports midstream cancellation without impacting overall network performance
  • Fast access to cached images
    • Having the fetch synchronously load already scaled and cached images will keep the UI smooth by avoiding lapses when the image is immediately available
  • Background rendering/scaling/decoding of fetched images
    • Fetched images need to be decoded and often scaled and even rendered, doing so on a background thread will eliminate framerate drops from trying to do the same expensive work from the main thread
  • Segregated caches / pipelines
    • By having caches support being segregated, the Twitter app can utilize this segregation to keep caches separate per user account. On account removal, that account's cache can be cleared without affecting other account caches.
  • Image fetch hydration support
    • Certain image fetches will require the fetch to sign the request to be loaded over the network, having support for a hydration step will enable this with "pull" based pattern vs a "push" based pattern that would require applying any such request construct up front.
  • Support for custom networking to execute the downloading of images.
    • Twitter has strict requirements to have all networking go through its network layer and as such TIP has abstracted out networking so that any network layer can be plugged in via the abstraction interface for downloads.
    • An NSURLSession based download plugin is used by default, but consumers can plug in whatever network layer they desire.
  • Support any image codec desired
    • By default, all ImageIO supported image types are supported
    • A plugin architecture supports custom codecs for encoding and/or decoding images in TIP
    • Use cases include WebP support, or any custom decoding support such as JPEG decoding with a shared quantization table and/or header, or even applying some visual transform (like a blur) as a part of the rendering

Architecture

Caches

There are 3 separate caches for each image pipeline: the rendered in-memory cache, the image data in-memory cache, and the on-disk cache. Entries in the caches are keyed by an image identifier which is provided by the creator of the fetch request or automatically generated from the image fetch's URL.

  • The On-Disk Cache will maintain both the latest partial image and the largest completed image for an image identifier
  • The Image Data In-Memory Cache will maintain the largest matching image data (based on the image identifier), but is not decoded
  • The Rendered In-Memory Cache will maintain the 3 most recently sized and rendered/decoded UIImages that match (based on the image identifier)

The image will simultaneously be loaded into memory (as raw bytes) and written to the disk cache when retrieving from the Network. Partial images will be persisted as well and not replace any completed images in the cache.

Once the image is either retrieved from any of the caches or the network, the retrieved image will percolate back through the caches in its various forms.

Caches will be configurable at a global level to have maximum size. This maximum will be enforced across all image pipeline cache's of the same kind, and be maintained with the combination of time-to-live (TTL) expiration and least-recently-used (LRU) purging. (This solves the long standing issue for the Twitter iOS app of having an unbounded cache that could consume Gigabytes of disk space).

Execution

The architecture behind the fetch operation is rather straightforward and streamlined into a pipeline (hence, "image pipeline").

When the request is made, the fetch operation will perform the following:

  • Synchronously consult the Rendered In-Memory Cache for an image that will fit the target dimensions and content mode.
  • On miss, asynchronously consult the Image Data In-Memory Cache that holds the image of the largest matching image (based on identifier).
  • On miss, asynchronously consult the On-Disk Cache that maintains the image data of the largest matching image (based on identifier). As an optimization, TIP will take it a step further and also consult all other registered pipeline disk caches - thus saving on the cost of network load by pulling from disk. The cross pipeline retrieved image will be stored to the fetching pipeline's caches to maintain image pipeline siloing. Note: this cross pipeline access requires the fetching image identifier and image URL to match.
  • On miss, asynchronously consult any provided additional caches (based on URL). This is so that legacy caches can be pulled from when transitioning to TIP without having to forcibly load all assets again.
  • On miss, asynchronously retrieve the image from the Network, resuming any partially loaded data that may exist in the On-Disk Cache.

Preview Support

In addition to this simple progression, the fetch operation will offer the first matching (based on image identifier) complete image in the In-Memory Cache or On-Disk Cache (rendered and sized to the request's specified target sizing) as a preview image when the URLs don't match. At that point, the fetch delegate can choose to just use the preview image or continue with the Network loading the final image. This is particularly useful when the fetch image URL is for a smaller image than the image in cache, no need to hit the network :)

Progressive Support

A great value that the image pipeline offers is the ability to stream progressive scans of an image, if it is PJPEG, as the image is loaded from the Network. This progressive rendering is natively supported by iOS 8+, the OS minimum for TIP is now iOS 10+. Progressive support is opt-in and also configurable in how scans should load.

Resuming Image Downloads

As already mentioned, by persisting the partial load of an image to the On-Disk Cache, we are able to support resumable downloads. This requires no interface either, it's just a part of how the image pipeline works.

Rendering to Target Sizing

As of 2.20, the image pipeline will load the image from data to the specified target sizing of the fetch request, which avoids the overhead of loading the entire image into a large bitmap just to scale it down to the correct size. If the target sizing is larger than the image data, it will load that image bitmap and scale it up to the target sizing specified by the fetch request. If a request does not provide target sizing (or the sizing indicates to not resize), it will yield the full size image, as one would expect.

Twitter Image Pipeline features

  • Fetching
    • Progress reporting
    • Customizable progressive loading policies
    • Preview loading with option to avoid continuing to load
    • Placeholder support (for non-canonical images that get purged)
    • Automatic scaling to target view's size
    • Custom caching uptions
    • Customizable set of loading sources (caches and network)
    • NSOperation based
      • Cancellable
      • Priority support
      • Dependency chain support
    • Delegate pattern (for robust support)
    • Block callback pattern (for simple use cases)
  • Storing
    • Manual storage support (UIImage, NSData or file on disk)
    • Manual purging support
    • Dependency chain support (like NSOperation)
  • Caching
    • Synchronous/fast cache for rendered images
    • Async memory cache for image data
    • Async disk cache for image data
    • Automatic LRU purging
    • Automatic TTL purging
    • Siloed caches (via multiple TIPImagePipeline instances)
    • Support for loading from additional non-TIP caches (helps with migration)
    • Expose method to copy disk cache images directly
  • Downloads
    • Coalescing image downloads
    • Image download resumption support built in
      • Image response "Accept-Ranges" must be "bytes" and have "Last-Modified" header
      • Uses "Range" and "If-Range" headers to specify continuation
    • Pluggable networking (use your own network layer)
    • Custom hydration (useful for authenticated fetches)
  • Detailed insights
    • Global pipeline observability
    • Individual pipeline observability
    • Global problem observability (non-fatal problems for monitoring)
    • Asserts can be enabled/disabled
    • Pluggable logging
    • Inspectable (can inspect each pipeline's entries)
    • Robust errors
    • Detailed metrics on fetch operation completion
  • Robust image support
    • Pluggable codecs (can add WebP or other image codecs)
    • Can serialize access to CGContext
    • UIImage convenience methods
    • Animated image support (GIFs, by default)
  • UIKit integration
    • Dedicated helper object decoupling logic from views w/ TIPImageViewFetchHelper
    • Fetch helper offers useful fetch behavior encapsulation
    • Debug overlay feature to see debug details of the image view
    • UIImageView category for convenient pairing with a TIPImageViewFetchHelper
  • Configurable
    • caches sizes (both in bytes and image count)
    • max cache entry size
    • max time for detached download
    • max concurrent downloads

Components of the Twitter Image Pipeline

  • TIPGlobalConfiguration
    • The global configuration for TIP
    • Configure/modify this configuration to adjust TIP behavior for your needs
  • TIPImagePipeline
    • the pipeline for fetching images from and storing images to
    • multiple pipelines can exist providing segregation by use case
    • a fetch operation is constructed by providing a request (TIPImageFetchRequest) with a delegate (TIPImageFetchDelegate) or completion block (TIPImagePipelineFetchCompletionBlock) to a desired pipeline. The operation can then be provided to that same pipeline to start the fetching. This two step approach is necessary to support both synchronous and asynchronous loading while incurring minimal burden on the developer.
  • TIPImageFetchRequest
    • the protocol that encapsulates the information necessary for retrieving an image
  • TIPImageFetchDelegate
    • the delegate for dealing with dynamic decisions and event callbacks
  • TIPImageFetchOperation
    • the NSOperation that executes the request and provides a handle to the operation
    • the operation maintains the state of the fetch's progress as it executes
    • the operation offers several features:
      • cancelability
      • dependency support
      • prioritization (can be mutated at any time)
      • a unique reference for distinguishing between operations
  • TIPImageStoreRequest
    • the protocol that encapsulates the information necessary for programmatically storing an image
  • TIPImageContainer
    • object to encapsulate the relevant info for a fetched image
    • the TIPImageFetchDelegate will use TIPImageContainer instances for callbacks, and the TIPImageFetchOperation will maintain TIPImageFetchOperation properties as it progresses.
  • TIPImageViewFetchHelper
    • powerful class that can encapsulate the majority of use cases for loading an image and displaying it in a UIImageView
    • 99% of image loading and displaying use cases can be solved by using this class, configuring it and providing a delegate and/or data source
    • having the logic in this class avoid coupling controller code with view code in the MVC practice
  • UIView(TIPImageFetchable) and UIImageView(TIPImageFetchable)
    • convenience categories on UIImageView and UIView for associating a TIPImageViewFetchHelper

Usage

The simplest way to use TIP is with the TIPImageViewHelper counterpart.

For concrete coding samples, look at the TIP Sample App and TIP Swift Sample App (in Objective-C and Swift, respectively).

Here's a simple example of using TIP with a UIViewController that has an array of image views to populate with images.


    /* category on TIPImagePipeline */

    + (TIPImagePipeline *)my_imagePipeline
    {
        static TIPImagePipeline *sPipeline;
        static dispatch_once_t sOnceToken;
        dispatch_once(&sOnceToken, ^{
            sPipeline = [[TIPImagePipeline alloc] initWithIdentifier:@"com.my.app.image.pipeline"];

            // support looking in legacy cache before hitting the network
            sPipeline.additionalCaches = @[ [MyLegacyCache sharedInstance] ];
        });
        return sPipeline;
    }

    // ...

    /* in a UIViewController */

    - (void)viewDidLayoutSubviews
    {
        [super viewDidLayoutSubviews];

        if (nil == self.view.window) {
            // not visible
            return;
        }

        [_imageFetchOperations makeAllObjectsPerformSelector:@selector(cancelAndDiscardDelegate)];
        [_imageFetchOperations removeAllObjects];

        TIPImagePipeline *pipeline = [TIPImagePipeline my_imagePipeline];
        for (NSInteger imageIndex = 0; imageIndex < self.imageViewCount; imageIndex++) {
            UIImageView *imageView = _imageView[imageIndex];
            imageView.image = nil;
            id<TIPImageFetchRequest> request = [self _my_imageFetchRequestForIndex:imageIndex];

            TIPImageFetchOperation *op = [pipeline operationWithRequest:request context:@(imageIndex) delegate:self];

            // fetch can complete sync or async, so we need to hold the reference BEFORE
            // triggering the fetch (in case it completes sync and will clear the ref)
            [_imageFetchOperations addObject:op];
            [[TIPImagePipeline my_imagePipeline] fetchImageWithOperation:op];
        }
    }

    - (id<TIPImageFetchRequest>)_my_imageFetchRequestForIndex:(NSInteger)index
    {
        NSAssert(index < self.imageViewCount);

        UIImageView *imageView = _imageViews[index];
        MyImageModel *model = _imageModels[index];

        MyImageFetchRequest *request = [[MyImageFetchRequest alloc] init];
        request.imageURL = model.thumbnailImageURL;
        request.imageIdentifier = model.imageURL.absoluteString; // shared identifier between image and thumbnail
        request.targetDimensions = TIPDimensionsFromView(imageViews);
        request.targetContentMode = imageView.contentMode;

        return request;
    }

    /* delegate methods */

    - (void)tip_imageFetchOperation:(TIPImageFetchOperation *)op
                didLoadPreviewImage:(id<TIPImageFetchResult>)previewResult
                         completion:(TIPImageFetchDidLoadPreviewCallback)completion
    {
        TIPImageContainer *imageContainer = previewResult.imageContainer;
        NSInteger idx = [op.context integerValue];
        UIImageView *imageView = _imageViews[idx];
        imageView.image = imageContainer.image;

        if ((imageContainer.dimension.width * imageContainer.dimensions.height) >= (originalDimensions.width * originalDimensions.height)) {
            // scaled down, preview is plenty
            completion(TIPImageFetchPreviewLoadedBehaviorStopLoading);
        } else {
            completion(TIPImageFetchPreviewLoadedBehaviorContinueLoading);
        }
    }

    - (BOOL)tip_imageFetchOperation:(TIPImageFetchOperation *)op
    shouldLoadProgressivelyWithIdentifier:(NSString *)identifier
                                URL:(NSURL *)URL
                          imageType:(NSString *)imageType
                 originalDimensions:(CGSize)originalDimensions
    {
        // only load progressively if we didn't load a "preview"
        return (nil == op.previewImageContainer);
    }

    - (void)tip_imageFetchOperation:(TIPImageFetchOperation *)op
          didUpdateProgressiveImage:(id<TIPImageFetchResult>)progressiveResult
                           progress:(float)progress
    {
        NSInteger idx = [op.context integerValue];
        UIImageView *imageView = _imageViews[idx];
        imageView.image = progressiveResult.imageContainer.image;
    }

    - (void)tip_imageFetchOperation:(TIPImageFetchOperation *)op
                  didLoadFinalImage:(id<TIPImageFetchResult>)finalResult
    {
        NSInteger idx = [op.context integerValue];
        UIImageView *imageView = _imageViews[idx];
        imageView.image = finalResult.imageContainer.image;

        [_imageFetchOperations removeObject:op];
    }

    - (void)tip_imageFetchOperation:(TIPImageFetchOperation *)op
            didFailToLoadFinalImage:(NSError *)error
    {
        NSInteger idx = [op.context integerValue];
        UIImageView *imageView = _imageViews[idx];
        if (!imageView.image) {
            imageView.image = MyAppImageLoadFailedPlaceholderImage();
        }

        NSLog(@"-[%@ %@]: %@", NSStringFromClass([self class]), NSStringFromSelector(_cmd), error);
        [_imageFetchOperations removeObject:op];
    }

Inspecting Image Pipelines

Twitter Image Pipeline has built in support for inspecting the caches via convenience categories. TIPGlobalConfiguration has an inspect: method that will inspect all registered TIPImagePipeline instances (even if they have not been explicitely loaded) and will provide detailed results for those caches and the images there-in. You can also call inspect: on a specific TIPImagePipeline instance to be provided detailed info for that specific pipeline. Inspecting pipelines is asynchronously done on background threads before the inspection callback is called on the main thread. This can provide very useful debugging info. As an example, Twitter has built in UI and tools that use the inspection support of TIP for internal builds.

License

Copyright 2015-2020 Twitter, Inc.

Licensed under the Apache License, Version 2.0: https://www.apache.org/licenses/LICENSE-2.0

Security Issues?

Please report sensitive security issues via Twitter's bug-bounty program (https://hackerone.com/twitter) rather than GitHub.

ios-twitter-image-pipeline's People

Contributors

aalok05 avatar cltnschlosser avatar hawflakes avatar jason-cooke avatar juliaferraioli avatar liamnichols avatar nsprogrammer avatar ocastx avatar zhongwuzw avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ios-twitter-image-pipeline's Issues

Image decoding/decompression still happening on the main thread

Describe the bug
Even though there exists code in TIP to decode the image on the background thread, apple is still decoding the image again on the main thread. Seems some recent change caused the decoding in TIP to not function.

To Reproduce
Load remote images under profiler and do a filter for jpeg.

Expected behavior
Images are decompressed only on background thread.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment
iOS 14 (coworker claims it happens on iOS 13 as well)

Additional context
So there are 2 weird things:

  1. As a part of decoding the image that is returned from the background render is never used, only the original UIImage instance is used. Also this does result in 2 different UIImage instances. Seems the original maintains unmodified, it's possible this was a more recent iOS change.
  2. The image is rendered to 1x1. I assume this was a memory optimization, but it means the rendered image can't just be swapped in place of the original one.

I'll create a PR soon, need to get more familiar with the code and what is best practice for decoding images off the main thread. Wanted to create the issue now to increase awareness for those that are more familiar with this code.

how TIP decodes images in Background

in general, images decode in Background use CGContextDrawImage or CGDataProviderCopyData method. I read the source code , and find webp use CGDataProviderCopyData, but I don't know other format images how to decodes in Background

changes to continuous integration

We will be dropping our paid Travis CI plan at the end of 2021. We do not expect there to be any visible changes to this repo, but wanted to give some notice just in case. We recommend migrating CI jobs to GitHub Actions.

Travis CI provides free testing for open source projects. In addition, Twitter has paid for a small number of additional concurrent builds which were available for open source as well as private repositories. Many Twitter projects have already moved to GitHub Actions for CI, and we have no private repos left using Travis, so we will be discontinuing our plan at the end of 2021.

Since this repo is open source, we do not expect this change to impact Travis CI builds for this project. However, we still recommend most Twitter projects to migrate to GitHub Actions for CI at your convenience.

Detecting WebP via TIPDetectImageType and TIPDetectImageTypeFromFile?

Hey! Hope you don't mind me bugging you about WebP related stuff even more? 😬

I was looking at using TIPDetectImageTypeFromFile for convenience in my project (usage not directly related to the rest of TIP) and I noticed that prior to iOS 14, these methods aren't able to detect when a file or data is WebP.

It's because these methods first attempt to use CGImageSourceRef to detect the type before falling back to magic number checks of the data however CoreGraphics in the iOS 13SDK doesn't recognise WebP as it wasn't added until the iOS 14 SDK (I've verified that it works when building with the 14SDK) and the TIPDetectImageTypeViaMagicNumbers magic number fallback only detects BPM, JPEG, GIF and PNG.

Do you think it's worth updating this check to look for the WebP header/signature/magic numbers?

I can relatively easily wrap and extend in my own code but I wasn't sure if other parts of the TIP project were expecting these methods to detect WebP or not?

It's a little trickier to add support since the header also includes the file size (https://developers.google.com/speed/webp/docs/riff_container) so I'm not sure of the best way to adjust the existing code to support this but am happy to help and dig into it a little more if you think it's worth it?

Let me know your thoughts, thanks!

Hydration Block Confusion

I'm a little lost regarding the intended use of @property (nullable, nonatomic, copy, readonly) TIPImageFetchHydrationBlock imageRequestHydrationBlock; on a TIPImageFetchRequest to modify an NSURLRequest. I would expect this block to have a return type of NSURLRequest, to allow us to process the request that is passed into the block and return the modified output. For example, I am currently trying to insert an authentication entry into the header for OAuth2.

Any tips?

why rendered cache?

Acctually the images from the rendered cached are similar to the ones from memory cached, So I want to know if this will cost lots of memory.

Change imageIdentifier later?

Is it possible to change imageIdentifier later somehow?

Use case: the user uploads an image to the server. Before sending the image to the server, the app stores it into the cache. After the image is uploaded, it retrieves an url of the image and updates imageIdentifier.

Or may be there's a better way to handle such use case?

Controlling Animation on TIPImageView

Can you point me in the right direction regarding how to control the animations on a TIPImageView that encapsulates an animated GIF? UIImageView property isAnimating, and methods startAnimating, stopAnimating don't seem to function out of the box. Ideally, I need to be able to pause / resume the animation.

Thanks for sharing the awesome library!

Please release 2.25.0 via CocoaPods

👋

It looks like #62 introduced version 2.25.0 (the PR is titled incorrectly as 2.50.0) but this was never pushed to CocoaPods. Please could you tag master and push the release to CocoaPods 🙏

ITMS-90338: Non-public API usage - imageDimensions, imageFilePath

We just submitted our app to the App Store, but they rejected our package due to they think we used Apple private APIs:
ITMS-90338: Non-public API usage - imageDimensions, imageFilePath.
Maybe the names match the private Apple APIs listed above.
I have send email to Apple, that they flagged in error, and they approved our app later.
But i think maybe alter the names will help prevent app being flagged in future?

Can't link to app

ld: '/Users/cc/Library/.../TwitterImagePipeline.framework/TwitterImagePipeline' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. file '/Users/cc/Library/.../TwitterImagePipeline.framework/TwitterImagePipeline' for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This framework was built by carthage and embedded manually.

Xcode 9.1 beta 2.
iOS 11.1 beta 5.
macOS High Sierra 10.13.1 beta

Duplicate info.plist file in 2.11 Pods

There seems to be an issue when using the unpublished 2.11 tag with CocoaPods:

pod 'TwitterImagePipeline', :git => 'https://github.com/twitter/ios-twitter-image-pipeline.git', :tag => '2.11.0'

Produces:

warning: duplicate output file '/Users/test/Library/Developer/Xcode/DerivedData/testapp-ewynxhezdlpikvcpvyepzrthcgds/Build/Products/Debug-iphonesimulator/TwitterImagePipeline/TwitterImagePipeline.framework/Info.plist' on task: ProcessInfoPlistFile /Users/test/Library/Developer/Xcode/DerivedData/testapp-ewynxhezdlpikvcpvyepzrthcgds/Build/Products/Debug-iphonesimulator/TwitterImagePipeline/TwitterImagePipeline.framework/Info.plist /Users/test/Documents/testapp_ios/Pods/Target Support Files/TwitterImagePipeline/Info.plist (in target 'TwitterImagePipeline')

info.plist is included in the compiled sources list for the TwitterImagePipeline. Was this intentional?

tvOS Platform Support

Hi all, I've successfully integrated the current pod into a tvOS project by manually overriding the supported platforms in my local master repo. Is there any reason the podspec couldn't be updated to include s.tvos.deployment_target = '9.0'?

Question: TIP vs PINRemoteImage

Thanks for sharing TIP!
Looks very very impressive!

Currently, I use PINRemoteImage in my app (and enjoy it very much!). If I may, I wanted to ask the following:

  1. What were the reasons you felt that PINRemoteImage would not be good for the Twitter iOS app?
  2. What are the key differences to consider when choosing between both?

Thanks again for sharing this library!

Signed/Unsiged Build Failure on Xcode 11 beta 1

Likely due to a "fix" in Clang in the newest beta released today, building TIP in Xcode 11b1 results in the following build error:

Comparison of integers of different signs: 'TIPImageLoadSource' (aka 'enum TIPImageLoadSource') and 'const size_t' (aka 'const unsigned long')

I will admit I have only used TIP and not familiarized myself with the codebase, but a potential solution is changing TIPImageLoadSource to be an NSUInteger.

macOS version?

Hi. Thank you for sharing the library with us. :) Is there any chance we have a compatible Mac version?

Store operation not storing image container in disk entry

While debugging an issue with an particular image not storing in the pipeline (generally no entry in all cache levels) I stumbled over a possible bug in the code.

In the TIPImageStoreOperation main method the cache entries for the different caches are created by deciding which source of data should be held by the entry.
In the method the memoryEntry is created and it holds the imageContainer, if it exists, in the completeImage property. After that, when the diskEntry is created and the imageFilePath as well as the imageData does not exist, the imageContainer should be stored in the diskEntry. Currently the imageContainer will then be stored in the memoryEntry.

// Create Disk Entry
    TIPImageCacheEntry *diskEntry = nil;
    if (_pipeline.diskCache) {
        diskEntry = [[TIPImageCacheEntry alloc] init];
        if (imageFilePath && ([[NSFileManager defaultManager] fileExistsAtPath:imageFilePath] || (!imageData && !imageContainer))) {
            diskEntry.completeImageFilePath = imageFilePath;
        } else if (imageData) {
            diskEntry.completeImageData = imageData;
        } else {
            TIPAssert(imageContainer);
            memoryEntry.completeImage = imageContainer;
            TIPAssert(memoryEntry.completeImage);
        }
    }

I don't know if I'm overlooking something which is definitely possible but it looks like a copy and paste error?

Either way I think it doesn't solve my issue but it's worth looking into 😄

Handling updated images on static URLs

Hi guys! You published this library very conveniently since we just yesterday started seeing problems with our image caching over at Forza Football. Reading your description, they are similar to yours, and everything this library does seems to fit us very well, so we are evaluating it right now.

However, there is one problem that pretty much every image caching library on iOS suffers from - how to handle updated/outdated images. I would like to ask you if it's possible (or how you would solve) an updated image residing on the same URL as before.

For example, if our servers set a max-age of 3 days - will the library discard the image after 3 days and request a whole new one, even if it's the same image? We sometimes need to update an image on the same URL, so we can't set a too high max age. But we still would like the HTTP-caching functionalities. Ideally, after 3 days, the library would request the image, and if it gets a 304, it just keeps the same image in the cache and refreshes the TTL.

Looking at the process you describe in your README, it seems to me that the library will never attempt to refresh an image if it's already in the cache. Is this true?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.