tylingsoft / dagre-layout Goto Github PK

Thanks for taking up this project! I'm having issues switching from the normal dagre lib when importing. I had been just using import dagre from 'dagre' then following the wiki directions directly. With the dagre-layout import, however, I'm getting TypeError: Cannot read properties of undefined (reading 'Graph'). I tried several options, but the usage isn't clear. Are you no longer bundling graphlib? If so, the dagre wiki is no longer a good guide on how to set up the lib.

I'm adding a declaration to the DefinitelyTyped repo here, which will allow the library to be used in a typechecked fashion, but evidently it's preferred if they're checked in to the package itself. I don't quite have time to do this; letting you know in case you do. Thanks for a useful library!

There are some instructions here.

Used in CockroachDB; checked type declarations into our repo but would prefer to have them elsewhere.

Not sure if you have any interest in this. I am cross posting this from the main dagre repo. Basically I have a graph that when laid out throws the following error:

TypeError: Cannot set property 'order' of undefined
    at ./node_modules/dagre-layout/dist/dagre-layout.core.js:1:16798
    at arrayEach (./node_modules/dagre-layout/node_modules/lodash/lodash.js:508:11)
    at Function.forEach (./node_modules/dagre-layout/node_modules/lodash/lodash.js:9334:14)
    at./node_modules/dagre-layout/dist/dagre-layout.core.js:1:16759
    at arrayEach (./node_modules/dagre-layout/node_modules/lodash/lodash.js:508:11)
    at Function.forEach (.source/node_modules/dagre-layout/node_modules/lodash/lodash.js:9334:14)
    at v (./node_modules/dagre-layout/dist/dagre-layout.core.js:1:16727)
    at t.default (./node_modules/dagre-layout/dist/dagre-layout.core.js:1:17145)
    at ./node_modules/dagre-layout/dist/dagre-layout.core.js:1:30614
    at w (./dagre-layout/dist/dagre-layout.core.js:1:3619)

I was able to replicate this, in this fork also. Here is the relevant gist.

https://gist.github.com/mmacfadden/2c923a6c7209308745296d489289f316

Here is the Dagre issue: dagrejs/dagre#234

Happy to see people picking up the torch on this useful library. My questions are:

1. What are the updates / differences between this and dagre or dagre-d3?

2. What was missing that you're working on?

Thanks

Latest npm release is 0.8.8 but corresponding tag is missing from this repo, please add it. I'd like to build from source and use github tarballs.