typed-typings / npm-bluebird Goto Github PK

Based on Bluebird's cancellation reference callback passed to Promise constructor should accept optional onCancel hook and Promise instances should have cancel method. There is also inspection method isCancelled for checking if promise has been cancelled.

I suggest getting rid of functionality tests altogether. They're not useful and they block us from having more extensive type tests. I'd rather have something like what's in env-node and typed-sequelize.

Version 5.4.3 of tslint just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As tslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Hi,
I would like to know what is the problem with the declaration of .get.

This is the related part:

    /**
     * This is a convenience method for doing:
     *
     * <code>
     * promise.then(function(obj){
    *     return obj[propertyName];
    * });
     * </code>
     */
    // TODO find way to fix get()
    // get<U>(propertyName: string): Promise<U>;

Isn't it possible to just type it as get<U>(key: string | number): Promise<U>; ?

@types/bluebird gives the following error:

node_modules/@types/bluebird/index.d.ts(623,33): error TS2304: Cannot find name 'Map'.
node_modules/@types/bluebird/index.d.ts(623,78): error TS2304: Cannot find name 'Map'.
node_modules/@types/bluebird/index.d.ts(810,39): error TS2304: Cannot find name 'Map'.
node_modules/@types/bluebird/index.d.ts(810,78): error TS2304: Cannot find name 'Map'.
node_modules/@types/bluebird/index.d.ts(813,27): error TS2304: Cannot find name 'Map'.
node_modules/@types/bluebird/index.d.ts(813,65): error TS2304: Cannot find name 'Map'.

Should this be valid?

import Promise = require('bluebird');

new Promise((resolve, reject) => {
  resolve();
});

Currently, we have to:

...
new Promise((resolve, reject) => {
  resolve(null);
});

Operand for 'await' does not have a valid callable 'then' member

[ts] Type 'Bluebird<Model[]>' is not assignable to type 'Promise<User[]>'.
       Types of property 'then' are incompatible.
         Type '{ <U1, U2>(onFulfill: (value: Model[]) => U1 | Thenable<U1>, onReject: (error: any) => U2 | Thena...' is not assignable to type '{ <TResult1, TResult2>(onfulfilled: (value: User[]) => TResult1 | PromiseLike<TResult1>, onreject...'.
           Type 'Bluebird<any>' is not assignable to type 'Promise<any>'.
             Property '[Symbol.toStringTag]' is missing in type 'Bluebird<any>'.

This prevents Sequelize users from writing methods with a Promise return type and returning a bluebird promise.

types/sequelize#78

Was looking at latest definition file and didn't see that the .reflect method does not appear.

Is it possible that the .inspect method is a vestige from a previous version of the API?

Version 3.0.5 of ts-node just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As ts-node is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Hi,
I encountered an error when I wanted to use .resolve to nomalize a value that could either be a Promise or already resolved. The compiler did not let me do that:

type EventualPromise<T> = T | Bluebird.Thenable<T>;

let eventualStringPromise: EventualPromise<string>;

Bluebird.resolve(eventualPromise)
  .then((resolved: string) => {
    console.log(resolved);
  });

This fails because string | Bluebird.Thenable<string> is not assignable to string.

Here are the related definitions:

// currently:
static resolve(): Bluebird<void>;
static resolve<R>(value: Bluebird.Thenable<R>): Bluebird<R>;
static resolve<R>(value: R): Bluebird<R>;

// Proposed:
static resolve(): Bluebird<void>;
static resolve<R>(value: R | Bluebird.Thenable<R>): Bluebird<R>;

Hi,
I just noticed that the fix to .get and .join that I made a few weeks ago were lost.
Here is this repo's history:

The loss occurred during the highlighted merge, but it's a bit strange: the other projects did not have the same origin. Is it possible to revert it quickly ? (I'll submit a pull request but maybe there is a better way to do it).

Promise.reflect() returns a Promise<PromiseInspection>, but the current definition has it returning just a PromiseInspection.

See the conversation here

Opening this ticket to track progress. Will submit a PR eventually, unless someone swoops me beforehand

Bluebird API reference

It is currently valid to define .catch using a shorthand predicate. The current definition only supports function predicates.

Code snippet of a valid .catch

.catch({code: 'ENOENT'}, function(e) {
    console.log("file not found: " + e.path);
});