GithubHelp home page GithubHelp logo

Comments (4)

rossabaker avatar rossabaker commented on July 26, 2024

Is it because it's based on thread local storage? Is that test supposed to run on the "dirty stuff" I kneejerkily tried to remove in #852, to quarantine it from polluting any other test?

from log4cats.

rossabaker avatar rossabaker commented on July 26, 2024

I don't have time at the moment to dig deep into the intent, but I'd start exploring the git history hereabouts?

from log4cats.

morgen-peschke avatar morgen-peschke commented on July 26, 2024

There isn't much, unfortunately, just that it shouldn't be blocking, and that there was a bug a while back that would clear the MDC before logging happened.

I can fix the test pretty easily by clearing the MDC before each test, but I didn't want to do that if this is actually a bug 🤷🏻

I could fix it in the test, and we can leave this issue open until someone remembers what the intended behavior is (because I can definitely see good arguments for either behavior)

from log4cats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.