ub-cse / officehours

A web-based system to manage office hours

OfficeHours

A web-based system to manage office hours

officehours's Issues

Are any of these PR's going to be merged?

Should I just close my PR? Because otherwise it sticks at the top of my github feed. If these PR's were just for the sake of the assignment I can close it. But if you actually intend to merge some of these I can keep it up. I will probably just remove it by the end of the week if there isnt a response though.

Failed to compile project in Scala SDK 2.13

Expected Behavior

Compile project in Scala SDK 2.13

Current Behavior

While compiling the project with SDK 2.13, the compiler would throw illegal cyclic inheritance involving trait Iterable.

J:\Code\OfficeHours\src\main\scala\model\OfficeHoursServer.scala:18:58
illegal cyclic inheritance involving trait Iterable
  var usernameToSocket: Map[String, SocketIOClient] = Map()

Possible Solution

Switching Scala SDK back to 2.12.9 would work.

I saw some posts about the illegal cyclic inheritance error in StackOverflow, but not sure why, it might be an issue with Scala.

I recommend switching Scala SDK back to 2.12.9 if you meet the same issue before anyone figures out what causes the issue.

Timestamp is incorrect when a user joins the queue

Expected Behavior

The server returns the current UNIX time in ms.

Current Behavior

The server returns a time that is seemingly random.

Possible Solution

Change System.nanoTime() to System.currentTimeMillis()

https://github.com/UB-CSE/OfficeHours/blob/develop/src/main/scala/model/OfficeHoursServer.scala#L63

class EnterQueueListener(server: OfficeHoursServer) extends DataListener[String] {
  override def onData(socket: SocketIOClient, username: String, ackRequest: AckRequest): Unit = {
>>>>server.database.addStudentToQueue(StudentInQueue(username, System.nanoTime()))<<<<
    server.socketToUsername += (socket -> username)
    server.usernameToSocket += (username -> socket)
    server.server.getBroadcastOperations.sendEvent("queue", server.queueJSON())
  }
}

Steps to Reproduce

1. Click the join queue button a few times
2. Look at the time stamps in the waiting list
3. Convert time stamps from UNIX to human time

Context (Environment)

It is important to see when people have queued.
This information could help give an estimate of how long someone would have to wait before they queue or it could indicated that the TA's can not keep up with the demand.

Detailed Description

According to https://docs.oracle.com/javase/8/docs/api/java/lang/System.html, System.nanoTime() returns the Returns the current value of the running Java Virtual Machine's high-resolution time source, in nanoseconds., not the current UNIX time.