ubdanam / react-todo-app

Hi , I'm Abdurahim Miftah

About

• 🕵️‍♂️ I’m currently working on Game Vault with React and TypeScript

• 🌱 I’m currently learning Intermediate Ruby on rails

• 👯 I’m looking to collaborate on D3.js

• 👨‍💻 All of my projects are available at my Portfolio

• 📄 Checkout my LinkedIn profile

• 💬 Ask me about JavaScript, React, Ruby on Rails, and Jest

• 📫 How to reach me Email

• 📄 Know about my experiences Resume

• ⚡ Pronouns: He/Him

• 😄 Fun fact The GitHub mascot is an Octocat, which is a cute combination of an octopus and a cat
  
  

🔗 Connect with me: Links

🧰 Languages and Tools

📊 Github Stats and Activity

 

Support ˗ˏˋ☕ˎˊ˗

react-todo-app's Issues

Required changes ♻️

          Required changes ♻️ 

Hey [@UbdaNam ] 👋
Highlights 🥇
➡️ Descriptive PR Title
➡️ Linters are passing
➡️ Following some requirements
➡️ Following the Design 💄

↪️ Good job on implementing some of the requirements, there are some issues that you still need to work on to complete your project.You will find requested changes below. you are almost there! 😊

Optional
All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.

Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

In [README.md]

• Please you should add live demo in your readme file it will much better 💯

[TodoApp.jsx]

• Please move this TodoApp.jsx file to components folder. So its make your project clean 👍

Originally posted by @hasnatali1947 in #1 (review)