ubdanam / to-do-list

Stay organized and on top of your tasks with my easy-to-use to-do app. With a simple and intuitive interface, you can quickly add, edit, and delete your tasks. Built with love using HTML, CSS, and JavaScript

Hi , I'm Abdurahim Miftah

About

• 🕵️‍♂️ I’m currently working on Game Vault with React and TypeScript

• 🌱 I’m currently learning Intermediate Ruby on rails

• 👯 I’m looking to collaborate on D3.js

• 👨‍💻 All of my projects are available at my Portfolio

• 📄 Checkout my LinkedIn profile

• 💬 Ask me about JavaScript, React, Ruby on Rails, and Jest

• 📫 How to reach me Email

• 📄 Know about my experiences Resume

• ⚡ Pronouns: He/Him

• 😄 Fun fact The GitHub mascot is an Octocat, which is a cute combination of an octopus and a cat
  
  

🔗 Connect with me: Links

🧰 Languages and Tools

📊 Github Stats and Activity

 

Support ˗ˏˋ☕ˎˊ˗

to-do-list's Issues

Import from main index.js into modules

Please consider only importing from modules to the index.js file.

Peer-to-peer code review

Highlights

• Good design
• Good folder structure and architecture
• Good use of objects
• Good tests

Issues

• Some UI improvements are needed, such as greying out completed tasks, and italicizing tasks as they are being written

JavaScript best practice review

Make use of JavaScript best practices

• Use object destructuring for clean and DRY code. Code: https://github.com/UbdaNam/To-Do-list/blob/main/src/index.js#L25-L27
• Use KISS and SOLID principles to decrease dependencies between files and make each module specified to a single responsibility. Code1: https://github.com/UbdaNam/To-Do-list/blob/main/src/modules/addTask.js#L1-L12,
  Code2: https://github.com/UbdaNam/To-Do-list/blob/main/src/modules/removeTask.js#L1-L5
• I can stringify before adding the tasks to the local storage with one line of code rather than allocating new space by using the new variable. Code: https://github.com/UbdaNam/To-Do-list/blob/main/src/modules/localStorage.js#L2-L3
• Use descriptive variable names, here I can use "task" rather than "item" to identify each task. Code: https://github.com/UbdaNam/To-Do-list/blob/main/src/modules/markCompleted.js#L2-L4
• Make use of implicit return for the anonymous function to write clean code. Code: https://github.com/UbdaNam/To-Do-list/blob/main/src/modules/updateIndex.js#L2-L4

It feels great to review my code and apply what I learned practically. 👍 for me