GithubHelp home page GithubHelp logo

ubports / address-book-app Goto Github PK

View Code? Open in Web Editor NEW
12.0 13.0 16.0 15.07 MB

Moved to GitLab: https://gitlab.com/ubports/core/address-book-app

Home Page: https://gitlab.com/ubports/core/address-book-app

License: Other

CMake 3.53% C++ 6.73% QML 70.91% JavaScript 2.01% Python 16.82%

address-book-app's Introduction

Building for desktop

mkdir build
cd build
cmake ..
make

Run

on desktop

cd build
./src/app/address-book-app

the QML tests

cd build
make test or ctest 

the Autopilot tests

cd build
make autopilot

Building for click

To build for a click package:

clickable

address-book-app's People

Contributors

billfiller avatar cibersheep avatar dobey avatar ebeton-ro avatar elleo avatar fkaleo avatar flohack74 avatar ivoxavier avatar kenvandine avatar kugiigi avatar lduboeuf avatar mardy avatar martinpitt avatar mk1973 avatar mutse avatar mymike00 avatar rodrigo527 avatar saviq avatar sergiusens avatar sil2100 avatar surc-bot avatar ted-gould avatar tigrankhachatryan0 avatar tsdgeos avatar twinkybot avatar universalsuperbox avatar warsaw avatar weblate avatar yarons avatar zsombi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

address-book-app's Issues

Exporting ubuntu_contacts.vcf in Files does not overwrite.

Hello,

When exporting contacts in a folder that already possess an ubuntu_contacts.vcf file, that does not seems to overwrite.
The date remains the old one. (I did not dare to import it to avoid a mess like duplication..)
Plus, I cannot open that vcf file with "visionneur de documents" (Doc visualizer?). Does an App exist to do that (without importing)?

Thanks
(mako; stable channel; OTA5-->OTA-10)

address-book-app does not have a maintainer

No one is currently maintaining this app. If you would like to become the maintainer, please reply to this issue or get a hold of us via another method.

The app maintainers will be responsible for coordinating the following (doing it yourself is still coordinating, if you prefer that):

  • Triaging bugs
  • Fixing bugs
  • Vetting and implementing enhancement requests
  • Corresponding with the UBports project regarding the app's progress
  • Requesting bounties be posted for the app
  • Keeping a little booklet with everyone's contact information in it

Unable to build from clickable

clickable
Sending build context to Docker daemon 3.584kB
Step 1/3 : FROM clickable/ubuntu-sdk:16.04-armhf
---> a6eb470aafc3
Step 2/3 : RUN echo set debconf/frontend Noninteractive | debconf-communicate && echo set debconf/priority critical | debconf-communicate
---> Using cache
---> f600430542a1
Step 3/3 : RUN apt-get update && apt-get install -y --force-yes --no-install-recommends libqofono-dev:armhf ofono-dev:armhf intltool:armhf pkg-config:armhf qt5-default:armhf qtbase5-dev:armhf qtdeclarative5-dev:armhf qtpim5-dev:armhf qml-module-ofono:armhf qtdeclarative5-buteo-syncfw0.1:armhf qtdeclarative5-gsettings1.0:armhf qtdeclarative5-ubuntu-history0.1:armhf qtdeclarative5-ubuntu-keyboard-extensions0.1:armhf qtdeclarative5-ubuntu-telephony-phonenumber0.1:armhf qtdeclarative5-qtcontacts-plugin:armhf qml-module-qtquick2:armhf qtdeclarative5-qtcontacts-plugin:armhf && apt-get clean
---> Using cache
---> 6a2591c019e7
Successfully built 6a2591c019e7
Successfully tagged clickable/ubuntu-sdk:16.04-armhf-c2cc1906-9466-4a8e-b06e-70b5c261fd48
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/arm-linux-gnueabihf-gcc
-- Check for working C compiler: /usr/bin/arm-linux-gnueabihf-gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/arm-linux-gnueabihf-g++
-- Check for working CXX compiler: /usr/bin/arm-linux-gnueabihf-g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Autopilot tests disabled: autopilot binary not found
-- Found PkgConfig: arm-linux-gnueabihf-pkg-config
-- Checking for module 'libqofono-dev'
-- /usr/bin/pkg-config: 1: /usr/bin/pkg-config: Syntax error: word unexpected (expecting ")")
CMake Error at /usr/share/cmake-3.5/Modules/FindPkgConfig.cmake:367 (message):
A required package was not found
Call Stack (most recent call first):
/usr/share/cmake-3.5/Modules/FindPkgConfig.cmake:532 (_pkg_check_modules_internal)
CMakeLists.txt:25 (pkg_check_modules)

-- Configuring incomplete, errors occurred!
See also "/home/ruben/Transferências/address-book-app-master/build/arm-linux-gnueabihf/app/CMakeFiles/CMakeOutput.log".
Command exited with non-zero exit status 1, see above for details. This is most likely not a problem with Clickable.

Shadow variable

/src/app/addressbookapp.cpp line 324
variable 'args' shadows line 319
QStringList args;
QMap<QString, QStringList> methodsMetaData;
if (methodsMetaData.isEmpty()) {
QStringList args;

Contact list items do not support swipe actions

The current contact items cannot be swiped left or right, as expected from the system experience. I was just struggling to delete a contact, by swiping it right.
At least the delete option for a single contact should be available there. Also maybe on swipe left you could have a forward/share option.

Sort contacts by the last name

It would be nice to have an config option in settings to sort contacts by "last name, first name", right now it's sorted by "first name" first. Like this it's hard to find a proper contact for people I do not call offer and do not remember their first name. Also it would help to keep each family together in a contact list.

Feature request - Add buttons on the right of someone's physical address

Buttons/icons exist on the right of the main page of each contact to quickly call, text or send an email.
When the physical address (street, city) is filled in, it could be great to have similar buttons to visualize on a map and even navigate to this position.

See the initial discussion in issue #22.

No warning message when creating a duplicate

It is possible to create a duplicate in contacts (same first name, same family name) by mistake.
Adding a simple warning message could be interesting.

Note: the intent is NOT to block the creation of two contacts with the same first name and family name as namesakes/homonyms are still possible.

Duplicate string in hu.po prevents app building in Crossbuilder

Description:

Crossbuilder fails to build the app due to a problem with hu.po

Device:

Ubuntu 18.04 on the desktop. BQ M10 16.04

Steps to reproduce:

run crossbuilder to attempt to build the app as per instructions here: https://docs.ubports.com/en/latest/appdev/system-software.html#cross-building-with-crossbuilder

Expected behaviour:

"Crossbuilder will do everything for you: it will create the LXD container, download the development image, install all your package build dependencies, perform the build .... "

Actual behaviour:

Crossbuilder sets up the LXD container, downloads the development image and fails because of a duplicate string being translated in hu.po

Logs and additional information:

Lines 38 - 44 of hu.po:

#: ../src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditor.qml:307
msgid "Add Field"
msgstr "Mező hozzáadása"

#: ../src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditor.qml:307
msgid "Add Field"
msgstr "Mező hozzáadása"

When building the app with crossbuilder this causes the following fatal error:

[  9%] Generating hu.gmo
cd /home/padraic/address-book-app/po && /usr/bin/msgfmt -o /home/padraic/address-book-app/obj-arm-linux-gnueabihf/po/hu.gmo /home/padraic/address-book-app/po/hu.po
/home/padraic/address-book-app/po/hu.po:43: duplicate message definition...
/home/padraic/address-book-app/po/hu.po:40: ...this is the location of the first definition
/usr/bin/msgfmt: found 1 fatal error
cd /home/padraic/address-book-app/obj-arm-linux-gnueabihf/src/imports/Ubuntu/Contacts && /usr/bin/cmake -E copy /home/padraic/address-book-app/src/imports/Ubuntu/Contacts/SIMList.qml /home/padraic/address-book-app/obj-arm-linux-gnueabihf/src/imports/Ubuntu/Contacts/
[ 10%] Built target pofiles_52
make -f po/CMakeFiles/pofiles_49.dir/build.make po/CMakeFiles/pofiles_49.dir/depend
po/CMakeFiles/pofiles_55.dir/build.make:63: recipe for target 'po/hu.gmo' failed
make[3]: *** [po/hu.gmo] Error 1

Full output here: https://paste.ubuntu.com/p/vqZGst3Tds/

Groups for contacts

To make it easier to find certain contacts you should be able to group them.
These would be shown in a different tab to select the groups.

pressing the search icon in address-book-app does not raise the OSK

* Device: BQ E5 (vegetahd)

* Channel: rc

* Build: 2018-W41/2 all the way through to now 2019-W09

Steps to reproduce

* open contact app

* tap on spyglass icon for search

* not the search field opens

Expected behavior

* the keyboard should open as well, the search field should get the focus

Actual behavior

* no keyboard appears (although there is a bit of a flicker at the bottom, I suppose the app tries to raise the keyboard but it does not work)

* swiping from the bottom brings up the "new contact" screen

* I have to tap the search bar to get the keyboard

I think this is since the W41 update, maybe even the upgrade to 16.04
On 15.04 it was working fine.

Confirmed by @jezek in his comment to #56 .

Contacts Initial Layout

Shouldn't the Contacts page start with the Favourites showing rather than All. Presumably the Favourites are what everyone uses most.

on dual sim devices only one number is gives as "my phone number"

E5, dev channel

When opening the settings page, after 1 or 2 seconds a field containing information on "my phone number" appears. This field does display only the number of my second sim card. With dual sim devices it should show:

a) the "primary" number set for calls/sms/mobile data [tricky to tell which is the primary one, only works if one number covers all of those -> ask the user maybe?]

b) both numbers [the better option I would say]

Importing contacts from .vcf file creates an error and imports only the first contact/address.

Device: bq E4.5
OS: Switched from UT (canonical) to UT 15.04 r2 (ubports)
Error: Importing contacts file created an error

Problem:
Import contacts via "files" -> click on .vcf file -> open with "contacts" gives the error "Failed to import". As a results only the first contact is imported.

Solution:
Open the terminal and enter the following command: "syncevolution --import /path/to/file/allcontacts.vcf backend=evolution-contacts database=Personal"

Note: "Personal" may vary with different languages.

Exporting contact filename can be corrupted by using some non alphabetical characters in name or surname

Was mentioned in #119

Reproduce:

  • create an contact with name hash#name
  • exported contact to to file (share via File manager)

Expected filename: hash#name.vcf
Resulted filename: hash

File without .vcf suffix isn't importable again and needs to be renamed before import (adding .vcf worked).
When exporting this contact to message app, the attachment no longer has avatar from contacts (image or rectangle with letter(s)), but an paper clip (:paperclip:) and may be unable to import if sent to someone (import after sending not tested).

Note: there may be other characters, which could cause similar error.

Navigation in Contacts

In order to display the alphabet letters on the right side of the screen to navigate faster to the contacts starting with a certain letter, there is the need for a swipe up on the screen. Is this how it was designed to behave or is it a bug? If this is how it's supposed to be then what is the reasoning behind? - because everytime I access Contacts I need this extra swipe in order to access the letters.

Thank you for taking this into consideration and thank you for doing such an amazing job!

Crossbuilder fails

When running crossbuilder in the project directory, it fails to build.

The console output when running crossbuilder is here.

I can fix the problem by attaching :all to the dh-translations package in the debian/control file, as follows.

Build-Depends: cmake,
               dbus,
               debhelper (>= 9),
               dh-apparmor,
               dh-translations:all,
               libgl1-mesa-dev | libgl-dev,
               libgles2-mesa-dev,

Wrong button colors when removing contact

When removing a contact, button colors are inverted.

Question: Do you want to remove contact?
Answer: yes (negative action. Should be red)
Answer: no (neutral answer. Could be ash)

Feature request: sorting contacts

By default contacts sorts: First name, Middle name, Last name.

Need function to change it.

I will see: Last name, First name, Middle name.

`Contacts sort:

  • First name, Last name
  • Last name, First name`

Accounts

This relates to the 'Accounts' feature in System Settings. Wasn't sure where to put this. Sorry if it's in the wrong place.

If I go to accounts and choose Google. I get the spinning blue circle forever.

MX4 with 16.04/dev.

No way to block contacts

You should be able to block numbers so they can't call and/or text you.
(related to Messaging-app and dialer-app)

unable to share contacts via file manager

I am unable to share contacts via file manager.
Using E5, 16.04 RC 2018-W01 (from 208-12-31).
(I do have the memory of this issue (sharing with file manager) has been talked about somewhere but I can not find it at the moment.)

Steps to reproduce:
open address-book app
tap and hold contact
select share icon
select file manager
select folder within file manager
press select

expected result:
a .vcf file with the contact(s) is created

actual result:
nothing happens

Search yields unexpected results

Hi, using N5 Ubuntu 16.04 (2019-W09) I added 6 Contacts: A B, C D, E F, G H, I J and X Y; when I enter in the search field T or Z all contacts are shown which is not the case with other letters except: A,B,C,D,E,F,G,H,I,J,X and Y.
See also issue: #56

Expose vcf import in interface

A report at [this forum thread[(https://forums.ubports.com/topic/420/successful-ubports-installation-and-contacts-import-on-nexus-5/2) states that .vcf files cannot be imported from within the Contacts app, but opening them from the file manager is possible.

Provide an option in the interface to browse for and import vcard files at will.

Include REV and UID field in file export

I noticed that exporting contacts via UI leads to noticeably smaller files than exporting via

$ syncevolution --export /home/phablet/Documents/utcontacts.vcf backend=evolution-contacts

Further inspections shows that records from the shell command contain some more optional (REV, UID) plus some non-standard vcard fields. While I don't care about the non-standard ones, I do wonder if dropping the former is intentional.

Granted, when importing contacts from a .vcf file, I think an application should not use existing information from fields REV and UID. That is, it would better create unique UIDs itself and set last modification time to the time of the import. Though, during export, I'd perhaps not drop those fields as the information may be of interest (for REV). Or it could make life easier when doing some further processing of an exported .vcf file (for UID). Think of two intentionally identical, e.g., sparsely filled, contacts that have different UID. UT contacts app would show those as two distinct contacts. But after UI export, that explicit information is lost.

I'm not saying the current behaviour is wrong. After all REV and UID are optional fields only. But I'm not convinced either, dropping is the best way to handle REV and UID fields during export. My recommendation is to include both fields.

A contact should have more options/actions

When I'm on the info about a contact I have a button to message with the contact and another to call him. The second one doesn't call the contact however, it just copy the number in the Dialer.
It was great to add another button that call directly the contact (sometimes I tap to call someone and I wait for his reply but the call isn't stared yet ^^)

I was thinking something like this:
contact
maybe it requires a new suru icon (to copy the phone number in the Dialer, to call directly it's ok the handset), something that joins the handset and the copy-icon? or just an arrow with the handset? the icon of the external link? Well I don't know I'm not a designer, just some ideas...

call-arrow svg call-arrow2 svg call-copy svg call-to svg

So 3 icons:

  • Message icon - to send a message
  • Handset icon - to call directly
  • todo icon - to copy the number in the Dialer

This is my idea, but the 2nd and the 3rd icons can be swapped...

New field birthday not translated

Bug: use the Surudark theme add a birthday field ( field not translated)

On selection of the date its all white and after when you try to see the date on the contacts it's also all white.
Could be a UITK bug
but screenshots are better than anything.
screenshot20200830_161227633

screenshot20200830_161209935

Please add dark mode

SuruDark works already good within the app. Would be great having the choice in the settings. Like in the Messaging App.

Add CardDav support

Add Carddav support so Contacts can be synced with Owncloud/Nextcloud or any other Carddav Server.

FastScroll gets in the way of the Call action

After scrolling, the FastScroll list remains on screen for a few seconds. During this time, pulling a contact to the left to expose its trailing actions reveals the call action. For most contacts (except those at the very beginning and end of the list), the call action is underneath the FastScroll list. Trying to tap on the call action instead activates the FastScroll.

Screenshot of contacts-app showing A-Z fastscroll list overlaying the Call action

Favorite button hard to see

Depending on the background image for a contact the favorite/star button can be difficult to see. I suggest moving it to the header buttons, but that's just me.

Info Field for Contacts

I have a lot of (small) informations that i need for my customers in my contact, these are saved on my Nextcloud server, but unfortunaly the "info" field doesn't exists in the app so there things aren't importet

Is it possible to add this field ?

xvfb should be marked with <!nocheck>

Description:

Crossbuilder fails to build the app due to a problem with unmet dependencies.

Device:

Ubuntu 18.04 on the desktop. BQ M10 16.04

Steps to reproduce:

Run crossbuilder to attempt to build the app as per instructions here: https://docs.ubports.com/en/latest/appdev/system-software.html#cross-building-with-crossbuilder

Expected behaviour:

"Crossbuilder will do everything for you: it will create the LXD container, download the development image, install all your package build dependencies, perform the build .... "

Actual behaviour:

Crossbuilder sets up the LXD container, downloads the development image and fails on installing dependencies.

Logs and additional information:

Attempting to build with crossbuilder returns this error:

builddeps:address-book-app:armhf : Depends: dh-translations:armhf but it is not installable
                                    Depends: xvfb:armhf

Discussion

From discussion with @mardy on this issue it seems that the issue is that xvfb should be marked with <!nocheck> in debian/control.in and / or debian/control.

Old Components

We still use ListItems in src/imports/Settings/SettingsPage.qml which is deprecated

No birthday field

There's no field to add someone's birthday, there should be this option, and it should sync with the calendar to show someone's birthday is on a certain day.

Problems in the search function

with the latest updates, a problem has started with the search function.
When I open the "contacts" window from the phone or directly from the contacts app, the cursor is automatically positioned in the search bar (well! First this did not happen and I had to make an extra step)
But by typing the letters on the keyboard, the search does not work. You can not do the research.
Sometimes it happens that the cursor, instead, does not position itself directly on the search bar (rarely, I did not notice which combination causes it), in this case, after positioning the cursor, the search works perfectly
I use BQ 4.5 DEV last update

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.