GithubHelp home page GithubHelp logo

ubports / media-hub Goto Github PK

View Code? Open in Web Editor NEW
1.0 1.0 6.0 17.11 MB

Moved to GitLab: https://gitlab.com/ubports/core/media-hub

Home Page: https://gitlab.com/ubports/core/media-hub

License: GNU Lesser General Public License v3.0

CMake 4.57% C++ 88.13% Shell 0.16% Python 6.96% C 0.18%

media-hub's People

Contributors

albaguirre avatar alfonsosanchezbeato avatar dobey avatar flohack74 avatar fredldotme avatar lduboeuf avatar maddin200 avatar mardy avatar mariogrip avatar morphis avatar ogra1 avatar sergiusens avatar tjyrinki avatar tsdgeos avatar universalsuperbox avatar vicamo avatar vorlonofportland avatar wdehoog avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

media-hub's Issues

CMakeLists.txt wrong

there is a duplicate check

pkg_check_modules(PROCESS_CPP process-cpp REQUIRED)

and it's missing

/usr/bin/ld: cannot find -lhybris-common
collect2: error: ld returned 1 exit status

so should add libhybris-common to pkg_check_modules

Ringtones don't work anymore

Description:
Since the recent merge of the remotemedia branch into xenial media-hub fails to play back ringtones.

Steps to reproduce:

  • Upgrade to devel
  • Select a ringtone from the ringtones list in system-settings

Expected behavior:

  • Ringtone plays back

Actual behavior:

  • Ringtone fails to play back

Steps to get back to a working state:

sudo mount -o remount,rw /
sudo apt update
sudo apt install media-hub=4.6.2+0ubports1+0~20201010065504.5~1.gbp9d51fe
sudo apt install libmedia-hub-client5=4.6.2+0ubports1+0~20201010065504.5~1.gbp9d51fe
sudo apt install libmedia-hub-common5=4.6.2+0ubports1+0~20201010065504.5~1.gbp9d51fe
sudo reboot

Display goes blank when playing remote videos

To reproduce it, set the display lock to 30 seconds, then install the MiTubo application from the store, play a video (longer than 30 seconds) and you'll see that displays goes off.

This is because since the media is remote, it's initially assumed to be audio only. It's only when the playback starts that gstreamer fetches the remote resource and reports that a video stream is also available. media-hub is currently not handling this event as it should.

allow to customize playbin properties

When playing flac files from my UPnP server the audio is distorted.

I added 'buffer-size' and some flags (download and buffering) to the playbin object and it seems to help. A lot.

As I do not want to hardcode these values in media-hub I am asking for some pointers on how these parameters can be made configurable.

Display is woken up when playback starts with display off

  1. Open the Gallery
  2. Tap a video for playback
  3. Tap the Play button so the media-player app starts
  4. Lock the screen before the media-player app loads

After a few seconds, the screen turns back on and video playback begins behind the lock screen.

repeat single song does not work with new media hub anymore

I do have a MR open to implement single song repeat in music app.

Since adding the new media hub into devel, repeat single song does not work anymore. Might be related to #31 .
After a song is finished, it resets the time to zero but does not restart to play the song.

Playing two things at the same time causes the device to stop sleeping

When two separate players are created, played, and stopped in rapid succession, the media-hub service requests two system wakelocks from repowerd, one for each player. Repowerd happily issues, say, IDs 9 and 10. When the players clear, media-hub clears wakelock ID 10 twice. This leaves ID 9 dangling, so the device never goes into deep sleep.

This can happen, for example, when Lomiri starts with an SD card with two invalid partitions on it inserted. Nuntium fires two notifications at almost exactly the same time, they both play their audio at almost the same time, and the condition is triggered.

Music keeps playing even when Music app is closed

  • Device: Xiaomi Mi A2, Sony Xperia X
  • Channel: any
  • Build: any

Steps to reproduce

open Music app
Queue as many songs as possible (the limit is changing, sometimes it's 700+ songs, sometimes 400+, it's weird)
play music from Queue (at least half of track)
close Music app

Expected behavior

music stops playing

Actual behavior

music keeps playing
when the Music app is started again its state is with triangle icon at right bottom (so music should not be playing) but the music started before the closing app is still playing in the background.

unreachable code

/tests/lib/functional/dbusmock.h line 57

Code:
case QDBusArgument::StructureType: {
value.beginStructure();
QVariantList list;
while (!value.atEnd()) {
list << value.asVariant();
}
value.endStructure();
return list;
break; // <-- unreachable

shuffle and repeat do conflict

As the result of my testing, in music app (not sure about other apps) shuffle seems to disable repeat action. Which I think is not what it should do in all cases.

To reproduce:

  • set repeat to repeat album

  • enable shuffle
    expected: songs are played randomly, when all have been played once, it does start again
    actual behaviour: if all songs are played, the music stops

  • set repeat to repeat single song

  • enable shuffle
    expected: the selected song keeps being played (in my opinion this should be overriding shuffle)
    actual behaviour: shuffle keeps playing random songs from the album

I think

  • when shuffle is enabled and repeat album is set, the album should be kept playing in random order "endless" (due to repeat)
  • when shuffle is enabled and repeat single song is set, the selected song should be played "endless"

@mardy this is with the old media hub, it has got nothing to do with #50 .

lookup or default image for album art is not working

Two issues with album art:

  • The default image to use in case of missing album art does not exist anymore.

  • The 'dash image proxy', whatever it was, does not exist anymore.

The result is there is no default album art image shown in the sound indicator.

Not a very big problem I admit.

fails to build with crossbuilder

When I try to build it using crossbuilder it fails and complains about non installed files.

Packages are build after:

cp debian/libmedia-hub-common.install.in debian/libmedia-hub-common5.install
cp debian/libmedia-hub-client.install.in debian/libmedia-hub-client5.install

AppArmor prevents playing audio files from temp dir

  • Device: FP2
  • Channel: dev
  • Build: 2019-08-21/2

Steps to reproduce

Develop an app that tries to play audio files from app's temp dir or use this Pure Maps branch. See README on how to build the app. In the app go to Settings -> Test to test TTS.

Expected behavior

Sound can be played when file is located at temp dir.

Actual behavior

AppArmor prevents app to play sound to be played when file is located at temp dir (e.g. /run/user/32011/confined/pure-maps.jonius/pure-maps-nkz88va5/tmpma4imrj5.wav).

App is even allowed to create that file, but not to play it. When using another location like the app cache, this issue does not occur.

Logfiles and additional information

error.log
relevant line from log:

mpris.Player.Error.InsufficientAppArmorPermissions: Warning: Failed to authenticate necessary apparmor permissions to open uri: Client is not allowed to access: file:///run/user/32011/confined/pure-maps.jonius/pure-maps-nkz88va5/tmpma4imrj5.wav

This issue even occurs when making app unconfined.

music app does not start to play the next songs

[devel 2021-06-08, Xperia X, 64bit]

Open music app, Open an album with several songs. Start to play the whole album.

Expected behaviour:

  • after one song has finished, the app proceeds to the next song and plays that

Actual behaviour:

  • music app in foreground: if one song has finished, the app proceeds to the next song BUT does not play the song
  • music app in background: the current song gets repeated once, then the app skips one song, picks the song after the next song but does not play it

[feature request] complete scrolling of the title of a piece of music

screenshot20220107_144042663
It is not possible to see the entirety of a long title of a piece of music through the sound drop-down menu of the indicator bar when using Patrick Jane's Radio app, for example : currently, display frozen on a certain maximum number of characters.

Would it be possible to implement a complete scrolling of the title? Thanks

Cannot seek before playing

QtMultimedia allows seeking into a video which is not in playing state (this works on the Linux desktop, at least).

However, this fails in media-hub, because the call to gst_element_seek_simple() in gstreamer/playbin.cpp returns false.This might be fixed by setting the pipeline to PAUSED state (if the media was not playing already).

use embedded abum art for audio streams

media-hub relies on thumbnailer to fetch album art. This only works for local files.
Audio streams (for example from a dlna server) can contain embedded album art. Gstreamer can handle it so media-hub should be able to support them.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.