ucberkeleyseti / bl_sigproc Goto Github PK

Breakthrough Listen fork of SigProc tools

Makefile 0.50% M4 2.31% Shell 1.32% C 68.23% Fortran 18.55% C++ 0.84% TeX 6.74% Assembly 0.43% Pascal 0.06% Tcl 0.65% Lex 0.08% Yacc 0.09% SourcePawn 0.01% Objective-C 0.17% NASL 0.04%

bl_sigproc's People

Contributors

Stargazers

Watchers

bl_sigproc's Issues

Configure.ac||configure.in required

bl_sigproc# ./bootstrap autoreconf: 'configure.ac' or 'configure.in' is required
I'm greeted with this error when attempting to install.
Is there a known fix for this?
Thanks

`make` results in `ld` abort

Successfully completed the bootstrap and configure steps.
When running make, after all of the gcc, g++, and gfortran compilations are completed (oodles of warnings), ld reports multiple duplicate symbols and aborts:

/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:8: multiple definition of `isign'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:8: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `az_start'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `src_raj'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `za_start'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `src_dej'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `tstart'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `tsamp'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `fch1'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:18: multiple definition of `frequency_table'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:18: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `foff'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: multiple definition of `nchans'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: multiple definition of `telescope_id'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: multiple definition of `machine_id'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: multiple definition of `data_type'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:7: multiple definition of `ibeam'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:7: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:7: multiple definition of `nbeams'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:7: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: multiple definition of `nbits'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:4: multiple definition of `barycentric'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:4: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:4: multiple definition of `pulsarcentric'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:4: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: multiple definition of `nifs'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:19: multiple definition of `npuls'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:19: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `refdm'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:2: multiple definition of `source_name'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:2: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:2: multiple definition of `rawdatafile'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:2: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:15: multiple definition of `analog_power'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:15: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:14: multiple definition of `culprits'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:14: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:13: multiple definition of `project'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:13: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:12: multiple definition of `wapp_scan_number'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:12: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:11: multiple definition of `lst0'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:11: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:11: multiple definition of `ast0'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:11: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:10: multiple definition of `srcb'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:10: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:10: multiple definition of `srcl'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:10: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: multiple definition of `raw_foff'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: multiple definition of `raw_fch1'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: multiple definition of `header_tobs'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: multiple definition of `gal_b'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: multiple definition of `gal_l'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:6: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: multiple definition of `mjdobs'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:5: first defined here
/usr/bin/ld: read_header.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: multiple definition of `scan_number'; readtim.o:/home/elkins/Downloads/bl_sigproc-master/src/header.h:3: first defined here
/usr/bin/ld: open_files.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:33: multiple definition of `nsmax'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:33: first defined here
/usr/bin/ld: open_files.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:31: multiple definition of `nsubband'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:31: first defined here
/usr/bin/ld: open_files.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:29: multiple definition of `ndm'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:29: first defined here
/usr/bin/ld: open_files.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:27: multiple definition of `input_file'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:27: first defined here
/usr/bin/ld: open_files.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:26: multiple definition of `file_name'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:26: first defined here
/usr/bin/ld: open_files.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:24: multiple definition of `thresh'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:24: first defined here
/usr/bin/ld: open_files.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:22: multiple definition of `iterate'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:22: first defined here
/usr/bin/ld: open_files.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:50: multiple definition of `optind'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:50: first defined here
/usr/bin/ld: open_files.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:55: multiple definition of `opterr'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:55: first defined here
/usr/bin/ld: open_files.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:36: multiple definition of `optarg'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:36: first defined here
/usr/bin/ld: open_files.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:11: multiple definition of `iindx'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:11: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:33: multiple definition of `nsmax'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:33: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:31: multiple definition of `nsubband'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:31: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:29: multiple definition of `ndm'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:29: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:27: multiple definition of `input_file'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:27: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:26: multiple definition of `file_name'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:26: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:24: multiple definition of `thresh'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:24: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:22: multiple definition of `iterate'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:22: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:20: multiple definition of `optind'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:50: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:19: multiple definition of `opterr'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:55: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:18: multiple definition of `optarg'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:36: first defined here
/usr/bin/ld: single_ch.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:11: multiple definition of `iindx'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:11: first defined here
/usr/bin/ld: write_pulses.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:33: multiple definition of `nsmax'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:33: first defined here
/usr/bin/ld: write_pulses.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:31: multiple definition of `nsubband'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:31: first defined here
/usr/bin/ld: write_pulses.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:29: multiple definition of `ndm'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:29: first defined here
/usr/bin/ld: write_pulses.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:27: multiple definition of `input_file'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:27: first defined here
/usr/bin/ld: write_pulses.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:26: multiple definition of `file_name'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:26: first defined here
/usr/bin/ld: write_pulses.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:24: multiple definition of `thresh'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:24: first defined here
/usr/bin/ld: write_pulses.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:22: multiple definition of `iterate'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:22: first defined here
/usr/bin/ld: write_pulses.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:50: multiple definition of `optind'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:50: first defined here
/usr/bin/ld: write_pulses.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:55: multiple definition of `opterr'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:55: first defined here
/usr/bin/ld: write_pulses.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:36: multiple definition of `optarg'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:36: first defined here
/usr/bin/ld: write_pulses.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:11: multiple definition of `iindx'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:11: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:11: multiple definition of `iindx'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:11: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:33: multiple definition of `nsmax'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:33: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:31: multiple definition of `nsubband'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:31: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:29: multiple definition of `ndm'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:29: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:27: multiple definition of `input_file'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:27: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:26: multiple definition of `file_name'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:26: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:24: multiple definition of `thresh'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:24: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:22: multiple definition of `iterate'; pulse.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:22: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:20: multiple definition of `optind'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:50: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:19: multiple definition of `opterr'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:55: first defined here
/usr/bin/ld: thresh_1d.o:/home/elkins/Downloads/bl_sigproc-master/src/pulse.h:18: multiple definition of `optarg'; pulse.o:/usr/include/x86_64-linux-gnu/bits/getopt_core.h:36: first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:1341: seek] Error 1
make[3]: Leaving directory '/home/elkins/Downloads/bl_sigproc-master/src'
make[2]: *** [Makefile:1088: all] Error 2
make[2]: Leaving directory '/home/elkins/Downloads/bl_sigproc-master/src'
make[1]: *** [Makefile:444: all-recursive] Error 1
make[1]: Leaving directory '/home/elkins/Downloads/bl_sigproc-master'
make: *** [Makefile:376: all] Error 2

aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in'

I just noticed the warning this morning. Old habits die slowly, Yes, the modern autoconf package has changed the preferrred name: configure.in --> configure.ac.

sum_fil flips frequency axis but not data

sum_fil, if run on data with a positive foff header keyword, will flip the sign in the header to force it to be negative when writing out. The flip also changes fch1 'correctly', but does not reverse the data itself.

Compilation fails, wrong usage of parallel pragma

ake[3]: Entering directory '/packaging/kern/upstream_repos/bl_sigproc/src'
depbase=`echo dedisperse_all.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
g++ -DHAVE_CONFIG_H -I. -I.. . -DPSRFITS -I/include  -DFFTW_THREADS  -I/usr/include  -march=native -O2 -pipe -fopenmp -DHAVE_OPENMP -MT dedisperse_all.o -MD -MP -MF $depbase.Tpo -c -o dedisperse_all.o dedisperse_all.C &&\
mv -f $depbase.Tpo $depbase.Po
dedisperse_all.C: In function ‘void inline_dedisperse_all_help()’:
dedisperse_all.C:26:73: warning: unknown conversion type character ‘=’ in format [-Wformat=]
   fprintf(stderr,"-tol [1.25]        smear tolerance, e.g. 25% = 1.25\n");
                                                                         ^
dedisperse_all.C: In function ‘void do_dedispersion(short unsigned int**, short unsigned int*, int, int, int, float, int*)’:
dedisperse_all.C:173:34: error: ‘j’ has not been declared
 #pragma omp parallel for private(j)
                                  ^
dedisperse_all.C: In function ‘int main(int, char**)’:
dedisperse_all.C:262:129: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
    fprintf(stderr,"ERROR: sofware has been compiled with LONG64BIT as a datatype of %d bytes, needs to be 8\n",sizeof(LONG64BIT));
                                                                                                                                 ^
dedisperse_all.C:462:54: warning: format ‘%s’ expects argument of type ‘char*’, but argument 3 has type ‘FILE* {aka _IO_FILE*}’ [-Wformat=]
       fprintf(stderr,"Error opening file %s\n",output);
                                                      ^
dedisperse_all.C:605:116: warning: format ‘%s’ expects argument of type ‘char*’, but argument 3 has type ‘FILE* {aka _IO_FILE*}’ [-Wformat=]
    fprintf(stderr,"Error opening giant search results output file %s.\nWILL NOT RUN GIANT SEARCH.\n\n",Gresultsfile);
                                                                                                                    ^
Makefile:1494: recipe for target 'dedisperse_all.o' failed

Please make a release

for example 0.1

Please don't name it 0.1alpha, rather use semantic versioning https://semver.org/

Add description of sigproc fork

it would be very helpful to have a description of this work:

Why is this fork created?
What was missing/broken upstream?
What is the relationship with other forks?
What improvements have been made?
If we want to sync with upstream, how do we do this? maybe with some example command.

open_files.c:25:20: error: format not a string literal and no format arguments

The build on the launchpad PPA failed, probaby since their compiler flags are quite strict. I think this has to do with insecure formatting of a print.

gcc -DHAVE_CONFIG_H -I. -I.. . -DPSRFITS -I/include  -DFFTW_THREADS  -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include  -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/bl-sigproc-0+git20180302=. -fstack-protector-strong -Wformat -Werror=format-security -fopenmp -DHAVE_OPENMP -c -o open_files.o open_files.c
open_files.c: In function ‘open_files’:
open_files.c:25:20: error: format not a string literal and no format arguments [-Werror=format-security]
   sprintf(outfile, dir1);
                    ^~~~
cc1: some warnings being treated as errors
Makefile:1523: recipe for target 'open_files.o' failed
make[4]: *** [open_files.o] Error 1
make[4]: Leaving directory '/<<BUILDDIR>>/bl-sigproc-0+git20180302/src'
Makefile:1002: recipe for target 'all' failed
make[3]: *** [all] Error 2
make[3]: Leaving directory '/<<BUILDDIR>>/bl-sigproc-0+git20180302/src'
Makefile:444: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1

Missing a step in README.md for required distribution package prerequisites

It would be useful to mention that some distribution packages are needed as the first step. For example, on a *buntu distribution:

sudo apt install csh autoconf automake libtool libcfitsio-dev libgsl-dev

compilation fails, missing linking

libtool: link: gcc -march=native -O2 -pipe -fopenmp -DHAVE_OPENMP -o getpulse getpulse.o  -L/usr/lib -lcpgplot -lpgplot -L/usr/lib/gcc/x86_64-linux-gnu/7 -L/usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu -L/usr/lib/gcc/x86_64-linux-gnu/7/../../../../lib -L/lib/x86_64-linux-gnu -L/lib/../lib -L/usr/lib/x86_64-linux-gnu -L/usr/lib/../lib -L/usr/lib/gcc/x86_64-linux-gnu/7/../../.. -lgfortran -lquadmath libsigproc.a -lgsl -lgslcblas -lcfitsio -lm -lz -fopenmp
/bin/bash ../libtool  --tag=F77   --mode=link f77 -fno-second-underscore -g -O2  -L/usr/lib -o peak peak.o glun.o writeepn.o timer.o rwepn.o readdat.o getmjd.o readtim.o read_header.o epnpack.o strings_equal.o angle_split.o rdhead.o clock.o baseline.o aliases.o open_files.o open_file.o length.o getddis.o rdfbtab.o slfit.o sprof.o -lcpgplot -lpgplot  -L/usr/lib/gcc/x86_64-linux-gnu/7 -L/usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu -L/usr/lib/gcc/x86_64-linux-gnu/7/../../../../lib -L/lib/x86_64-linux-gnu -L/lib/../lib -L/usr/lib/x86_64-linux-gnu -L/usr/lib/../lib -L/usr/lib/gcc/x86_64-linux-gnu/7/../../.. -lgfortran -lm -lquadmath   -lz
libtool: link: f77 -fno-second-underscore -g -O2 -o peak peak.o glun.o writeepn.o timer.o rwepn.o readdat.o getmjd.o readtim.o read_header.o epnpack.o strings_equal.o angle_split.o rdhead.o clock.o baseline.o aliases.o open_files.o open_file.o length.o getddis.o rdfbtab.o slfit.o sprof.o  -L/usr/lib -lcpgplot -lpgplot -L/usr/lib/gcc/x86_64-linux-gnu/7 -L/usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu -L/usr/lib/gcc/x86_64-linux-gnu/7/../../../../lib -L/lib/x86_64-linux-gnu -L/lib/../lib -L/usr/lib/x86_64-linux-gnu -L/usr/lib/../lib -L/usr/lib/gcc/x86_64-linux-gnu/7/../../.. -lgfortran -lm -lquadmath -lz
peak.o: In function `plotpeak_':
/packaging/kern/upstream_repos/bl_sigproc/src/peak.f:331: undefined reference to `gruser_'
/packaging/kern/upstream_repos/bl_sigproc/src/peak.f:332: undefined reference to `grdate_'
collect2: error: ld returned 1 exit status

More security formatting issues

https://github.com/kernsuite-debian/bl-sigproc/blob/master/debian/patches/more_formatting

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

Jobs

Jooble