uclmoodle / moodle-report_myfeedback Goto Github PK

Add fractions in the grade and available grade only if there is a fraction in the number (eg. 87.5)

While attempting to test the functionality, the block failed badly due to multiple WHERE in the generated query:

LEFT JOIN mdl_grading_areas ga ON con.id = ga.contextid
WHERE cm.visible=1 WHERE c.visible = 1 AND c.showgrades = 1 AND cm.visible=1
ORDER BY duedate 

Stack trace:

line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
line 243 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
line 706 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
line 501 of /report/myfeedback/lib.php: call to pgsql_native_moodle_database->get_recordset_sql()
line 85 of /report/myfeedback/index.php: call to report_myfeedback->get_content()

The class report_myfeedback is defined in the index.php file. Custom class definitions should go to locallib.php file, or (in recent versions) ideally into the classes directory so they can be used by the Moodle autoloading mechanism.
Also, is there any reason why the class extends the block_base class? It does not really look natural in this context.

Steps to reproduce

1. In a course, prepare an Assignment, Quiz and Workshop
2. Let a student to submit into the Assignment and the Workshop, and attempt the Quiz
3. As a teacher, grade the Assignment and the Workshop. Evaluate and close the workshop.

Expected behaviour

• The report should display 3 entries, each activity on its own row

Actual behaviour

• There are six rows in the report, each activity is duplicated there.

Check for extensions granted to individual students (or groups) so the Moodle assignment and quiz due date is accurate for each student

The report seems to have MySQL specific custom queries. This leads to fatal errors on PostgreSQL (and probably other DBs that Moodle supports), such as:

ERROR: syntax error at or near ")"
LINE 4: CONVERT(gg.finalgrade,DECIMAL(3,0)) AS grade,
^
SELECT c.id AS courseid,
c.fullname AS coursename,
gi.itemname AS assessmentname,
CONVERT(gg.finalgrade,DECIMAL(3,0)) AS grade,

Do you think it's possible to convert them to queries that are cross-db
compatible? Operations like rounding can be do at the PHP level maybe?

The code seems to inject the jQuery code in a very non-standard way by echoing it after $OUTPUT->footer(); I am afraid this leads to the script code being generated only after the closing tag, am I right? Please see https://docs.moodle.org/dev/jQuery for the recommended way to include jQuery in Moodle plugins.

From @mudrd8mz on February 15, 2016 22:10

The current file index.php

include_once('../../../config.php');
$courseid = required_param('id', PARAM_INT);        // course id
if (!$course = $DB->get_record('course', array('id' => $courseid))) {
    print_error('nocourseid');
}
require_login($course);
$context = context_course::instance($course->id);
require_capability('gradereport/myfeedbacklink:view', $context);
header('location:' . $CFG->wwwroot . '/report/myfeedback/index.php?userid=' . $USER->id);

could read something like

require(__DIR__.'/../../../config.php');
$courseid = required_param('id', PARAM_INT);
$course = $DB->get_record('course', array('id' => $courseid), '*', MUST_EXIST);
require_login($course);
$context = context_course::instance($course->id);
require_capability('gradereport/myfeedbacklink:view', $context);
redirect(new moodle_url('report/myfeedback/index.php', array('id' => $USER->id)));

Copied from original issue: jgramp/moodle-gradereport_myfeedbacklink#1

On PostgreSQL, I am getting

Debug info: ERROR: UNION types text and bigint cannot be matched
LINE 88: su.id AS subid,

Stack trace:

line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
line 243 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
line 706 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
line 505 of /report/myfeedback/lib.php: call to pgsql_native_moodle_database->get_recordset_sql()
line 85 of /report/myfeedback/index.php: call to report_myfeedback->get_content()

We just upgraded from 2.15 to 2.16 on Moodle 3.9.20 and it looks like the new amd js files completely break the site - no navigation elements are able to be clicked on and the browser console is full of JS errors.

Show the full text feedback to students directly in the report, so they can expand all the items and see all the feedback on one page.

MySQL is very benevolent when it comes to data types. In it, SQL like

'' AS assigngradeid

works, but on PostgreSQL this throws

Debug info: ERROR: invalid input syntax for integer: ""
LINE 61: '' AS assigngradeid,

I would suggest to use

NULL AS assigngradeid

in this situation.

Even when an Assignment submission is still set to "in marking" any feedback shows up in the "Feedback comments" of the students' myfeedback report.
Feedback should be shown only after a final grade has been applied.

Hello, please I would like guidance.

I work with Moodle version 3.11.4+ (Build: 20220111) and myfeedback version 2.16 (Build: 2022122100).

I have my own letter grading system but in the reports I load a different one, the one that comes by default in Moodle.
For example, we configure our qualification system to assign other types of letters such as: AD, A, B and C but the letters F,D,D+,C-,C+,B-B,B+,A- and A appear in the reports , this is the default Moodle system.

What should I configure to upgrade to my existing rating system?

Report Image: https://ibb.co/HhMV1nh

Thank you so much!

Reverted this to avoid breaking current behaviour - e135185

However, we don't use the Academic Year dropdown, doesn't even seem to work in Snapshots

All relies upon direct database connectivity but this means prod talking to snapshots.
Poor architectural design so Snapshot links should go to defined site URLs.

What of UCL Prod which now has multiple years of content?
Since we're not doing Snapshots anymore

Display an icon so students can see where rubrics and grading forms are being used.

See screenshot:

We have several sites where both students, teachers, and admins get the follwoing error:
Return value of report_myfeedback\local\report::get_group_assign_submission_date() must be of the type string, null returned

The settings page should make it clear that leaving the DB configuration empty will cause using the default Moodle database.

Students can view the submission by clicking the assignment name. Having a submission link is confusing. If there is feedback one 'view feedback' link should display in the feedback column.

In the full text feedback show selected rubric text and grading forms

The report currently takes a while to load. Even with only 2 feedback items it is noticeably slow.

studentrecordsystemlink language string should be a site level plugin setting

The empty href in this language string should use that setting
https://github.com/uclmoodle/moodle-report_myfeedback/blob/main/lang/en/report_myfeedback.php#L135

studentrecordsystem lang string could also be exposed as a site setting to define the institution's SRS name

The properties "profile_field_year" and "profile_field_programmename" to isn't defined and throws notices. Closing div element missing in the overview.php file caausing layout error.

Screenshot of the issues:
http://screencast.com/t/PS5Qrq9lZmZE

Pull request to solve the issues:
#31

Please update the plugin on moodle.org when issues are fixed :-)

Best regards
Johnny Drud

The queries used MySQL specific unix_timestamp(current_timestamp)) functions. This makes the code non-cross-db compatible. The Moodle way is to use something like $now = time(); and then pass the value of the $now via placeholder into the SQL query - so instead of (e.g.)

AND (gi.hidden = 0 or gi.hidden < unix_timestamp(current_timestamp))

you would have something like

AND (gi.hidden = 0 or gi.hidden < :now)

At the moment there's no way to know if the remote database connection has worked. Although students don't need to see which database is being used, it would be useful to have a connection test on the settings page to feedback to Moodle Admins whether the connection worked and which database is therefore being used for the reports.

If you achieve to make the code cross-db compatible (as reported in #1), it would make sense to make the remote DB engine configurable, too. You may want to use the same DB engine selector that the Moodle installer has.

Check essay type quiz question and other quiz types whether there are other feedback that is useful. If they do we may need to add an icon to say additional feedback is available.

GHA is failing due to coding standard violations. Needs resolving