ukaea / parallel-preprocessor Goto Github PK

I am looking forwards someone with mac os can fix the error caused by std::make_shared<T>

while I have created a new wiki page "BuildOnMacOS.md" to describe the procedure to install dependencies.

Error: Resource not accessible by integration: for PR sent to main.

What is the best way? tmp solution, is upload only if branch name is "main" and "dev" (stage tree)

Also currently CI does not work for fork user?
https://github.com/johnnonweiler/parallel-preprocessor

Currently merge is done in writer, it is more efficient, easy to impl, but not flexible. if there is more processor following imprinter, must working on merged geometry like Tessellation, it may be useful.

Low priority, this can be done togother with "parallel merge" design

In some circumstances, the cmake build will do a git submodule add https://github.com/pybind/pybind11 in the src/python folder. (See src/python/CMakeLists.txt)

I would expect the cmake build to normally only change files in the build folder (and not to stage changes in git).

if the thread count is 1, then serialExecutor is used instead, useful in benchmarking and validation.

use thread pool, thread count == 1, it is not equal to use serialExecutor, there is tiny cost. NOTE imprinting is a coupled operation, not supported/code for serial single thread SerialExecutor.

When running /usr/bin/python /usr/bin/geomPipeline.py manifest.json -o ppp.brep

I think I am using the geomPipeline correctly according to the --help instructurings I get a RuntimeError

Currently, it is assumed, input CAD File unit must be "mm" which is standard for CAD.
scaling from other length unit may be worth of supporting.

This can simply dependency
https://github.com/ukaea/parallel-preprocessor/blob/main/CMakeLists.txt#L60

Not sure how useful this would be for others but I would be keen to see a conda install for this nice package

Lowering the bar for entry and quicker for users to get up and running

Conda forge is really quite a nice option these days and has lots of help for package making

I realize this is a big ask and would be a significant undertaking but it would also be great :-)

https://ukaea.github.io/parallel-preprocessor/site/doxygen-docs.html

When trying to use the geomPipeline.py in ubuntu 18.04 Conda env I get an error and was wondering

I have tried installing additional software sudo apt-get install libstdc++6 but this has not helped

Here are the commands I used to install and run the PPP

sudo add-apt-repository -y ppa:freecad-maintainers/freecad-stable
sudo apt update
sudo install -y freecad
sudo apt-get install -y libtbb2 libocct-foundation-7.3  libocct-data-exchange-7.3  libocct-modeling-data-7.3 libocct-modeling-algorithms-7.3  libocct-ocaf-7.3
wget https://github.com/ukaea/parallel-preprocessor/releases/download/dev/parallel-preprocessor-0.3-dev_ubuntu-20.04.deb
sudo dpkg -i parallel-preprocessor-0.3-dev_ubuntu-20.04.deb 
geomPipeline.py config.json
/home/jshim/anaconda3/bin/python /usr/bin/geomPipeline.py config.json

This might be me making the error again but wanted to mention that I'm getting this error, Looks like PPP can't find the pppStartPipeline file and it appears to not have installed with the others

https://ukaea.github.io/parallel-preprocessor/site/cppcheck.html

clang-tidy empty
flawfinder no output page, why?

coverage, PPP and PPP/CoreTests should merged into one folder to report.

this is from C++ core guideline.

ukaea/openmc_workshop task10

for small value like centerOfMess.X = 0.014 (before write brep) vs 0.012 (after write out brep in occ_faceter) has diff value,

No material found for ID: 4710765210376886256
with volume: 1.26734e+08, CentreOfMass: 0.0145901, -9.97406e-15, 268.845

"material": "copper",
"name": "divertor.stp",
"property": {
    "area": 2300829.253375523,
    "centerOfMass": [
        0.012942664269858002,
        -1.6442619387761406e-14,
        268.84456044917755
    ],
    "volume": 126733088.77402382
},
"uniqueId": 4710765210367973360

No material found for ID: 13934137247231662064
with volume: 1.26734e+08, CentreOfMass: 0.0145901, -1.254e-14, -268.845

"material": "copper",
"name": "divertor.stp",
"property": {
    "area": 2300829.253375234,
    "centerOfMass": [
        0.012942664144260964,
        -1.43356289324801e-14,
        -268.84456044879204
    ],
    "volume": 126733088.77435534
},
"uniqueId": 13934137247222749168

The manifest.json looks for the tag filename but I was wondering if this could be changed to stp_filename

No worries if it is better to keep it as filename, just thought I would ask

https://techoverflow.net/2019/06/16/how-to-get-length-of-curve-in-opencascade/