uklance / tiny-ioc Goto Github PK

try / catch exception

<T> T ServiceRegistry.autobuild(Class<T> type)

@Service
public Foo createFoo(@Autobuild Bar bar) {
   return new Foo(bar);
}

Currently context is not generic

This might require a ServiceDecorator interface similar to ServiceBuilder

Ordering by before / after

If you don't define one it is considered proprietary.

http://tapestry.apache.org/5.3/apidocs/org/apache/tapestry5/ioc/internal/ServiceBinderImpl.html#eagerLoad%28%29

public class Service {
   @Inject private Foo foo; // not injected 
} 

@see InjectionServiceBuilder.java#L29

<T> Map<String, T> getServices(Class<T> serviceType)

SystemPropertyProvider
StringPropertyProvider
DelegatePropertyProvider

1. getContributionKeyType and getContributionValueType should throw exception if contributionType is not valid

setOrderedConfiguration(...)
setUnorderedConfiguration(...)
setMappedConfiguration(...)

Should be

setOrderedContributions(...)
setUnorderedContributions(...)
setMappedContributions(...)

DefaultModule
Autobuilder
DefaultServiceNameProvider

• orderedContributions takes a copy in the constructor (for sorting). Do this in the getter instead
• getContributionCollection - rename to buildUnorderedContributions
• getContributionList - rename to buildOrderedContributions
• getContributionMap - rename to buildMappedContributions
• Add a default case to the dependencies.contributionType switch to throw exception

eg:

options.withOrder("before:*")
options.withOrder("before:foo", "after:bar")
options.withOrder("after:*")

Swap the order of the method parameters... currently:

public interface ServiceDecorator<T> {
	T decorate(T delegate, ServiceBuilderContext context);
}

annotations & interfaces

Either environment variable or -P

install:
  - ./gradlew assemble -Pci=true

script:
  - ./gradlew check -Pci=true

http://stackoverflow.com/questions/17942819/how-can-i-get-clean-gradle-output-on-travis-ci

Binding Services
Default Service ID
Overriding Services
Decorating Services
Service Contributions

https://github.com/nebula-plugins/nebula-publishing-plugin#nebulajavadoc-jar
https://github.com/nebula-plugins/nebula-publishing-plugin#nebulasource-jar

eg if ServiceBuilderContextImpl.getMappedContributions() is called before ServiceBuilderContextImpl.setMappedContributions(Map contributions)

https://github.com/uklance/tiny-ioc/search?utf8=%E2%9C%93&q=withid%28&type=Code

See lock-free-and-wait-free-thread-safe-lazy-initialization

Busy spin

private AtomicBoolean canWrite = new AtomicBoolean(false);  
private volatile Foo foo; 
public Foo getInstance() {
   while (foo == null) {
       if(canWrite.compareAndSet(false, true)){
           foo = new Foo();
       }
   }
   return foo;
}

Synchronized creation

private final AtomicReference<Foo> instance = new AtomicReference<>(null);
public Foo getInstance() {
  Foo foo = instance.get();
  if (foo == null) {
    synchronized(instance) {
      // You need to double check here
      // in case another thread initialized foo
      Foo foo = instance.get();
      if (foo == null) {
        foo = new Foo(); // actual initialization
      }
    }
  }
  return foo;
}

Remember field.setAccessible(true) for private

ServiceBinder only currently supports decorate by service type
Needs to work for annotations too