GithubHelp home page GithubHelp logo

Comments (2)

Ghostkeeper avatar Ghostkeeper commented on July 16, 2024

I'm not sure why the Socket::Private symbols were still in the build. Indeed I've seen crashes in the past in Socket::Private from CuraEngine so it must've been exposed somewhere. I've tried your suggestion of explicitly hiding it and everything still works fine.

We've not really put a lot of effort into giving this a proper stable ABI. I think the PIMPL pattern was implemented mostly as an experiment. This library doesn't change very often after all. Since this change works for you and doesn't hurt for the rest, I'll merge it.

from libarcus.

onitake avatar onitake commented on July 16, 2024

Thanks for the quick response!
I know that your main focus has always been on the Python library, and libArcus was more of a glue component for CuraEngine.
But it's always better to be a bit mindful about such things.

With these fixes, the exported symbols from the library are vastly reduced: https://salsa.debian.org/3dprinting-team/libarcus/blob/master/debian/libarcus3.symbols
There's still a minor discrepancy between gcc8 and gcc9, but it's much less than it was before.

from libarcus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.