Comments (7)
@Ghostkeeper You don't have to drop support for older Protobuf, you just have to take advantage of the GOOGLE_PROTOBUF_VERSION
macro. See, e.g., https://github.com/Xilinx/XRT/blob/master/src/runtime_src/core/include/xcl_api_macros.h#L34
There are two issues with the move to Protobuf 3.18.0 or newer: dropping the second argument in SetTotalBytesLimit
(which has gone unused for several versions) and dropping ByteSize
for ByteSizeLong
on messages. The latter returns a size_t
instead of an int
. I'm patching libArcus
for Void Linux, you can adapt something similar inside some compile-time version checks: https://github.com/ahesford/void-packages/blob/protobuf/srcpkgs/libArcus/patches/protobuf.patch
from libarcus.
Did you check the build instructions that we provide as a part of Cura? They also include how to build libArcus from source. I've recently tried those from a clean install and those worked. You can find them here: https://github.com/Ultimaker/Cura/wiki/Running-Cura-from-Source-on-Ubuntu#arcus
from libarcus.
In the last releases of protobuf in the master branch some deprecated functions were removed.
So, installing protobuf from 3.15.x branch works for me!
from libarcus.
We are using Protobuf 3.15 ourselves in the Cura builds, indeed:
It seems the overload we're using was removed a few weeks ago: protocolbuffers/protobuf#8794
It would be quite easy to remove the second parameter from that function call. However libArcus as a library currently supports Protobuf down to 3.0.0. We'd have to increase that minimum requirement if we want to fix this for the newest protobuf versions. Because back then, the suggested alternative didn't exist yet.
from libarcus.
@Ghostkeeper We're using Protobuf 3.9.2 in the MinGW cross-building for Windows
from libarcus.
Okay, interesting! Perhaps we should align that with the rest.
In 3.9.2 the new overload already existed so it shouldn't be a problem, luckily.
from libarcus.
Developers, see issue CURA-8467.
from libarcus.
Related Issues (20)
- Hide private symbols not hidden by default visibility HOT 2
- MessageTypeStore class should (probably) be exported HOT 2
- how to set cmake to Identify anaconda Virtual environment HOT 1
- python3-dev HOT 4
- make error: *** target pattern contains no '%'. Stop. HOT 9
- PYTHON_SITE_PACKAGES_DIR is not honored HOT 10
- Update to SIP5
- HELP: Sip errors on MacOS HOT 4
- sudo command in "Building" section incorrect
- Action Required: Fix WhiteSource Configuration File - .whitesource
- Build fails with protobuf 3.18 HOT 2
- How do I get SIP on Windows? HOT 1
- Failed to get Python3_SITELIB. Error: when cmake Arcus. HOT 1
- Linking CXX shared library pyArcus.so No such file or directory HOT 2
- Missing sipbuild HOT 7
- error: packages failed to build: arcus-5.0.0-2 HOT 4
- Failing compilation
- unable to built a libArcus
- LICENSE and README.md files disagree on what the license is
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libarcus.