GithubHelp home page GithubHelp logo

Comments (7)

ahesford avatar ahesford commented on August 12, 2024 2

@Ghostkeeper You don't have to drop support for older Protobuf, you just have to take advantage of the GOOGLE_PROTOBUF_VERSION macro. See, e.g., https://github.com/Xilinx/XRT/blob/master/src/runtime_src/core/include/xcl_api_macros.h#L34

There are two issues with the move to Protobuf 3.18.0 or newer: dropping the second argument in SetTotalBytesLimit (which has gone unused for several versions) and dropping ByteSize for ByteSizeLong on messages. The latter returns a size_t instead of an int. I'm patching libArcus for Void Linux, you can adapt something similar inside some compile-time version checks: https://github.com/ahesford/void-packages/blob/protobuf/srcpkgs/libArcus/patches/protobuf.patch

from libarcus.

nallath avatar nallath commented on August 12, 2024

Did you check the build instructions that we provide as a part of Cura? They also include how to build libArcus from source. I've recently tried those from a clean install and those worked. You can find them here: https://github.com/Ultimaker/Cura/wiki/Running-Cura-from-Source-on-Ubuntu#arcus

from libarcus.

mrnexeon avatar mrnexeon commented on August 12, 2024

In the last releases of protobuf in the master branch some deprecated functions were removed.

So, installing protobuf from 3.15.x branch works for me!

from libarcus.

Ghostkeeper avatar Ghostkeeper commented on August 12, 2024

We are using Protobuf 3.15 ourselves in the Cura builds, indeed:

https://github.com/Ultimaker/cura-build-environment/blob/d76665026132a832316c95a5566abd6896489474/projects/protobuf.cmake#L1

It seems the overload we're using was removed a few weeks ago: protocolbuffers/protobuf#8794

It would be quite easy to remove the second parameter from that function call. However libArcus as a library currently supports Protobuf down to 3.0.0. We'd have to increase that minimum requirement if we want to fix this for the newest protobuf versions. Because back then, the suggested alternative didn't exist yet.

from libarcus.

jellespijker avatar jellespijker commented on August 12, 2024

@Ghostkeeper We're using Protobuf 3.9.2 in the MinGW cross-building for Windows

from libarcus.

Ghostkeeper avatar Ghostkeeper commented on August 12, 2024

Okay, interesting! Perhaps we should align that with the rest.

In 3.9.2 the new overload already existed so it shouldn't be a problem, luckily.

from libarcus.

Ghostkeeper avatar Ghostkeeper commented on August 12, 2024

Developers, see issue CURA-8467.

from libarcus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.