Display::GetStdSize(const Value& q) const doesn't return size of image about ultimatepp

[mirek-fidler]

I guess that is a bit of misunderstanding here.. Documentation describes interface. You are checking StdDisplay, which is not really designed to render Images. If you use Paint, it will paint text as well.

Example of Display that renders Image is CenteredImageDisplay.

That said there is probably no reason for StdDisplay not to display Images, so I will probably add that feature anyway.

[schutm]

Problem was I couldn't change the usage of StdDisplay as it was being used (indirectly) by SyncInfo of MultiButton. And I used the SetDisplay of the MultiButton with a display to show images. However hovering over the image triggered the display of a SyncInfo, because the text ('image 32x32') was larger than the MultiButton control itself. I got around it by using AttrText and Convert, but that seemed a bit contrived.

Thanks for the fix. I'll test it in following few days.

[mirek-fidler]

Thats sort of weird, what display have you used with SetDisplay?

…

On Tue, Oct 17, 2023 at 10:20 PM Martin Schut ***@***.***> wrote: Problem was I couldn't change the usage of StdDisplay as it was being used (indirectly) by SyncInfo of MultiButton. And I used the SetDisplay of the MultiButton with a display to show images. However hovering over the image triggered the display of a SyncInfo, because the text ('image 32x32') was larger than the MultiButton control itself. I got around it by using AttrText and Convert, but that seemed a bit contrived. Thanks for the fix. — Reply to this email directly, view it on GitHub <#165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARH234KIAPPLWCT3KJQDMTX73SBDAVCNFSM6AAAAAA6DVDW6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXGEYDSMZWGM> . You are receiving this because you commented.Message ID: ***@***.***>

[schutm]

This works now.

I used a custom Display.

Looking at line 614 in MultiButton.cpp a call is made to DisplayPopup::Set (line 137 in DisplayPopup.cpp). At line 145 a call is made to DisplayPopup::Pop::Set (line 110 in DisplayPopup.cpp) and here at line 131 a call is made to DisplayPopup::Pop::Sync. Finally in this method at line 60 a call is made to Display::GetStdSize (line 115 in Display.cpp). This last line always uses the StdDisplayClass (as the name suggests). I didn't expect this to happen when displaying a PopUp from the MultiButton.

For short, using de MultiButton with a custom Display will still use the StdDisplayClass for the popup (not a problem for me anymore, as my custom Display just shows an Image which now recognized by StdDisplayClass)