Painter/Xform2D: Return statement is never reached. about ultimatepp

[mirek-fidler]

True. That said, GetClass does not seem to be used anywhere anyway, I vote for completely removing it...

…

On Sat, Nov 25, 2023 at 4:30 PM İsmail Yılmaz ***@***.***> wrote: https://github.com/ultimatepp/ultimatepp/blob/fb22b9b361df668b3290e815a0b91d5a2691d7f0/uppsrc/Painter/Xform2D.cpp#L34 The above return statement in Xform2D::GetClass method is never reached. — Reply to this email directly, view it on GitHub <#172>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARH236BH76MSZPH6XMFHQDYGIFJXAVCNFSM6AAAAAA72FKZM2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTANRZHEZTKMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ismail-yilmaz]

True. That said, GetClass does not seem to be used anywhere anyway, I vote for completely removing it...
…
On Sat, Nov 25, 2023 at 4:30 PM İsmail Yılmaz @.> wrote:

ultimatepp/uppsrc/Painter/Xform2D.cpp

Line 34 in fb22b9b

return Epsqual(x.x, y.x) ? XFORM_REGULAR_SCALE : XFORM_SCALE;

The above return statement in Xform2D::GetClass method is never reached. — Reply to this email directly, view it on GitHub <#172>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARH236BH76MSZPH6XMFHQDYGIFJXAVCNFSM6AAAAAA72FKZM2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTANRZHEZTKMQ . You are receiving this because you are subscribed to this thread.Message ID: @.>

I'm also fine with removing it. While I use Xform2D matrix a lot, I never needed the GetClass method either.