um-mitternacht / bewitchment Goto Github PK

• Move all possible food items to DietaryUtils

• Make the owl grab from that class as opposed to it's own when looking for mobs to target

• Rewrite DietaryUtils to be more CPU efficient, and yet still be able to pick up on things we don't know about

• Add methods for the diets of other animals when they are added to the game, and place them in DietaryUtils. Some other mobs could benefit from this as well (NPC werewolves, NPC vampires)

The model for the belt piece is misaligned

Now that venom is a proper brew ingredient, it should be on a cooldown.

• "Location Stones"
• Lanterns
• Oil (Created from either veggies or sunflowers)
• Liquid honey (Created by placing honey items in a cauldron)
• Add a way to obtain chiselled versions of blocks when chisel is not installed
• Add more stuff here as needed

Mirror was originally supposed to be hung on a wall of sorts, but since the block was changed to be placeable anywhere, we actually need the texture from its back face

• Presumably, all the gem powders
• Basically all baubles
• Gemstone blocks are crafting back into inappropriate gemstones
• As a result of the meta shift, inappropriate aspects are also applied to the gemstones

Moldavite had a metadata value of 1, so anything past garnet broke

Title. See comments on 92ecf6d

We have both witchweed and infested wheat items linked with the infested wheat crop block. They are the same thing, we need to remove one

They should not be restricted to just specific biomes, rather, they should also be able to be found in dungeons, strongholds, and mineshafts

Right now the girdle works by limiting the charges to min(5, armorPieces), but that rewards players who wear more armor.
The item should be limited by max(0, 10-armorPieces), that is, the icons should appear on the right of the armor meter, and should only occupy "empty" armor meter slots. This way players will be rewarded by wearing less armor.
The networking/capability should also be reworked, moving away from the SimpleCapability implementation as it will be removed in the future

Title

Title

This is a temporary way to find them until we can add proper biome and world gen

Make it 256x256 (16 icons per side instead of 4).
Move the ability icon rendering logic somewhere more abstract (pretty sure I had a texture render helper class at some point), so that the HUD and the bar render stuff with the same method

> Task :compileJava 
warning: No processor claimed any of these annotations: mezz.jei.api.JEIPlugin,mcp.MethodsReturnNonnullByDefault,net.minecraftforge.common.config.Config,net.minecraftforge.fml.common.Mod.EventBusSubscriber,net.minecraftforge.fml.common.Optional.Method,net.minecraftforge.fml.common.Optional.Interface,net.minecraftforge.common.capabilities.CapabilityInject,net.minecraftforge.fml.common.Mod.Instance,net.minecraftforge.fml.common.registry.GameRegistry.ObjectHolder,javax.annotation.ParametersAreNonnullByDefault,net.minecraftforge.common.config.Config.Comment,net.minecraftforge.fml.common.Mod.EventHandler,net.minecraftforge.fml.common.API,net.minecraftforge.fml.common.eventhandler.SubscribeEvent,net.minecraftforge.common.config.Config.RequiresMcRestart,net.minecraftforge.fml.common.SidedProxy,net.minecraftforge.fml.common.Mod,net.minecraftforge.fml.relauncher.SideOnly,net.minecraftforge.common.config.Config.LangKey,javax.annotation.Nonnull,javax.annotation.Nullable
/home/ancient/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/21.0/3a3d111be1be1b745edfa7d91678a12d7ed38709/guava-21.0.jar(com/google/common/collect/Multimap.class): warning: Cannot find annotation method 'value()' in type 'CompatibleWith': class file for com.google.errorprone.annotations.CompatibleWith not found
/home/ancient/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/21.0/3a3d111be1be1b745edfa7d91678a12d7ed38709/guava-21.0.jar(com/google/common/collect/Multimap.class): warning: Cannot find annotation method 'value()' in type 'CompatibleWith'
/home/ancient/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/21.0/3a3d111be1be1b745edfa7d91678a12d7ed38709/guava-21.0.jar(com/google/common/collect/Multimap.class): warning: Cannot find annotation method 'value()' in type 'CompatibleWith'
/home/ancient/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/21.0/3a3d111be1be1b745edfa7d91678a12d7ed38709/guava-21.0.jar(com/google/common/collect/Multimap.class): warning: Cannot find annotation method 'value()' in type 'CompatibleWith'
/home/ancient/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/21.0/3a3d111be1be1b745edfa7d91678a12d7ed38709/guava-21.0.jar(com/google/common/collect/Multimap.class): warning: Cannot find annotation method 'value()' in type 'CompatibleWith'
/home/ancient/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/21.0/3a3d111be1be1b745edfa7d91678a12d7ed38709/guava-21.0.jar(com/google/common/collect/Multimap.class): warning: Cannot find annotation method 'value()' in type 'CompatibleWith'
/home/ancient/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/21.0/3a3d111be1be1b745edfa7d91678a12d7ed38709/guava-21.0.jar(com/google/common/collect/Multimap.class): warning: Cannot find annotation method 'value()' in type 'CompatibleWith'
/home/ancient/Load/Bewitchment/build/sources/main/java/com/bewitchment/client/core/event/MimicEventHandler.java:43: error: cannot access AddPlayerData
                        NetworkPlayerInfo victimInfo = new NetworkPlayerInfo(new GameProfile(event.getVictimID(), event.getVictimName()));
                                                       ^
  bad class file: /home/ancient/.gradle/caches/minecraft/net/minecraftforge/forge/1.12.2-14.23.4.2760/snapshot/20171003/forgeBin-1.12.2-14.23.4.2760.jar(net/minecraft/network/play/server/SPacketPlayerListItem$AddPlayerData.class)
    bad RuntimeInvisibleParameterAnnotations attribute: AddPlayerData(GameProfile,int,GameType,ITextComponent)
    Please remove or make sure it appears in the correct subdirectory of the classpath.
1 error
8 warnings

This is a build in a fresh workspace.
By the way, /gradlew does not have an executable flag.

• BlockCandle
• BlockMoonbell
• BlockGem
• BlockGemBowl

The label and the bar share the X coordinate. Label should be centered, instead it hangs to the right

The tarots building rituals reports the wrong number of required dyes, introduced with aca23cc

Title

Do it in such a way they aren't in your face, either

Commands affecting the game status should be executed server side, but they act weird instead, and I can't really understand where they are executed.

Example: the /bw-st v 10 command should change the player on the server, then send a PlayerTransformationChangedMessage to the client player to actually make it a lvl10 vampire. This never happens, because the message only gets sent if world.isRemote() returns false, but inside a command this returns true, and the player is left out of sync (Vampire on the client, with no visible bar buttons, not a vampire on the server. Relogging without closing the client window shows bar button on login because of data that should be reset on logout. It's kinda confusing).

Fix the onEquipped method in ItemMantle after Ingoleth is done dealing with it

• FINISH TILE ENTITY REWRITE BEFORE ANYTHING ELSE
• Rewrite Athame and Boline code
• More advanced fume recipes
• Decide the barrels fate
• More rituals
• Distillery
• Brazier
• Add more stuff and things here, other devs

Witch Altar is showing incorrect power data.
Minecraft 1.12.2
Bewitchment 1.12.2-0.0.6

Altar shows:

Real power (got using /blockdata):

Mantle is derpy and needs fixing

Might want to introduce some interval between their hooting.

this is minecraft mod??? where to download???

The following need to be fixed:

• Some brews that change blocks do not respect rotations of things like stairs
• Stairs, slabs, and fences need a rewrite. They are kind of fucky.
• Beehive gen, if those are kept. They use the ore spawning system, but in trees, currently.
• Possible performance issue with the oven. More clarification on the performance issue is probably needed.
• Fix between this mod and rustic, to allow brews from this mod to be created once more due to rustic toying with glass bottles.
• Brews have a hard time landing on a target if the target is a mob, or presumably, a player

The following need implementation:

• Port over Covens rituals
• Port over other things
• Set up cypress generation
• JEI plugin for brewing
• Other things
• Love potion. Use silphium as the ingredient, use a different ingredient for flower growth.

The following are being worked on:

• Stews in the kettle
• Fences and walls for some of the blocks added
• Positive fortunes. Just need ideas.
• Tarot cards
• Brooms
• Recreations of the old crops from Covens
• Witchweed + infested soil mechanics (WIP)

Fixmes and Todos from the code, plus miscellaneous things:

• Fix Girdle of the Wooded rendering, it is apparently acting up.
• New way of determining color that does not involve wool, so I don't have to throw a crash at players who remove those oredicts that code for color.
• Allow blocks to be placed in cauldron-based stews, as well as metadata for both blocks and items.
• TileOven causes a chunk redraw at every tick. This needs a fix
• Move brews over to potions at some point
• Change the way gems are stored on an altar. Implement a gem bowl. Allow it to take oredict definitions, metadata, and more, for maximum mod support.
• Rewrite the fisheye incantation
• Grimoire functionality, when the time comes. The class is empty. Same deal with the book of shadows.
• Not now son, I'm making... TOAST!
• Taglocks need to change color when a taglock is taken
• Animania compat for mycological corruption and grass grow brews, as it replaces vanilla livestock with it's own.
• Expand the dungeon loot tables, so I can place silphium seeds in dungeons.
• Add gemstones from this mod to the loot tables for fortunes.
• Allow holy water brews to damage vampiric players
• Rewrite ME/Fix Energy
• Come up with a new name for ME
• Come up with a new recipe for kelp spores.
• Javadocs
• New textures for the gemstone blocks
• Make fumes more chance based.
• New textures for cold iron
• Crafting mechanism for cold iron that does not involve a furnace, or any form of heat.
• Brew that turns infested soil back into farmland, to combat the actions of malicious players with some seeds.

Fix rendering on some things, including stairs, slabs, and some of the plants, such as the moonbells

Brazier model seems disconnected. I suggest using Blockbench to create files, as it precompiles some stuff for devs and is 100% online.
Texture is not a square and won't be accepted by the minecraft block rendering engine

When spawning a snake into the world, they suffocate in blocks like grass, causing them to die quickly.

Expected Behavior

Lantern should raise the hand that holds it; The opposing hand is raised instead...

Cause is unclear, as sometimes it works, and other times it doesn't. Might be because of other mods interference, since I'm on a modded instance. Will test on dev environment latter

https://cdn.discordapp.com/attachments/390215771965489183/506558181850480640/unknown.png

The potion file for it contains several ideas for potions that would all relate to it in some way

Refer to our discord server for general instructions on style and such.
Icons are added as they are needed

All these textures are needed urgently:

• Blood reservoire (see here)
• Subjugate ability icon
• Hypnotize ability icon
• Call casket ability icon

All these textures will be probably needed sometimes in the future:

• Paper message

We need to decide what cypress brooms do

It currently just doesn't work. Ideally a new version doesn't damage the entity, but marks the player as an attacker anyway. It should probably also constantly alert all the other entities of the same time nearby.
Ideally a weakness + slowness effect gets constantly applied for the whole duration, which should be extended for NPCs.
Players should be treated separatedly, with an constantly reapplying effect, until their blood gets back to normal levels. Low blood on players should also cause mild hunger, and blood should only regenerate when the food level and saturation are over a threshold.

A necessary evil for the MobUtils class, due to it overhauling vanilla mobs, and it adding a fuck ton of classes (even for separate sexes and babies). This is merely a reminder to myself, and it is only at medium due to tedium of getting every class.

Pretty much like when scrolling though items in the hotbar, selecting an ability should make its name pop up briefly on the screen, above the item bar

Expected Behavior

Oak saplings in Oven gives wood ash and Exhale of the Horned One.

Actual Behavior

I got Wood Ash and Exhale of the horned one, one time. Then it promptly disappeared from my inventory.

Steps to Reproduce

I just loaded the oven with glass jars coal and oak saplings.

Version of Minecraft, Bewitchment, Forge, Craftstudio API, and Baubles.

Minecraft 1.12.2, Bewitchment 0.7.1, Forge 14.23.1.2555, Craftstudio API none, Baubles 1.5.2

Screenshots encouraged

Logs, in the event of a crash

If this is a question, dev-commentary, or a suggestion, ignore this template

• Regal Silk
• Graveyard Dust
• Golden Thread
• Hellish Bauble
• Witches Stitching
• Diabolic Vein
• Pure Filament
• Sacrosanct Earth
• Graveyard Dirt
• Gem Blocks (they should be redone)
• Rest of the tarot cards
• Grilled Watermelon (New texture is needed IMO)
• "Location Stone"
• Kelp. Kelp needs a revamp in it's entirety, texturally.
• New apiary GUI

Also remove anything extending Ingredient made in the mod, it's probably buggy

Some of the data can be stripped from the tile entity nbt when getting the update packet, when it is not needed client side, to reduce network load

Blood thirst meter for vampires still has rounding errors. We might need to use a different style, droplets are not going to work well for that. Maybe a continuous bar like the experience one might be better

Lower the volume of bubbling in the witches cauldron after the first time.