umbraco / the-starter-kit Goto Github PK

This is the html at the bottom of this view:

<section class="section section--sand">
    <div class="container">
        <!-- todo: Check if grid is empty via a property value converter ->
                                @Html.GetGridHtml(Model.Content, "bodyText", "bootstrap3-fluid")


                        </div>

                    </section>

The closing comment block is missing an '-' which means everything after the todo is commented out resulting in invalid HTML.

(i'll fix)

It feels like it would be a good idea to give some kind of warning that installing this will remove all previous templates, because for people like myself that live dangerously and sometimes don't use version control it's a bit upsetting to have everything deleted!

master uses the correct @await Html.PartialAsync(... but there are a few other views that have the old (semi-deprecated?) method in place.

I would happily change them and make a pull request, but I am new at this and am not sure where the views directory is in this repo.

For example if you already have content and then install the starter kit, the home page link is not "/"

This property is not used at all which means the data type People - Featured People - Multinode Treepicker is not needed either.

exception

 2017-08-07 16:07:24,563 [P3788/D8/T24] ERROR Umbraco.Core.Persistence.UmbracoDatabase - Exception (b53bb094).
System.Data.SqlServerCe.SqlCeException (0x80004005): A duplicate value cannot be inserted into a unique index. [ Table name = umbracoNode,Constraint name = IX_umbracoNodeUniqueID ]
   at System.Data.SqlServerCe.SqlCeCommand.ProcessResults(Int32 hr)
   at System.Data.SqlServerCe.SqlCeCommand.ExecuteCommandText(IntPtr& pCursor, Boolean& isBaseTableCursor)
   at System.Data.SqlServerCe.SqlCeCommand.ExecuteCommand(CommandBehavior behavior, String method, ResultSetOptions options)
   at System.Data.SqlServerCe.SqlCeCommand.ExecuteNonQuery()
   at StackExchange.Profiling.Data.ProfiledDbCommand.ExecuteNonQuery()
   at Umbraco.Core.Persistence.PetaPocoCommandExtensions.<>c__DisplayClass1.<ExecuteNonQueryWithRetry>b__0()
   at Umbraco.Core.Persistence.FaultHandling.RetryPolicy.ExecuteAction[TResult](Func`1 func)
   at Umbraco.Core.Persistence.PetaPocoCommandExtensions.ExecuteNonQueryWithRetry(IDbCommand command, RetryPolicy cmdRetryPolicy, RetryPolicy conRetryPolicy)
   at Umbraco.Core.Persistence.PetaPocoCommandExtensions.ExecuteNonQueryWithRetry(IDbCommand command, RetryPolicy retryPolicy)
   at Umbraco.Core.Persistence.PetaPocoCommandExtensions.ExecuteNonQueryWithRetry(IDbCommand command)
   at Umbraco.Core.Persistence.Database.Insert(String tableName, String primaryKeyName, Boolean autoIncrement, Object poco)
 2017-08-07 16:07:24,578 [P3788/D8/T24] ERROR Umbraco.SampleSite.InstallPackageAction - Error during post processing of Starter Kit
System.Data.SqlServerCe.SqlCeException (0x80004005): A duplicate value cannot be inserted into a unique index. [ Table name = umbracoNode,Constraint name = IX_umbracoNodeUniqueID ]
   at System.Data.SqlServerCe.SqlCeCommand.ProcessResults(Int32 hr)
   at System.Data.SqlServerCe.SqlCeCommand.ExecuteCommandText(IntPtr& pCursor, Boolean& isBaseTableCursor)
   at System.Data.SqlServerCe.SqlCeCommand.ExecuteCommand(CommandBehavior behavior, String method, ResultSetOptions options)
   at System.Data.SqlServerCe.SqlCeCommand.ExecuteNonQuery()
   at StackExchange.Profiling.Data.ProfiledDbCommand.ExecuteNonQuery()
   at Umbraco.Core.Persistence.PetaPocoCommandExtensions.<>c__DisplayClass1.<ExecuteNonQueryWithRetry>b__0()
   at Umbraco.Core.Persistence.FaultHandling.RetryPolicy.ExecuteAction[TResult](Func`1 func)
   at Umbraco.Core.Persistence.PetaPocoCommandExtensions.ExecuteNonQueryWithRetry(IDbCommand command, RetryPolicy cmdRetryPolicy, RetryPolicy conRetryPolicy)
   at Umbraco.Core.Persistence.PetaPocoCommandExtensions.ExecuteNonQueryWithRetry(IDbCommand command, RetryPolicy retryPolicy)
   at Umbraco.Core.Persistence.PetaPocoCommandExtensions.ExecuteNonQueryWithRetry(IDbCommand command)
   at Umbraco.Core.Persistence.Database.Insert(String tableName, String primaryKeyName, Boolean autoIncrement, Object poco)
   at Umbraco.Core.Persistence.Database.Insert(Object poco)
   at Umbraco.Core.Persistence.Repositories.MediaRepository.PersistNewItem(IMedia entity)
   at Umbraco.Core.Cache.DefaultRepositoryCachePolicy`2.Create(TEntity entity, Action`1 persistNew)
   at Umbraco.Core.Persistence.Repositories.RepositoryBase`2.PersistNewItem(IEntity entity)
   at Umbraco.Core.Persistence.UnitOfWork.ScopeUnitOfWork.Commit(Action`1 transactionCompleting)
   at Umbraco.Core.Persistence.UnitOfWork.ScopeUnitOfWork.Commit()
   at Umbraco.Core.Services.MediaService.Umbraco.Core.Services.IMediaServiceOperations.Save(IMedia media, Int32 userId, Boolean raiseEvents)
   at Umbraco.Core.Services.MediaService.Save(IMedia media, Int32 userId, Boolean raiseEvents)
   at Umbraco.SampleSite.InstallPackageAction.CreateMediaItem(IMediaService service, Int32 parentFolder, String nodeTypeAlias, Guid key, String nodeName, String mediaPath, Boolean checkForDuplicate)
   at Umbraco.SampleSite.InstallPackageAction.Execute(String packageName, XmlNode xmlData)

Currently the shipped css and js files are:

/css/style.css
/scripts/app.js

These are very common names to have and if they exist already in a website they will not be overridden by the package installer so the package will be broken. I would suggest that we simply rename these to be less generic so it's clear what they are for:

/css/umbraco-sample-site.css
/scripts/umbraco-sample-site.js

When I run the project and open localhost:00000/Umbraco, it asks me for username and password. Kindly tell me the username and password. I'm new to Umbraco and watch a demo project for learning purpose.

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9
9.4.2

Bug summary
The macro "Select Featured Products" throws an error:

Value cannot be null. (Parameter 'source')

Specifics
No response

Steps to reproduce
I am using a fresh install of v9.4.2.
I have tried to insert "Select Featured Products" macro on the Homepage and got the error after selecting a product and submitting.

Expected result / actual result
After changing line 17 of Settings > Partial View Macro Files > FeaturedProducts.cshtml to:

var selection = Model.MacroParameters.FirstOrDefault(p => p.Key == "product").Value?.ToString().Split(',');
the macro works. And I could also update the product parameter of Settings > Macros > Select Featured Products from Content Picker to Multiple Content Picker.

The problem is because it's using hard coded media paths when it installs the media in the package actions.

I find myself altering this starterkit a lot every time I use it because its build very specific for the starter kit. In my opinion a starterkit should be more generic while still showing the best practices in umbraco.

I suggest we add the full minified version of Bootstrap 4 witch also uses flexbox as a base for the grid.
Also i want to suggest seperating the themes from the main css and put them in a [theme_name].css.
in the past I did this with a stylesheet picker to add the themes (screenshots below). This way we can make it easier to add new themes.

I'm curious what you think of these changes.

Version of Umbraco: 9.0.0

When installing the starterkit from scratch on v9, the templates is not nested under the Master template.
That means that the UI for templates in the backoffice looks like this:

I'd expect them to look like this:

The templates themselves are fine - they have the correct Layout = "master.cshtml"; specified - so it looks to be an issue on the schema side of things.
I'd be happy to do a PR, but I'm not sure where the content lives in this package - if someone could point me in the right direction, I would be happy to do it 😅

I completed an empty Umbraco installation, then set it up in IIS as a Virtual Application (sub application beneath another website).

I then logged into this application via the IIS bindings and installed The Starter Kit from the back-office. The installation is successful, but the files are installed in the wrong folders. The views are all installed correctly in the Views folder, however everything else is installed in a new sub directory that shares the name of the Virtual Application (Umbraco-7-9-2). Please see attached screenshot. As a result the views can't find the partials. If I resolve that, the CSS cannot be found etc. until all the files are manually moved.

I don't know if this is an Umbraco wide problem or specific to this package.

Is running Umbraco as a virtual application even supported? I have inherited a site that is setup as a virtual application and I was investigating the limitations of this when I found the error described above.

Many thanks,
Nathan

Currently the logic does:

var site = Model.Content.AncestorsOrSelf().Last();

but it should do:

var site = Model.Content.Site();

as this is the best practice format to get the site node, it's easier to write and it performs better

(i'll fix up)

Hello,

Umbraco version: 8.14.0
New starter kit install (as of today)

I've found two issues:

• The contact form is missing from the contact page
• If you delete the form and remove from the contact page the front end errors with:

I would love to help fix the second issue if you could point me at the source, I'm not clear from the readme if this is the correct source or not.

I get these errors in the logs while I'm trying to install the starter kit

2019-02-08 17:43:17,390 [P21756/D42/T219] ERROR  Umbraco.Examine.UmbracoContentIndex - Error indexing queue items
System.ArgumentException: An item with the same key has already been added.
   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at System.Collections.Generic.Dictionary`2..ctor(IDictionary`2 dictionary, IEqualityComparer`1 comparer)
   at Examine.LuceneEngine.Providers.LuceneIndex.AddDocument(Document doc, ValueSet valueSet, IndexWriter writer) in C:\Users\Shannon\Documents\_Projects\Examine\Examine\src\Examine\LuceneEngine\Providers\LuceneIndex.cs:line 669
   at Umbraco.Examine.UmbracoExamineIndex.AddDocument(Document doc, ValueSet valueSet, IndexWriter writer) in C:\Users\Shannon\Documents\_Projects\Umbraco\Umbraco_8.0\src\Umbraco.Examine\UmbracoExamineIndex.cs:line 167
   at Examine.LuceneEngine.Providers.LuceneIndex.ProcessIndexQueueItem(IndexOperation op, IndexWriter writer) in C:\Users\Shannon\Documents\_Projects\Examine\Examine\src\Examine\LuceneEngine\Providers\LuceneIndex.cs:line 1194
   at Examine.LuceneEngine.Providers.LuceneIndex.ProcessQueueItem(IndexOperation item, IndexWriter writer) in C:\Users\Shannon\Documents\_Projects\Examine\Examine\src\Examine\LuceneEngine\Providers\LuceneIndex.cs:line 1013
   at Examine.LuceneEngine.Providers.LuceneIndex.ForceProcessQueueItems(Boolean block) in C:\Users\Shannon\Documents\_Projects\Examine\Examine\src\Examine\LuceneEngine\Providers\LuceneIndex.cs:line 872

I'm in the process of cleaning up this solution so that the website is part of the sln, that it uses Nuget and that a new comer can get up and running very quickly by opening the sln and pressing F5.

I would also like to automate the build process of this to output the Umbraco package file like I do in Articulate (https://shazwazza.com/post/powershell-script-to-create-an-umbraco-package-in-umbraco-s-package-file-format/) ... but the actual package manifest file that creates the package is missing from Git

Can you please add this file?

Hello,

When I install the starter kit, the .cshtml files are inconsistently upper/ lowercase file names.

I'd like to update this so it is following a standard convention going in to v9 launch. Can you confirm if this is right place for an update?
https://github.com/umbraco/The-Starter-Kit/blob/a8f3d9a7d986741ee18b45c5b4125273ec5bd288/src/Umbraco.SampleSite/InstallPackageAction.cs ? Line 41.

If so, I will create a PR :)

Thanks,
Carole

When detecting if Umbraco Forms is installed or not

Noticed that there are spelling mistakes in create-content.json.

Which is spelled wich

In readme file https://github.com/umbraco/The-Starter-Kit/blob/v9/dev/README.md it mention the URL https://umbraco-starter-kit.s1.umbraco.io which is broken.

It doesn't seem the site is available on the the Umbraco Cloud URL either: https://umbraco-starter-kit.euwest01.umbraco.io/

Maybe the project was renamed or isn't it available?

Probably should be replaced by something else?

In starterkit for Umbraco 8 it has a macro "Select Featured Products" (which can be inserted in grid). This macro has a parameter "Choose product" which allow selecting any node.

It would be great if it could use a product picker like the following (based on MNTP), but unfortunately the macro parameter doesn't allow specifying configuration of (macro) property editors.

This package relies on another 3rd party package for map functionality. This is something that is currently not supported by the Umbraco packaging system and means that it will need to ship with all of the other packages files. This would mean that the original package would then have difficultly installing and uninstalling would also cause problems.

Currently the solution as-is does not work because the package files for these 3rd party packages are not included and the strongly typed models for Models Builder also relies on these files.

Can we update our starter kit package to not rely on 3rd party packages?

When installing the starter kit, the alias of the "Hide in Navigation" property is wrong.
It is "umbracoNavihide", but has to be "umbracoNaviHide".

It's not best practices to hard code absolute paths, these should be changed to use @Url.Content, example:

 <link rel="stylesheet" href="@Url.Content("~/css/umbraco-starterkit-style.css")" />

I'll fix this up.

There is another issue #63 regarding this MarcoPartial. But I am concerned about the view part, which uses CurrentPage to retrieve parameters.

I do a PR to fix this.

Causing publish to fail!

If you install Forms then we should update the property editor on the contact page so you can select a form.

When opening umbraco-starterkit-app.js in scripts editor, it has several warnings.

It is best practice to add semi colons at the end of these lines.

Original created here: umbraco/Umbraco-CMS#4622

Steps:

1. Locally build and run Umbraco via github https://github.com/umbraco/Umbraco-CMS/
2. Works, current version is 9.2.0-rc
3. Want to install a Starter Kit and learn from it. Chose https://github.com/umbraco/The-Starter-Kit/

Expected:
Maintained / updated for 9.2?

Actual:
Last commit in 2020

Question:
Is this Starter Kit still a good starter kit for v9.2?

Thx

Hi

I don't know how to install this starter kit onto Umbraco Cloud

Steps:

1. new Umbraco Cloud instance.
2. (optional: complete "tours" from Umbraco). Excited to get started with Umbraco.
3. Browse Packages...see this Starter Kit as the most popular one and compatible with Umbraco Cloud.
   Expected:
   Can install it somehow
   Actual:
   Don't know how to install it?

Two issues here I don't know how to install any Umbraco Package on Umbraco Cloud, and specifically, I don't know how to install this Starter Kit.

Umbraco Cloud experience was awesome and seamless up until this point.

UmbracoTraceLog.PC-JOSE-DEV.20221103.json.txt

Hi this error happens at first run in an empty project thank you for helping

It is quite annoying having all of the data committed to this project and causes problems when trying to fix and merge.

We need to update the project to:

• be an empty MVC project with the correct Nuget references
• update the docs on how to force the re-install of the umbraco nuget packages when first cloning the repo
• update the docs on how to install the starter kit package when first cloning the repo
• remove and ignore all data files

This means there will be no odd merge conflicts when the community is working on this project and we don't have to have all of this committed to the repo.

because of hardcoded:

var blogposts = startNode.Children.OrderByDescending(x => x.CreateDate).Take(3);

numberOfPosts param is never used.

or is this intentionally?

2017-06-14 10:20:23,386 [P23116/D15/T32] INFO Umbraco.Deploy.GridCellValueConnectors.MediaGridCellValueConnector - Could not convert media-id '1115' to Udi. Please ensure that a media item with this id actually exist in the media library.
2017-06-14 10:20:23,590 [P23116/D15/T32] INFO Umbraco.Deploy.GridCellValueConnectors.MediaGridCellValueConnector - Could not convert media-id '1109' to Udi. Please ensure that a media item with this id actually exist in the media library.

This logic already exists in the package action when it checks if forms is installed but this logic doesn't exist in the event handler for when forms becomes installed so the 'contactForm' property remains as a label.

Currently the way that the Contact Forms is being installed is that it's json file is simply included in the package manifest, example:

<file>
    <guid>adf160f1-39f5-44c0-b01d-9e2da32bf093.json</guid>
    <orgPath>/App_Data/UmbracoForms/Data/forms</orgPath>
    <orgName>adf160f1-39f5-44c0-b01d-9e2da32bf093.json</orgName>
</file>

This works for a normal install but the problem is that this doesn't work for Umbraco Cloud since no UDA file is ever created for this form. A Form is like a schema item in Umbraco Cloud, it's UDA file is committed to Git and deployed via Git. If i clone an empty UC site, install this starter kit and then push it up, the form will not be installed because there is no UDA file. If the form was created with APIs during package installation a UDA file would be created because it would trigger event handlers.

Forms stores it's data in App_Data - it should be in the database but that's something we need to do in the next major version. In the meantime, files in App_Data can be thought of as a database, these files don't get persisted to Git.

When the starter kit is installed the default tour doesn't make a ton of sense so now the starter kit comes with it's own intro tour that overrides the default one.

When uninstalling the starterkit the installed forms do not get removed. There's a method for this in the FormsInstallationHelper but it isn't called so prolly a fairly easy fix.

Reproduce

• Install the starterkit package.
• Uninstall the starterkit package.
• Go to the Forms section and see that there's a left-over contact form.

There's a few null checks missing in InstallPackageAction and it won't work when there's already content in there because it's doing things like:

GetRootContent().FirstOrDefault();

which it just assumes is it's own content but that is not the case.

So the form is visible

These files are simply not in the source but are referenced in code so parts of the site fail.