underfisk / blizzhub-ts

A typescript implementation of the new battle.net developer API updated with the latest features provided by Blizzard

blizzhub-ts's Issues

Please fix multi-line URLs in templates

For example, in diablo3.js, you have a URL inside a template, but the template has a line break in the middle of it:

            this.getApiHero = (region, bnet, heroId, locale) => {
                return httpRequest_1.HttpRequest.get(`https://${region}.api.blizzard.com/d3/profile/${bnet}/hero/${heroId}
                ?locale=${locale}&access_token=${this.token.identifier}`);
            };

This is causing the library to actually insert a line break in the URL, which results in a 404 from Blizzard. To fix this, don't use line breaks inside templates when defining URLs:

            this.getApiHero = (region, bnet, heroId, locale) => {
                return httpRequest_1.HttpRequest.get(`https://${region}.api.blizzard.com/d3/profile/${bnet}/hero/${heroId}?locale=${locale}&access_token=${this.token.identifier}`);
            };

This type of error occurs in a whole bunch of places in diablo3.js and wow.js. I wanted to do a pull request for this, but apparently wow.js is missing from this repository. Please fix!