unfolddata / ogdd Goto Github PK

ki2017-03,2017,q28,62,do not or are note ...

should be

ki2017-03,2017,q28,62,do not or are not ...

also see https://a11yproject.com/checklist

Landmarks

• header role="banner"
• nav role="navigation"
• main role="main"

Links

• skip content link
• Ensure links have :focus state.
• Ensure links are recognizable (underlined).

Images

• use alt text

Navigation

• provide navigation feedback message
• set focus on navigation
• set page title
• ensure logical tab order

Data visualisations

• render data table for screenreaders

@enotsluap there is one more minor suggestion I would have regarding the focus area names:

Where some feature the '&', namely

• Knowledge & skills
• Stakeholder engagement & support

there is one that uses "and"

• Investment and financial performance

Let me know if you would like me to update this here in the repo and then have @camfindlay update the data on data.govt?

Change #root entry tag to something more specific, eg #ogdd-root

• src/index.js
• src/global-styles.js
• src/index.html (during development)
• .ss template

Page scroll position not consistent across views

Focus Area text for when mouse is on "Licensing" (on the right-hand side):
Remove comma and 's' on the end of contracts
so that it reads "... publication and contract renewals."

Plots

• test many surveys

Please remove " or any of the participating agencies" from the description of Focus Areas (on the right)

Code documentation

• classes
• functions

Wiki

• data
• text
• installation, technologies
• high level architecture
• plots
• credits
• integration

General

• button hover effects
• link styling
• optimise grid spacing (also mobile)
• adjust line-height

Header

• update header graphic (@dmprk)
• about link

Aside

• consistent sidebar positioning
• align icons

Plots

• improve axis styling

Focus Areas

• consistent card height (FF)
• style select dropdown
• reference hint position (other subject)

Focus Area Single

• optimise plot margins (mobile)

Key insights

• style select dropdown
• optimise card layout (also mobile)
• align key

Data services

• optimise card layout (also mobile)

Data assets

• optimise card layout (also mobile)
• align key

@camfindlay not sure what exactly may have caused this but I received this BAD GATEWAY error when accessing the surveys.csv resource:

HTTP502: BAD GATEWAY - The server, while acting as a gateway or proxy, received an invalid response from the upstream server it accessed in attempting to fulfil the request. GET - https://catalogue.data.govt.nz/api/3/action/datastore_search?resource_id=1578c5cc-fcfc-41ae-a61b-5f8f3467d437&limit=999999&callback=jsonp_1535004334745_80088

The second load attempt was successful (as of today the application will try loading 5 times before giving up) so this is not so much an issue for the dashboard

Robustness

• improve PropTypes type checking (immutable)

https://webtoolkit.govt.nz/standards/web-usability-standard-1-2/

Update data.govt test data to data provided in this repository
https://github.com/unfolddata/ogdd/tree/master/data

On firefox when hovering over a single agency focus area plot the expected response fails. Should

• show AoG data when hovering AoG area
• show survey data points when hovering anywhere

• allow "error" attribute unspecified in DATA constant (https://github.com/unfolddata/ogdd/blob/master/src/containers/App/constants.js#L34)
• improve error checking, also include absence of resource (CSV)

Content security policy prevents loading "data:" sources. Use "inline SVGs" or as external assets (latter may require setting global asset path constant)

• json file (for testing)
• csv file (for testing)
• data.govt api

New data.govt header content (logo and back-link) are within content container, limited to a width of 940px. Ideally dashboard app content should also be limited to same width.

Header

• consider limiting content width to 940px
• consider removing logo graphic (will still need application name)

General

• consider using data.govt font "fira sans"

data.govt styles messing with app styles

• enforce <button> styles, particularly focus state, hover state
• 'card buttons' do not adhere to width when resizing windows
• enforce <select>, particularly line break

Dashboard styles messing with data.govt styles

• move <body> styles to index.html (outside of deployed JS app)
• move <a> styles into #root tag

We have documented 3 data model options:
https://github.com/unfolddata/ogdd/wiki

72%
work with orther organisations in their sector to promote the value of specific datasets or open data in general