GithubHelp home page GithubHelp logo

ungoogled-software / ungoogled-chromium-windows Goto Github PK

View Code? Open in Web Editor NEW
1.1K 30.0 109.0 2.22 MB

Windows packaging for ungoogled-chromium

License: BSD 3-Clause "New" or "Revised" License

Python 88.62% Shell 11.38%
windows chromium ungoogled-chromium

ungoogled-chromium-windows's Introduction

ungoogled-chromium-windows

Windows packaging for ungoogled-chromium.

Downloads

Download binaries from the Contributor Binaries website.

Or install using winget install --id=eloston.ungoogled-chromium -e.

Source Code: It is recommended to use a tag via git checkout (see building instructions below). You may also use master, but it is for development and may not be stable.

Building

Google only supports Windows 10 x64 or newer. These instructions are tested on Windows 10 Pro x64.

NOTE: The default configuration will build 64-bit binaries for maximum security (TODO: Link some explanation). This can be changed to 32-bit by setting target_cpu to "x86" in flags.windows.gn.

Setting up the build environment

IMPORTANT: Please setup only what is referenced below. Do NOT setup other Chromium compilation tools like depot_tools, since we have a custom build process which avoids using Google's pre-built binaries.

Setting up Visual Studio

Follow the "Visual Studio" section of the official Windows build instructions.

  • Make sure to read through the entire section and install/configure all the required components.
  • If your Visual Studio is installed in a directory other than the default, you'll need to set a few environment variables to point the toolchains to your installation path. (Copied from instructions for Electron)
    • vs2019_install = DRIVE:\path\to\Microsoft Visual Studio\2019\Community (replace 2019 and Community with your installed versions)
    • WINDOWSSDKDIR = DRIVE:\path\to\Windows Kits\10
    • GYP_MSVS_VERSION = 2019 (replace 2019 with your installed version's year)

Other build requirements

IMPORTANT: Currently, the MAX_PATH path length restriction (which is 260 characters by default) must be lifted in for our Python build scripts. This can be lifted in Windows 10 (v1607 or newer) with the official installer for Python 3.6 or newer (you will see a button at the end of installation to do this). See Issue #345 for other methods for older Windows versions.

  1. Setup the following:
    • 7-Zip
    • Python 3.8 - 3.10 (for build and packaging scripts used below); Python 3.11 and above is not supported.
    • If you don't plan on using the Microsoft Store version of Python:
      • Check "Add python.exe to PATH" before install.
      • At the end of the Python installer, click the button to lift the MAX_PATH length restriction.
      • Check that your PATH does not contain the python3 wrapper shipped by Windows, as it will only prompt you to install Python from the Microsoft Store and exit. See this question on stackoverflow.com
      • Ensure that your Python directory either has a copy of Python named "python3.exe" or a symlink linking to the Python executable.
    • Make sure to lift the MAX_PATH length restriction, either by clicking the button at the end of the Python installer or by following these instructions.
    • Git (to fetch all required ungoogled-chromium scripts)
      • During setup, make sure "Git from the command line and also from 3rd-party software" is selected. This is usually the recommended option.
    • The following additional python modules needs to be installed using pip install:
      • httplib2

Building

Run in Developer Command Prompt for VS (as administrator):

git clone --recurse-submodules https://github.com/ungoogled-software/ungoogled-chromium-windows.git
cd ungoogled-chromium-windows
# Replace TAG_OR_BRANCH_HERE with a tag or branch name
git checkout --recurse-submodules TAG_OR_BRANCH_HERE
python3 build.py
python3 package.py

A zip archive and an installer will be created under build.

NOTE: If the build fails, you must take additional steps before re-running the build:

  • If the build fails while downloading the Chromium source code (which is during build.py), it can be fixed by removing build\download_cache and re-running the build instructions.
  • If the build fails at any other point during build.py, it can be fixed by removing everything under build other than build\download_cache and re-running the build instructions. This will clear out all the code used by the build, and any files generated by the build.

An efficient way to delete large amounts of files is using Remove-Item PATH -Recurse -Force. Be careful however, files deleted by that command will be permanently lost.

Developer info

First-time setup

  1. Setup MSYS2
  2. Run the following in a "MSYS2 MSYS" shell:
pacman -S quilt python3 vim tar dos2unix
# By default, there doesn't seem to be a vi command for less, quilt edit, etc.
ln -s /usr/bin/vim /usr/bin/vi

Updating patches and pruning list

  1. Start Developer Command Prompt for VS and MSYS2 MSYS shell and navigate to source folder
    1. Developer Command Prompt for VS
      • cd c:\path\to\repo\ungoogled-chromium-windows
    2. MSYS2 MSYS
      • cd /path/to/repo/ungoogled-chromium-windows
      • You can use Git Bash to determine the path to this repo
      • Or, you can find it yourself via /<drive letter>/<path with forward slashes>
  2. Retrieve downloads Developer Command Prompt for VS
    • mkdir "build\download_cache"
    • python3 ungoogled-chromium\utils\downloads.py retrieve -i downloads.ini -c build\download_cache
  3. Clone sources Developer Command Prompt for VS
    • python3 ungoogled-chromium\utils\clone.py -o build\src
  4. Check for rust version change (see below)
  5. Update pruning list Developer Command Prompt for VS
    • python3 ungoogled-chromium\devutils\update_lists.py -t build\src --domain-regex ungoogled-chromium\domain_regex.list
  6. Unpack downloads Developer Command Prompt for VS
    • python3 ungoogled-chromium\utils\downloads.py unpack -i downloads.ini -c build\download_cache build\src
  7. Apply ungoogled-chromium patches Developer Command Prompt for VS
    • python3 ungoogled-chromium\utils\patches.py apply --patch-bin build\src\third_party\git\usr\bin\patch.exe build\src ungoogled-chromium\patches
  8. Update windows patches MSYS2 MSYS
    1. Setup shell to update patches
      • source devutils/set_quilt_vars.sh
    2. Go into the source tree
      • cd build/src
    3. Fix line breaks of files to patch
      • grep -r ../../patches/ -e "^+++" | awk '{print substr($2,3)}' | xargs dos2unix
    4. Use quilt to refresh patches. See ungoogled-chromium's docs/developing.md section "Updating patches" for more details
    5. Go back to repo root
      • cd ../..
    6. Sanity checking for consistency in series file
      • ./devutils/check_patch_files.sh
  9. Check for esbuild dependency changes in file build/src/DEPS and adapt downloads.ini accordingly
  10. Check for commit hash changes of src submodule in third_party/microsoft_dxheaders (e.g. using GitHub https://github.com/chromium/chromium/tree/127.0.6533.72/third_party/microsoft_dxheaders) and adapt downloads.ini accordingly
  11. Check for version changes of windows rust crate (third_party/rust/windows_x86_64_msvc/) and adapt downloads.ini and patches/ungoogled-chromium/windows\windows-fix-building-with-rust.patch accordingly
  12. Use git to add changes and commit

Update rust

  1. Check RUST_REVISION constant in file tools/rust/update_rust.py in build root.
    1. Current revision is ab71ee7a9214c2793108a41efb065aa77aeb7326
  2. Get date for nightly rust build from rust github page: https://github.com/rust-lang/rust/commit/ab71ee7a9214c2793108a41efb065aa77aeb7326
    1. In this case, the corresponding nightly build date is 2024-04-12
    2. Adapt downloads.ini accordingly
  3. Download nightly rust build from: https://static.rust-lang.org/dist/2024-04-12/rust-nightly-x86_64-pc-windows-msvc.tar.gz
    1. Extract archive
    2. Execute rustc\bin\rustc.exe -V to get rust version string
    3. Adapt build.py accordingly
    4. Adapt patches\ungoogled-chromium\windows\windows-fix-building-with-rust.patch accordingly

License

See LICENSE

ungoogled-chromium-windows's People

Contributors

ahrotahn avatar akile9v avatar alexandreteles avatar dot-gov avatar eloston avatar luka-filipovic avatar networkexception avatar nifury avatar nikolay-prilepskiy avatar r4sas avatar seanking2919 avatar tangalbert919 avatar teeminus avatar tomasz1986 avatar willamettefour avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ungoogled-chromium-windows's Issues

No module named 'buildkit'

Traceback (most recent call last):
  File "build.py", line 25, in <module>
    import buildkit.config
ModuleNotFoundError: No module named 'buildkit'

Depends on "Debugging Tools for Windows"?

Exception: dbghelp.dll not found in "C:\Program Files (x86)\Windows Kits\10\Debuggers\x64\dbghelp.dll"
You must install the "Debugging Tools for Windows" feature from the Windows 10 SDK.
ERROR at //build/toolchain/win/BUILD.gn:49:3: Script returned non-zero exit code.
  exec_script("../../vs_toolchain.py",

Safebrowsing removal in windows

Why does windows build require more in depth removal of safebrowsing compared to other platforms?
Would insertion of windows-fix-building-without-safebrowsing.patch to other platform builds results in better safebrowsing removal since big part of code removed is not windows specific?

widevinecdm refusing to install after following the windows-specific instructions

this is in reference to the ungoogled chromium wiki faq, which can be found at https://github.com/ungoogled-software/ungoogled-chromium-wiki/blob/ce8c2b2cddd70cc3dcc17bec1e8f5ada792d14cf/faq.md

under the heading How do I install Widevine CDM?, there are windows specific instructions to install widevine cdm manually.
following the instructions, it asks to download the current version from google's servers by obtaining the version number, and then using that number to download the cdm via the link.

it then asks to place the cdm in \AppData\Local\Chromium\User Data, and then check chrome://components/ to see if the cdm has been installed correctly- where the version must not be 0.0.0.0

after following these steps, and having the correct folder layout (as checked with the google chrome's offline installer's version of widevine, and googlechromeportable's too), the version is still 0.0.0.0 and hence is not installed. what is causing this?

i have attached my constructed version of widevine cdm. i have tried both x86 and x64 for the folder structure.

WidevineCdm.zip

bug in current clang version

@mdusome I had it as well. The problem is in the current clang version. I've fixed it by manually downloading newer clang from here. Unpack & overwrite everything in src/third_party\llvm-build\Release+Asserts. And you can continue your build.

I'm not sure where can I find a packed new clang and llvm to include it in downloads.ini, so this solution can work for now.

Originally posted by @Luka-Filipovic in #46 (comment)

--disable-encryption not working anymore

Hi,

There is currently an issue with the patch to disable encryption to allow portability (ungoogled-software/ungoogled-chromium#591) on Windows. Looks like this regression occurs between Chromium 76.0.3809.132 to Chromium 77.0.3865.75 (see brave/brave-core#3385 (comment) and portapps/brave-portable#33). Do you have any idea about this @tangalbert919 @Eloston? I would like to fix this on Brave and ungoogled-chromium but hard to find something relevant. I have this output when I open ungoogled-chromium (80.0.3987.149) if --disable-encryption is enabled:

[1896:2800:0323/163555.011:ERROR:os_crypt_win.cc(102)] Failed to decrypt: Clรฉ non valide pour lโ€™utilisation dans lโ€™รฉtat spรฉcifiรฉ. (0x8009000B)

Thanks

Visual Studio 2019 Community error

Hi guys,

I set up my vs2019_install and WINDOWSSDKDIR environment variables. Despite this, I can't build without getting this error on Windows 10.

D:\ungoogled-chromium-windows\build\src>exit
D:\ungoogled-chromium-windows\build\src>call "D:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvars64.bat" >nul

D:\ungoogled-chromium-windows\build\src>set DEPOT_TOOLS_WIN_TOOLCHAIN=0

D:\ungoogled-chromium-windows\build\src>"out\Default\gn.exe" "gen" "out\Default" "--fail-on-unused-args"
Traceback (most recent call last):
  File "D:/ungoogled-chromium-windows/build/src/build/vs_toolchain.py", line 578, in <module>
    sys.exit(main())
  File "D:/ungoogled-chromium-windows/build/src/build/vs_toolchain.py", line 574, in main
    return commands[sys.argv[1]](*sys.argv[2:])
  File "D:/ungoogled-chromium-windows/build/src/build/vs_toolchain.py", line 551, in GetToolchainDir
    runtime_dll_dirs = SetEnvironmentAndGetRuntimeDllDirs()
  File "D:/ungoogled-chromium-windows/build/src/build/vs_toolchain.py", line 94, in SetEnvironmentAndGetRuntimeDllDirs
    os.environ['GYP_MSVS_OVERRIDE_PATH'] = DetectVisualStudioPath()
  File "D:/ungoogled-chromium-windows/build/src/build/vs_toolchain.py", line 183, in DetectVisualStudioPath
    version_as_year = GetVisualStudioVersion()
  File "D:/ungoogled-chromium-windows/build/src/build/vs_toolchain.py", line 173, in GetVisualStudioVersion
    ' Supported versions are: %s.' % supported_versions_str)
Exception: No supported Visual Studio can be found. Supported versions are: 16.0 (2019), 15.0 (2017).
ERROR at //build/config/win/visual_studio_version.gni:27:7: Script returned non-zero exit code.
      exec_script("../../vs_toolchain.py", [ "get_toolchain_dir" ], "scope")
      ^----------

Problems with build on Windows 7 x64

  1. https://github.com/ungoogled-software/ungoogled-chromium-windows/blob/master/build.py#L86
    Script outputs stdout instead of stderr. False error possible due to Python from Anaconda, python --version outputs Python 2.7.12 :: Anaconda 2.5.0 (64-bit), so it is better to add .* to the tail of the regexp.

  2. It worth mentioning in build instruction that cmd.exe should be run as Administrator, because unpacking of chromium sources by 7z requires make of symbolic links that only Administrator could do. Otherwise build.py outputs ERROR: Can not create symbolic link : Access is denied. and exits.

  3. On master, https://github.com/ungoogled-software/ungoogled-chromium-windows/blob/master/build.py#L198 command "tools\gn\bootstrap\bootstrap.py" "-o" "out\Default\gn.exe" "--skip-generate-buildfiles" fails with message WindowsError: [Error 2] The system cannot find the file specified because of 'ninja' in tools\gn\bootstrap\bootstrap.py. Replacement of all occurences ninja -> third_party/ninja/ninja works.

  4. Most problematic issue. During build by ninja few command fails:

top_domain_generator.exe failed with exit code 0xC0000142
transport_security_state_generator.exe failed with exit code 0xC0000142
generate_colors_info.exe failed with exit code 0xC0000142

With debugger's help I found that it looks like this issue: https://social.msdn.microsoft.com/Forums/windowsdesktop/en-US/4fd94e2b-5b9b-4f0c-8974-36256397946a/windows-19h1-sdk-dbghelpdll-does-not-load-on-windows-7
I found that delay load of dbghelp.dll helps, by changing of ungoogled-chromium-master\build\src\base\BUILD.gn

  if (is_win) {
    # This is in a separate config so the flags can be applied to dependents.
    # ldflags in GN aren't automatically inherited.
    config("base_win_linker_flags") {
      ldflags = [
        "/DELAYLOAD:cfgmgr32.dll",
        "/DELAYLOAD:powrprof.dll",
        "/DELAYLOAD:setupapi.dll",
+       "/DELAYLOAD:dbghelp.dll",
      ]
    }
  }

Possible to enable pgo (progile guided optimaztion)?

On official site, https://www.chromium.org/developers/gn-build-configuration, it says:

On Windows and Mac you also need to add the following entry to your .gclient file to automatically fetch the PGO profiles required to do an official build:

solutions = [
 {
    "name": "src",
    # ... 
    "custom_vars": {
      "checkout_pgo_profiles": True,
    },
  },
],

You can also set the following GN argument to disable PGO if needed:

chrome_pgo_phase = 0

I think if pgo can be applied, it build more efficiently (for building time and quality).

Can no longer Edit PDFs with fillable forms

Since The latest update, I can no longer edit PDFs. This is critical for me, now I have to find a new pdf editor.

I hadn't upgraded for a few versions, so I don't remember how far back of a version I was using.

Any help would be appreciated.

ImportError: cannot import name 'SEVENZIP_USE_REGISTRY'

D:\Build\ungoogled-chromium-windows> python build.py
Traceback (most recent call last):
  File "build.py", line 28, in <module>
    from _common import ENCODING, SEVENZIP_USE_REGISTRY, ExtractorEnum, get_logger
ImportError: cannot import name 'SEVENZIP_USE_REGISTRY' from '_common' (D:\Build\ungoogled-chromium-windows\ungoogled-chromium\utils\_common.py)

Environment: Python 3.8.2 + Windows 10
Already installed 7zip.

Ungoogled Chromiun doesn't work as a default browser

Hello, I'm using chrlauncher 2.5.7 (64-bit). I can't figure out how to make Ungoogled Chromiun work as a default browser. As seen on the attachment it is set as such, but attempting to open links on other apps (tested it with Telegram, Discord, Steam) doesn't work - nothing happens upon clicking a link. I would appreciate help, thanks.
image

windows 10 ERROR at //tools/grit/grit_rule.gni:101:3: Assertion failed.

ERROR at //tools/grit/grit_rule.gni:101:3: Assertion failed.
assert(
^-----
resource whitelist generation only works on non-component builds with debug info enabled.
See //tools/grit/grit_rule.gni:102:7:
symbol_level > 0 && !strip_debug_info && !is_component_build,
^-----------------------------------------------------------
This is where it was set.
See //net/BUILD.gn:16:1: whence it was imported.
import("//tools/grit/grit_rule.gni")
^----------------------------------
See //components/BUILD.gn:15:1: whence it was imported.
import("//tools/grit/repack.gni")
^-------------------------------
See //BUILD.gn:87:7: which caused the file to be included.
"//components:components_unittests",
^----------------------------------

D:\chromium\ungoogled-chromium-windows\build\src>exit
Traceback (most recent call last):
File "build.py", line 210, in
main()
File "build.py", line 202, in main
_run_build_process('out\Default\gn.exe', 'gen', 'out\Default', '--fail-on-unused-args')
File "build.py", line 67, in _run_build_process
**kwargs)
File "C:\Program Files\Python36\lib\subprocess.py", line 418, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '('cmd.exe', '/k')' returned non-zero exit status 1.

Not enough optimization in flags.windows.gn?

flags.windows.gn in this repo is as below:

chrome_pgo_phase=0
enable_swiftshader=false
ffmpeg_branding="Chrome"
is_clang=true
is_component_build=false
is_debug=false
proprietary_codecs=true
target_cpu="x64"
use_gnome_keyring=false
use_sysroot=false

Here are some common flags suggested on the web:

is_official_build = true
is_debug = false
dcheck_always_on = false
blink_symbol_level = 0
symbol_level = 0

is_official_build=true will do more optimizations
dcheck_always_on=false is likely to boost performance (dcheck_always_on=true will enable all runtime checks, somewhat slower performance)
blink_symbol_level=0 and symbol_level = 0 are for release verison


Here are the flags in project ungoogled-chromium:

clang_use_chrome_plugins=false
enable_hangout_services_extension=false
enable_js_type_check=false
enable_mdns=false
enable_mse_mpeg2ts_stream_parser=true
enable_nacl=false
enable_nacl_nonsfi=false
enable_one_click_signin=false
enable_reading_list=false
enable_remoting=false
enable_reporting=false
enable_service_discovery=false
enable_widevine=true
exclude_unwind_tables=true
fieldtrial_testing_like_official_build=true
google_api_key=""
google_default_client_id=""
google_default_client_secret=""
safe_browsing_mode=0
treat_warnings_as_errors=false
use_official_google_api_keys=false
use_unofficial_version_number=false

Why does ungoogled-chromium-windows modified this way?

vs_toolchain.py Visual Studio Version detection fails

Log.txt
I notice it enters line 146 in vs_toolchain.py. I don't have DEPOT_TOOLS_WIN_TOOLCHAIN set.
I have Vis Studio 2019 Community.

Edit: It could be that I am an idiot who forgot to install depot_tools, if yes then this is a call for better logging of how much of an idiot I was and why

python build.py failed

ฮป python.exe --version
Python 2.7.13

ฮป /path/to/python3.exe --version
Python 3.8.3

ฮป /path/to/python3.exe .\build.py
Traceback (most recent call last):
  File ".\build.py", line 220, in <module>
    main()
  File ".\build.py", line 134, in main
    _test_python2(parser.error)
  File ".\build.py", line 87, in _test_python2
    result.stdout.strip()))
AttributeError: 'NoneType' object has no attribute 'strip'

patch can't find file

INFO: * Applying mojo.patch (6/32)
DEBUG: E:\ungoogled-chromium-windows\build\src\third_party\git\usr\bin\patch.exe -p1 --ignore-whitespace -i E:\ungoogled-chromium-windows\patches\debian_buster\fixes\mojo.patch -d E:\ungoogled-chromium-windows\build\src --no-backup-if-mismatch --forward
(Stripping trailing CRs from patch; use --binary to disable.)
patching file content/shell/BUILD.gn
Hunk #1 succeeded at 144 (offset -1 lines).
Hunk #2 succeeded at 287 (offset 4 lines).
(Stripping trailing CRs from patch; use --binary to disable.)
can't find file to patch at input line 26
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- a/chromecast/common/mojom/typemaps.gni
|+++ b/chromecast/common/mojom/typemaps.gni
--------------------------
File to patch:

Failed To Patch v83

Folders: 844
Files: 3814
Size:       52106544
Compressed: 18664379
INFO: * Applying 0001-fix-building-without-safebrowsing.patch (1/84)
patching file chrome/browser/BUILD.gn
patching file chrome/browser/browser_process.h
patching file chrome/browser/browser_process_impl.cc
patching file chrome/browser/browser_process_impl.h
patching file chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
patching file chrome/browser/chrome_content_browser_client.cc
patching file chrome/browser/component_updater/file_type_policies_component_installer.cc
patching file chrome/browser/download/chrome_download_manager_delegate.cc
patching file chrome/browser/download/download_item_model.cc
patching file chrome/browser/download/download_prefs.cc
patching file chrome/browser/download/download_target_determiner.cc
patching file chrome/browser/extensions/api/downloads/downloads_api.cc
patching file chrome/browser/extensions/api/downloads/downloads_api.h
patching file chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_api.cc
patching file chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
patching file chrome/browser/extensions/blacklist_state_fetcher.cc
patching file chrome/browser/extensions/blacklist_state_fetcher.h
patching file chrome/browser/metrics/chrome_metrics_service_client.cc
patching file chrome/browser/net/trial_comparison_cert_verifier_controller.cc
patching file chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
patching file chrome/browser/profiles/profile_impl.cc
patching file chrome/browser/profiles/profiles_state.cc
patching file chrome/browser/safe_browsing/BUILD.gn
patching file chrome/browser/ssl/security_state_tab_helper.cc
patching file chrome/browser/subresource_filter/chrome_subresource_filter_client.cc
patching file chrome/browser/ui/BUILD.gn
patching file chrome/browser/ui/tab_helpers.cc
patching file chrome/browser/ui/webui/downloads/downloads_dom_handler.cc
patching file chrome/browser/ui/webui/downloads/downloads_dom_handler.h
patching file chrome/browser/ui/webui/interstitials/interstitial_ui.cc
patching file chrome/renderer/chrome_content_renderer_client.cc
patching file components/security_interstitials/content/cert_report_helper.cc
INFO: * Applying 0003-disable-autofill-download-manager.patch (2/84)
patching file components/autofill/core/browser/autofill_download_manager.cc
INFO: * Applying 0005-disable-default-extensions.patch (3/84)
patching file chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
patching file chrome/browser/extensions/component_loader.cc
patching file chrome/browser/extensions/external_component_loader.cc
patching file chrome/browser/extensions/webstore_installer.cc
INFO: * Applying 0007-disable-web-resource-service.patch (4/84)
patching file components/web_resource/web_resource_service.cc
INFO: * Applying 0009-disable-google-ipv6-probes.patch (5/84)
patching file net/dns/host_resolver_manager.cc
INFO: * Applying 0014-disable-translation-lang-fetch.patch (6/84)
patching file chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc
patching file components/translate/core/browser/translate_language_list.cc
patching file components/translate/core/browser/translate_ranker_impl.cc
INFO: * Applying 0015-disable-update-pings.patch (7/84)
patching file chrome/updater/configurator.cc
INFO: * Applying 0017-disable-new-avatar-menu.patch (8/84)
patching file components/signin/internal/identity_manager/primary_account_policy_manager_impl.cc
INFO: * Applying 0021-disable-rlz.patch (9/84)
patching file rlz/buildflags/buildflags.gni
INFO: * Applying unrar.patch (10/84)
patching file chrome/browser/safe_browsing/download_protection/file_analyzer.cc
patching file chrome/common/safe_browsing/BUILD.gn
patching file chrome/services/file_util/safe_archive_analyzer.cc
INFO: * Applying safe_browsing-disable-incident-reporting.patch (11/84)
patching file chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc
patching file chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
patching file chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
patching file chrome/browser/safe_browsing/safe_browsing_service.cc
patching file components/security_interstitials/core/safe_browsing_loud_error_ui.cc
INFO: * Applying safe_browsing-disable-reporting-of-safebrowsing-over.patch (12/84)
patching file chrome/browser/safe_browsing/client_side_detection_service.cc
INFO: * Applying all-add-trk-prefixes-to-possibly-evil-connections.patch (13/84)
patching file build/mac/tweak_info_plist.py
patching file chrome/browser/chromeos/customization/customization_document.cc
patching file chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
patching file chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
patching file chrome/browser/chromeos/file_manager/file_manager_string_util.cc
patching file chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
patching file chrome/browser/extensions/install_signer.cc
patching file chrome/browser/nacl_host/nacl_infobar_delegate.cc
patching file chrome/browser/profiles/profile_avatar_downloader.cc
patching file chrome/browser/resources/chromeos/accessibility/chromevox/background/prefs.js
patching file chrome/browser/resources/default_apps/external_extensions.json
patching file chrome/browser/safe_browsing/client_side_detection_service.cc
patching file chrome/browser/safe_browsing/download_protection/download_feedback.cc
patching file chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc
patching file chrome/browser/supervised_user/supervised_user_service.cc
patching file chrome/browser/tracing/crash_service_uploader.cc
patching file chrome/browser/ui/views/outdated_upgrade_bubble_view.cc
patching file chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
patching file chrome/common/extensions/chrome_extensions_client.cc
patching file chrome/common/url_constants.cc
patching file chrome/installer/setup/google_chrome_behaviors.cc
patching file chromecast/browser/service/cast_service_simple.cc
patching file chromeos/geolocation/simple_geolocation_provider.cc
patching file cloud_print/virtual_driver/win/port_monitor/port_monitor.cc
patching file components/cloud_devices/common/cloud_devices_urls.cc
patching file components/crash/core/app/breakpad_linux.cc
patching file components/drive/service/drive_api_service.cc
patching file components/feedback/feedback_uploader.cc
patching file components/gcm_driver/gcm_account_tracker.cc
patching file components/history/core/browser/web_history_service.cc
patching file components/metrics/url_constants.cc
patching file components/password_manager/core/browser/password_store.cc
patching file components/policy/core/common/policy_loader_win.cc
patching file components/policy/resources/policy_templates.json
patching file components/rappor/rappor_service_impl.cc
patching file components/safe_search_api/safe_search/safe_search_url_checker_client.cc
patching file components/search_engines/prepopulated_engines.json
patching file components/translate/core/browser/translate_url_fetcher.cc
patching file components/translate/core/common/translate_util.cc
patching file components/variations/variations_url_constants.cc
patching file content/browser/speech/speech_recognition_engine.cc
patching file content/shell/browser/shell_browser_main_parts.cc
patching file extensions/browser/updater/safe_manifest_parser.cc
patching file extensions/common/extension_urls.cc
patching file google_apis/gaia/gaia_constants.cc
patching file google_apis/gcm/engine/gservices_settings.cc
patching file jingle/notifier/base/gaia_token_pre_xmpp_auth.cc
patching file remoting/base/breakpad_mac.mm
patching file remoting/protocol/jingle_messages.cc
patching file ui/views/examples/webview_example.cc
INFO: * Applying disable-crash-reporter.patch (14/84)
patching file chrome/browser/tracing/crash_service_uploader.cc
patching file third_party/breakpad/breakpad/src/client/linux/sender/google_crash_report_sender.cc
INFO: * Applying disable-google-host-detection.patch (15/84)
patching file chrome/common/google_url_loader_throttle.cc
patching file components/google/core/common/google_util.cc
patching file components/page_load_metrics/browser/page_load_metrics_util.cc
patching file components/page_load_metrics/common/page_load_metrics_util.cc
patching file components/search_engines/template_url.cc
patching file components/variations/net/variations_http_headers.cc
patching file net/base/url_util.cc
INFO: * Applying replace-google-search-engine-with-nosearch.patch (16/84)
patching file components/search_engines/prepopulated_engines.json
INFO: * Applying disable-signin.patch (17/84)
patching file chrome/browser/ui/chrome_pages.cc
INFO: * Applying disable-translate.patch (18/84)
patching file components/translate/content/renderer/translate_agent.cc
patching file components/translate/core/browser/translate_manager.cc
patching file components/translate/core/browser/translate_script.cc
INFO: * Applying disable-untraceable-urls.patch (19/84)
patching file chrome/browser/plugins/plugins_resource_service.cc
patching file chrome/browser/safe_browsing/client_side_model_loader.cc
patching file chrome/browser/safe_browsing/client_side_model_loader.h
patching file rlz/lib/financial_ping.cc
patching file rlz/lib/lib_values.cc
patching file rlz/lib/lib_values.h
INFO: * Applying disable-profile-avatar-downloading.patch (20/84)
patching file chrome/browser/profiles/profile_avatar_downloader.cc
INFO: * Applying disable-gcm.patch (21/84)
patching file components/gcm_driver/gcm_client_impl.cc
INFO: * Applying disable-domain-reliability.patch (22/84)
patching file components/domain_reliability/BUILD.gn
patching file components/domain_reliability/bake_in_configs.py
patching file components/domain_reliability/google_configs.cc
patching file components/domain_reliability/uploader.cc
INFO: * Applying block-trk-and-subdomains.patch (23/84)
patching file chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc
patching file chrome/browser/history/history_utils.cc
patching file chrome/browser/ui/singleton_tabs.cc
patching file components/omnibox/browser/autocomplete_input.cc
patching file components/url_formatter/url_fixer.cc
patching file content/browser/child_process_security_policy_impl.cc
patching file net/BUILD.gn
patching file net/url_request/trk_protocol_handler.cc
patching file net/url_request/trk_protocol_handler.h
patching file net/url_request/url_request.cc
patching file net/url_request/url_request_context_builder.cc
patching file url/url_constants.cc
patching file url/url_constants.h
patching file url/url_util.cc
INFO: * Applying fix-building-without-one-click-signin.patch (24/84)
patching file chrome/browser/ui/BUILD.gn
patching file chrome/browser/ui/sync/one_click_signin_links_delegate_impl.cc
patching file chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
INFO: * Applying disable-gaia.patch (25/84)
patching file chrome/browser/browser_resources.grd
patching file chrome/browser/ui/webui/signin/inline_login_ui.cc
patching file google_apis/gaia/gaia_auth_fetcher.cc
INFO: * Applying disable-fonts-googleapis-references.patch (26/84)
patching file components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
patching file components/dom_distiller/core/html/preview.html
patching file components/dom_distiller/core/javascript/dom_distiller_viewer.js
patching file third_party/catapult/third_party/polymer/components/font-roboto/roboto.html
patching file third_party/catapult/tracing/third_party/gl-matrix/jsdoc-template/static/default.css
patching file third_party/crashpad/crashpad/doc/support/crashpad_doxygen.css
patching file third_party/flatbuffers/src/docs/header.html
patching file tools/md_browser/base.css
INFO: * Applying disable-webstore-urls.patch (27/84)
patching file chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
patching file chrome/browser/extensions/chrome_content_verifier_delegate.cc
patching file chrome/browser/extensions/extension_migrator.cc
patching file chrome/browser/extensions/extension_migrator.h
patching file extensions/browser/updater/extension_downloader.cc
patching file extensions/common/extension_urls.cc
INFO: * Applying fix-learn-doubleclick-hsts.patch (28/84)
patching file net/tools/transport_security_state_generator/transport_security_state_generator.cc
INFO: * Applying disable-webrtc-log-uploader.patch (29/84)
patching file chrome/browser/media/webrtc/webrtc_log_uploader.cc
INFO: * Applying use-local-devtools-files.patch (30/84)
patching file third_party/devtools-frontend/src/BUILD.gn
patching file third_party/devtools-frontend/src/front_end/devtools_app.json
patching file third_party/devtools-frontend/src/front_end/lighthouse_worker.json
INFO: * Applying disable-network-time-tracker.patch (31/84)
patching file components/network_time/network_time_tracker.cc
INFO: * Applying disable-mei-preload.patch (32/84)
patching file chrome/BUILD.gn
INFO: * Applying fix-building-without-safebrowsing.patch (33/84)
patching file chrome/browser/chrome_content_browser_client.cc
patching file chrome/browser/download/chrome_download_manager_delegate.cc
patching file chrome/browser/download/download_item_model.cc
patching file chrome/browser/download/download_item_model.h
patching file chrome/browser/download/download_target_determiner.cc
patching file chrome/browser/download/download_target_determiner.h
patching file chrome/browser/download/download_target_info.cc
patching file chrome/browser/download/download_target_info.h
patching file chrome/browser/download/download_ui_model.cc
patching file chrome/browser/download/download_ui_model.h
patching file chrome/browser/native_file_system/chrome_native_file_system_permission_context.cc
patching file chrome/browser/native_file_system/chrome_native_file_system_permission_context.h
patching file chrome/browser/password_manager/chrome_password_manager_client.cc
patching file chrome/browser/password_manager/chrome_password_manager_client.h
patching file chrome/browser/permissions/contextual_notification_permission_ui_selector.cc
patching file chrome/browser/ui/tab_contents/chrome_web_contents_view_handle_drop.cc
patching file chrome/browser/ui/views/download/download_item_view.cc
patching file chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc
patching file chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
patching file chrome/browser/ui/webui/downloads/downloads_dom_handler.cc
patching file components/password_manager/content/browser/content_password_manager_driver.cc
patching file components/password_manager/core/browser/password_manager_client.h
patching file components/safe_browsing/content/common/safe_browsing.mojom
patching file components/safe_browsing/core/file_type_policies.h
patching file content/browser/native_file_system/native_file_system_file_writer_impl.cc
patching file content/browser/native_file_system/native_file_system_file_writer_impl.h
patching file content/public/browser/native_file_system_permission_context.h
INFO: * Applying remove-unused-preferences-fields.patch (34/84)
patching file android_webview/browser/aw_browser_context.cc
patching file chrome/app/settings_strings.grdp
patching file chrome/browser/android/preferences/prefs.h
patching file chrome/browser/android/signin/signin_manager_android.cc
patching file chrome/browser/android/signin/signin_manager_android.h
patching file chrome/browser/chrome_content_browser_client.cc
patching file chrome/browser/chrome_content_browser_client_receiver_bindings.cc
patching file chrome/browser/chromeos/lock_screen_apps/lock_screen_profile_creator_impl.cc
patching file chrome/browser/chromeos/lock_screen_apps/lock_screen_profile_creator_impl_unittest.cc
patching file chrome/browser/chromeos/login/signin/device_id_browsertest.cc
patching file chrome/browser/chromeos/policy/secondary_google_account_signin_policy_handler.cc
patching file chrome/browser/chromeos/policy/secondary_google_account_signin_policy_handler_unittest.cc
patching file chrome/browser/download/download_browsertest.cc
patching file chrome/browser/download/download_item_model.cc
patching file chrome/browser/enterprise/connectors/connectors_manager.cc
patching file chrome/browser/extensions/api/identity/identity_apitest.cc
patching file chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc
patching file chrome/browser/extensions/api/preference/preference_api.cc
patching file chrome/browser/extensions/api/preference/preference_apitest.cc
patching file chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router.cc
patching file chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router.h
patching file chrome/browser/extensions/api/safe_browsing_private/safe_browsing_private_event_router_unittest.cc
patching file chrome/browser/extensions/api/settings_private/prefs_util.cc
patching file chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
patching file chrome/browser/net/trial_comparison_cert_verifier_browsertest.cc
patching file chrome/browser/net/trial_comparison_cert_verifier_controller.cc
patching file chrome/browser/net/trial_comparison_cert_verifier_controller.h
patching file chrome/browser/net/trial_comparison_cert_verifier_controller_unittest.cc
patching file chrome/browser/password_manager/password_store_factory.cc
patching file chrome/browser/policy/browser_signin_policy_handler.cc
patching file chrome/browser/policy/configuration_policy_handler_list_factory.cc
patching file chrome/browser/prefs/browser_prefs.cc
patching file chrome/browser/prefs/chrome_command_line_pref_store.cc
patching file chrome/browser/prefs/chrome_pref_service_factory.cc
patching file chrome/browser/prefs/pref_functional_browsertest.cc
patching file chrome/browser/profiles/gaia_info_update_service.cc
patching file chrome/browser/profiles/gaia_info_update_service_unittest.cc
patching file chrome/browser/profiles/profile.cc
patching file chrome/browser/profiles/profile_attributes_entry.cc
patching file chrome/browser/profiles/profile_impl.cc
patching file chrome/browser/profiles/profile_io_data.cc
patching file chrome/browser/profiles/profile_manager.cc
patching file chrome/browser/profiles/profile_window.cc
patching file chrome/browser/profiles/profiles_state.cc
patching file chrome/browser/resources/settings/privacy_page/disable_safebrowsing_dialog.html
patching file chrome/browser/resources/settings/privacy_page/privacy_page.html
patching file chrome/browser/resources/settings/privacy_page/privacy_page.js
patching file chrome/browser/resources/settings/privacy_page/security_page.html
patching file chrome/browser/resources/settings/site_settings_page/site_settings_page.js
patching file chrome/browser/safe_browsing/ad_redirect_trigger_browsertest.cc
patching file chrome/browser/safe_browsing/advanced_protection_status_manager.cc
patching file chrome/browser/safe_browsing/advanced_protection_status_manager_unittest.cc
patching file chrome/browser/safe_browsing/android/services_delegate_android.h
patching file chrome/browser/safe_browsing/certificate_reporting_service.cc
patching file chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
patching file chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
patching file chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc
patching file chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.cc
patching file chrome/browser/safe_browsing/chrome_password_protection_service.cc
patching file chrome/browser/safe_browsing/chrome_password_protection_service.h
patching file chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc
patching file chrome/browser/safe_browsing/chrome_password_protection_service_sync_browsertest.cc
patching file chrome/browser/safe_browsing/client_side_detection_host.cc
patching file chrome/browser/safe_browsing/client_side_detection_service.cc
patching file chrome/browser/safe_browsing/cloud_content_scanning/binary_upload_service.cc
patching file chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
patching file chrome/browser/safe_browsing/download_protection/check_client_download_request_base.cc
patching file chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
patching file chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
patching file chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
patching file chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
patching file chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
patching file chrome/browser/safe_browsing/incident_reporting/state_store.cc
patching file chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc
patching file chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
patching file chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
patching file chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
patching file chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
patching file chrome/browser/safe_browsing/safe_browsing_service.cc
patching file chrome/browser/safe_browsing/safe_browsing_service.h
patching file chrome/browser/safe_browsing/telemetry/android/android_telemetry_service.cc
patching file chrome/browser/safe_browsing/telemetry/android/android_telemetry_service_unittest.cc
patching file chrome/browser/safe_browsing/ui_manager.cc
patching file chrome/browser/safe_browsing/ui_manager_unittest.cc
patching file chrome/browser/safe_browsing/url_checker_delegate_impl.cc
patching file chrome/browser/signin/account_consistency_mode_manager.cc
patching file chrome/browser/signin/account_consistency_mode_manager_unittest.cc
patching file chrome/browser/signin/chrome_device_id_helper.cc
patching file chrome/browser/signin/chrome_signin_client.cc
patching file chrome/browser/signin/chromeos_mirror_account_consistency_browsertest.cc
patching file chrome/browser/signin/dice_browsertest.cc
patching file chrome/browser/signin/header_modification_delegate_impl.cc
patching file chrome/browser/signin/mirror_browsertest.cc
patching file chrome/browser/signin/signin_promo_util.cc
patching file chrome/browser/signin/signin_ui_util.cc
patching file chrome/browser/signin/signin_util.cc
patching file chrome/browser/signin/signin_util_win.cc
patching file chrome/browser/signin/signin_util_win_browsertest.cc
patching file chrome/browser/ssl/certificate_reporting_test_utils.cc
patching file chrome/browser/ssl/ssl_browsertest.cc
patching file chrome/browser/ssl/ssl_error_controller_client.cc
patching file chrome/browser/supervised_user/supervised_user_pref_store.cc
patching file chrome/browser/ui/autofill/payments/save_card_bubble_controller_impl.cc
patching file chrome/browser/ui/browser_command_controller.cc
patching file chrome/browser/ui/browser_command_controller.h
patching file chrome/browser/ui/browser_command_controller_unittest.cc
patching file chrome/browser/ui/chrome_pages.cc
patching file chrome/browser/ui/views/download/download_item_view.cc
patching file chrome/browser/ui/views/page_info/page_info_bubble_view_sync_browsertest.cc
patching file chrome/browser/ui/views/profiles/profile_menu_view.cc
patching file chrome/browser/ui/views/profiles/profile_menu_view_browsertest.cc
patching file chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.cc
patching file chrome/browser/ui/views/safe_browsing/password_reuse_modal_warning_dialog.h
patching file chrome/browser/ui/views/sync/inline_login_ui_browsertest.cc
patching file chrome/browser/ui/webui/app_launcher_login_handler.cc
patching file chrome/browser/ui/webui/downloads/downloads_dom_handler.cc
patching file chrome/browser/ui/webui/management_ui_handler.cc
patching file chrome/browser/ui/webui/profile_info_watcher.cc
patching file chrome/browser/ui/webui/profile_info_watcher.h
patching file chrome/browser/ui/webui/reset_password/reset_password_ui.cc
patching file chrome/browser/ui/webui/settings/people_handler.cc
patching file chrome/browser/ui/webui/settings/safe_browsing_handler.cc
patching file chrome/browser/ui/webui/settings/safety_check_handler.cc
patching file chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
patching file chrome/browser/ui/webui/settings/settings_ui.cc
patching file chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
patching file chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
patching file chrome/browser/ui/webui/signin/inline_login_handler.cc
patching file chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
patching file chrome/browser/ui/webui/signin/signin_error_ui.cc
patching file chrome/browser/ui/webui/signin/signin_utils_desktop.cc
patching file chrome/browser/ui/webui/welcome/welcome_ui.cc
patching file chrome/browser/unified_consent/unified_consent_service_factory.cc
patching file chrome/common/extensions/api/privacy.json
patching file components/password_manager/core/browser/BUILD.gn
patching file components/password_manager/core/browser/leak_detection_delegate.cc
patching file components/password_manager/core/browser/password_bubble_experiment.cc
patching file components/password_manager/core/browser/password_reuse_detector.cc
patching file components/password_manager/core/browser/password_store.cc
patching file components/password_manager/core/browser/password_sync_util.cc
patching file components/password_manager/core/browser/password_sync_util_unittest.cc
patching file components/password_manager/core/browser/sync_credentials_filter_unittest.cc
patching file components/policy/core/common/policy_loader_win.cc
patching file components/safe_browsing/content/base_blocking_page.cc
patching file components/safe_browsing/content/password_protection/password_protection_service.cc
patching file components/safe_browsing/content/password_protection/password_protection_service.h
patching file components/safe_browsing/content/triggers/suspicious_site_trigger_unittest.cc
patching file components/safe_browsing/content/web_ui/safe_browsing_ui.cc
patching file components/safe_browsing/core/common/BUILD.gn
patching file components/safe_browsing/core/common/safe_browsing_policy_handler.cc
patching file components/safe_browsing/core/common/safe_browsing_prefs_unittest.cc
patching file components/safe_browsing/core/db/hit_report.h
patching file components/safe_browsing/core/db/util.h
patching file components/safe_browsing/core/db/v4_local_database_manager.cc
patching file components/safe_browsing/core/db/v4_local_database_manager.h
patching file components/safe_browsing/core/db/v4_protocol_manager_util.cc
patching file components/safe_browsing/core/db/v4_protocol_manager_util.h
patching file components/safe_browsing/core/db/v4_update_protocol_manager.cc
patching file components/safe_browsing/core/db/v4_update_protocol_manager.h
patching file components/safe_browsing/core/ping_manager.cc
patching file components/safe_browsing/core/realtime/policy_engine.cc
patching file components/safe_browsing/core/realtime/url_lookup_service.cc
patching file components/safe_browsing/core/triggers/trigger_manager.cc
patching file components/safe_browsing/core/triggers/trigger_throttler.cc
patching file components/safe_browsing/core/triggers/trigger_throttler_unittest.cc
patching file components/security_interstitials/content/bad_clock_blocking_page.cc
patching file components/security_interstitials/content/captive_portal_blocking_page.cc
patching file components/security_interstitials/content/cert_report_helper.cc
patching file components/security_interstitials/content/mitm_software_blocking_page.cc
patching file components/security_interstitials/content/security_interstitial_controller_client.cc
patching file components/security_interstitials/content/security_interstitial_controller_client.h
patching file components/security_interstitials/content/security_interstitial_page.cc
patching file components/security_interstitials/content/ssl_blocking_page.cc
patching file components/security_interstitials/core/controller_client.cc
patching file components/security_interstitials/core/controller_client.h
patching file components/signin/core/browser/account_investigator.cc
patching file components/signin/core/browser/account_investigator_unittest.cc
patching file components/signin/core/browser/account_reconcilor_unittest.cc
patching file components/signin/core/browser/dice_account_reconcilor_delegate.cc
patching file components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
patching file components/signin/core/browser/signin_investigator.cc
patching file components/signin/core/browser/signin_investigator_unittest.cc
patching file components/signin/internal/identity_manager/account_tracker_service.cc
patching file components/signin/internal/identity_manager/account_tracker_service.h
patching file components/signin/internal/identity_manager/account_tracker_service_unittest.cc
patching file components/signin/internal/identity_manager/gaia_cookie_manager_service.cc
patching file components/signin/internal/identity_manager/gaia_cookie_manager_service_unittest.cc
patching file components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc
patching file components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate_unittest.cc
patching file components/signin/internal/identity_manager/primary_account_manager.cc
patching file components/signin/internal/identity_manager/primary_account_manager_unittest.cc
patching file components/signin/internal/identity_manager/primary_account_mutator_impl.cc
patching file components/signin/internal/identity_manager/primary_account_policy_manager_impl.cc
patching file components/signin/internal/identity_manager/primary_account_policy_manager_impl.h
patching file components/signin/internal/identity_manager/primary_account_policy_manager_impl_unittest.cc
patching file components/signin/internal/identity_manager/profile_oauth2_token_service.cc
patching file components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos_unittest.cc
patching file components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_ios.mm
patching file components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_ios_unittest.mm
patching file components/signin/public/base/BUILD.gn
patching file components/signin/public/base/device_id_helper.cc
patching file components/signin/public/base/device_id_helper_unittest.cc
patching file components/signin/public/identity_manager/identity_utils.cc
patching file components/signin/public/identity_manager/identity_utils_unittest.cc
patching file components/signin/public/identity_manager/primary_account_mutator_unittest.cc
patching file tools/metrics/histograms/enums.xml
INFO: * Applying fix-building-without-enabling-reporting.patch (35/84)
patching file content/browser/BUILD.gn
INFO: * Applying disable-fetching-field-trials.patch (36/84)
patching file chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
patching file components/variations/service/variations_service.cc
INFO: * Applying 0006-modify-default-prefs.patch (37/84)
patching file chrome/browser/background/background_mode_manager.cc
patching file chrome/browser/chrome_content_browser_client.cc
patching file chrome/browser/net/prediction_options.cc
patching file chrome/browser/net/prediction_options.h
patching file chrome/browser/profiles/profile.cc
patching file chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
patching file chrome/browser/signin/account_consistency_mode_manager.cc
patching file chrome/browser/ui/browser_ui_prefs.cc
patching file chrome/browser/ui/navigation_correction_tab_observer.cc
patching file chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc
patching file chrome/service/cloud_print/connector_settings.cc
patching file components/autofill/core/common/autofill_prefs.cc
patching file components/bookmarks/browser/bookmark_utils.cc
patching file components/content_settings/core/browser/cookie_settings.cc
patching file components/password_manager/core/browser/password_manager.cc
patching file components/payments/core/payment_prefs.cc
INFO: * Applying 0008-restore-classic-ntp.patch (38/84)
patching file chrome/browser/search/search.cc
patching file components/ntp_snippets/features.cc
INFO: * Applying 0011-add-duckduckgo-search-engine.patch (39/84)
patching file components/search_engines/template_url_prepopulate_data.cc
INFO: * Applying 0013-disable-missing-key-warning.patch (40/84)
patching file chrome/browser/ui/startup/google_api_keys_infobar_delegate.cc
INFO: * Applying 0016-chromium-sandbox-pie.patch (41/84)
patching file sandbox/linux/BUILD.gn
INFO: * Applying 0018-disable-first-run-behaviour.patch (42/84)
patching file chrome/browser/ui/startup/startup_tab_provider.cc
INFO: * Applying 0019-disable-battery-status-service.patch (43/84)
patching file services/device/battery/battery_status_service.cc
patching file services/device/battery/battery_status_service.h
INFO: * Applying parallel.patch (44/84)
patching file tools/gn/bootstrap/bootstrap.py
INFO: * Applying connection-message.patch (45/84)
patching file components/error_page_strings.grdp
INFO: * Applying android.patch (46/84)
patching file BUILD.gn
INFO: * Applying fuzzers.patch (47/84)
patching file BUILD.gn
patching file content/test/BUILD.gn
patching file v8/tools/BUILD.gn
INFO: * Applying welcome-page.patch (48/84)
patching file chrome/browser/profiles/profile_manager.cc
INFO: * Applying google-api-warning.patch (49/84)
patching file chrome/browser/ui/startup/startup_browser_creator_impl.cc
INFO: * Applying device-notifications.patch (50/84)
patching file chrome/browser/printing/cloud_print/privet_notifications.cc
INFO: * Applying initialization.patch (51/84)
patching file third_party/cacheinvalidation/src/google/cacheinvalidation/include/types.h
INFO: * Applying net-cert-increase-default-key-length-for-newly-gener.patch (52/84)
patching file net/cert/x509_util.cc
INFO: * Applying mime_util-force-text-x-suse-ymp-to-be-downloaded.patch (53/84)
patching file third_party/blink/common/mime_util/mime_util.cc
INFO: * Applying prefs-only-keep-cookies-until-exit.patch (54/84)
patching file components/content_settings/core/browser/content_settings_registry.cc
INFO: * Applying prefs-always-prompt-for-download-directory-by-defaul.patch (55/84)
patching file chrome/browser/download/download_prefs.cc
INFO: * Applying updater-disable-auto-update.patch (56/84)
patching file chrome/browser/app_controller_mac.mm
INFO: * Applying Remove-EV-certificates.patch (57/84)
patching file net/cert/ev_root_ca_metadata.cc
INFO: * Applying browser-disable-profile-auto-import-on-first-run.patch (58/84)
patching file chrome/browser/chrome_browser_main.cc
INFO: * Applying add-components-ungoogled.patch (59/84)
patching file components/ungoogled/BUILD.gn
patching file components/ungoogled/ungoogled_switches.cc
patching file components/ungoogled/ungoogled_switches.h
INFO: * Applying disable-formatting-in-omnibox.patch (60/84)
patching file components/url_formatter/url_formatter.cc
INFO: * Applying popups-to-tabs.patch (61/84)
patching file content/renderer/render_view_impl.cc
INFO: * Applying add-ipv6-probing-option.patch (62/84)
patching file net/dns/host_resolver_manager.cc
INFO: * Applying remove-disable-setuid-sandbox-as-bad-flag.patch (63/84)
patching file chrome/browser/ui/startup/bad_flags_prompt.cc
INFO: * Applying disable-intranet-redirect-detector.patch (64/84)
patching file chrome/browser/intranet_redirect_detector.cc
INFO: * Applying enable-page-saving-on-more-pages.patch (65/84)
patching file chrome/browser/ui/browser_commands.cc
patching file components/offline_pages/core/offline_page_model.cc
patching file content/common/url_schemes.cc
patching file content/public/common/url_utils.cc
INFO: * Applying disable-download-quarantine.patch (66/84)
patching file components/download/internal/common/base_file.cc
patching file content/browser/BUILD.gn
patching file content/browser/renderer_host/pepper/pepper_file_io_host.cc
patching file content/browser/renderer_host/pepper/pepper_file_io_host.h
INFO: * Applying fix-building-without-mdns-and-service-discovery.patch (67/84)
patching file chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.cc
INFO: * Applying add-flag-to-stack-tabs.patch (68/84)
patching file chrome/browser/about_flags.cc
patching file chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
INFO: * Applying add-flag-to-configure-extension-downloading.patch (69/84)
patching file chrome/browser/about_flags.cc
patching file chrome/browser/download/download_crx_util.cc
patching file chrome/browser/download/download_crx_util.h
patching file chrome/browser/download/download_target_determiner.cc
patching file chrome/browser/extensions/extension_management.cc
INFO: * Applying add-flag-for-search-engine-collection.patch (70/84)
patching file chrome/browser/about_flags.cc
patching file chrome/renderer/chrome_render_frame_observer.cc
patching file chrome/renderer/chrome_render_frame_observer.h
patching file components/search_engines/template_url_service.cc
patching file components/search_engines/template_url_service.h
INFO: * Applying add-flag-to-disable-beforeunload.patch (71/84)
patching file components/javascript_dialogs/app_modal_dialog_manager.cc
INFO: * Applying add-flag-to-force-punycode-hostnames.patch (72/84)
patching file chrome/browser/about_flags.cc
patching file components/url_formatter/url_formatter.cc
INFO: * Applying searx.patch (73/84)
patching file components/search_engines/prepopulated_engines.json
patching file components/search_engines/search_engine_type.h
patching file components/search_engines/template_url_prepopulate_data.cc
INFO: * Applying disable-webgl-renderer-info.patch (74/84)
patching file third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
INFO: * Applying add-flag-to-show-avatar-button.patch (75/84)
patching file chrome/browser/about_flags.cc
patching file chrome/browser/ui/views/toolbar/toolbar_view.cc
INFO: * Applying add-suggestions-url-field.patch (76/84)
patching file chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
patching file chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js
patching file chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js
patching file chrome/browser/ui/search_engines/edit_search_engine_controller.cc
patching file chrome/browser/ui/search_engines/edit_search_engine_controller.h
patching file chrome/browser/ui/search_engines/keyword_editor_controller.cc
patching file chrome/browser/ui/search_engines/keyword_editor_controller.h
patching file chrome/browser/ui/search_engines/template_url_table_model.cc
patching file chrome/browser/ui/search_engines/template_url_table_model.h
patching file chrome/browser/ui/webui/settings/search_engines_handler.cc
patching file chrome/browser/ui/webui/settings/search_engines_handler.h
patching file components/search_engines/template_url_service.cc
patching file components/search_engines/template_url_service.h
INFO: * Applying add-flag-to-hide-crashed-bubble.patch (77/84)
patching file chrome/browser/ui/startup/startup_browser_creator_impl.cc
INFO: * Applying default-to-https-scheme.patch (78/84)
patching file chrome/browser/resources/bookmarks/edit_dialog.js
patching file components/omnibox/browser/autocomplete_input.cc
patching file components/omnibox/browser/autocomplete_provider.cc
patching file components/url_formatter/url_fixer.cc
INFO: * Applying add-flag-to-scroll-tabs.patch (79/84)
patching file chrome/browser/about_flags.cc
patching file chrome/browser/ui/views/frame/browser_root_view.cc
patching file chrome/browser/ui/views/frame/browser_root_view.h
INFO: * Applying enable-paste-and-go-new-tab-button.patch (80/84)
patching file chrome/browser/ui/views/tabs/new_tab_button.cc
patching file chrome/browser/ui/views/tabs/tab_strip.cc
INFO: * Applying enable-checkbox-external-protocol.patch (81/84)
patching file chrome/browser/ui/browser_ui_prefs.cc
INFO: * Applying fingerprinting-flags-client-rects-and-measuretext.patch (82/84)
patching file chrome/browser/BUILD.gn
patching file chrome/browser/about_flags.cc
patching file content/browser/BUILD.gn
patching file content/browser/renderer_host/render_process_host_impl.cc
patching file content/child/BUILD.gn
patching file content/child/runtime_features.cc
patching file third_party/blink/public/platform/web_runtime_features.h
patching file third_party/blink/renderer/core/dom/document.cc
patching file third_party/blink/renderer/core/dom/document.h
patching file third_party/blink/renderer/core/dom/element.cc
patching file third_party/blink/renderer/core/dom/range.cc
patching file third_party/blink/renderer/core/html/canvas/text_metrics.cc
patching file third_party/blink/renderer/core/html/canvas/text_metrics.h
patching file third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
patching file third_party/blink/renderer/platform/BUILD.gn
patching file third_party/blink/renderer/platform/exported/web_runtime_features.cc
patching file third_party/blink/renderer/platform/runtime_enabled_features.json5
INFO: * Applying flag-max-connections-per-host.patch (83/84)
patching file chrome/browser/BUILD.gn
patching file chrome/browser/about_flags.cc
patching file chrome/browser/browser_process_impl.cc
patching file chrome/browser/flag_descriptions.cc
patching file chrome/browser/flag_descriptions.h
patching file components/network_session_configurator/common/network_features.cc
patching file components/network_session_configurator/common/network_features.h
patching file components/network_session_configurator/common/network_switch_list.h
INFO: * Applying flag-fingerprinting-canvas-image-data-noise.patch (84/84)
patching file chrome/browser/about_flags.cc
patching file content/browser/renderer_host/render_process_host_impl.cc
patching file content/child/runtime_features.cc
patching file third_party/blink/public/platform/web_runtime_features.h
patching file third_party/blink/renderer/platform/BUILD.gn
patching file third_party/blink/renderer/platform/exported/web_runtime_features.cc
patching file third_party/blink/renderer/platform/graphics/image_data_buffer.cc
patching file third_party/blink/renderer/platform/graphics/static_bitmap_image.cc
patching file third_party/blink/renderer/platform/graphics/static_bitmap_image.h
patching file third_party/blink/renderer/platform/runtime_enabled_features.json5
INFO: * Applying chromium-skia-harmony.patch (1/16)
(Stripping trailing CRs from patch; use --binary to disable.)
patching file third_party/skia/src/ports/SkFontHost_FreeType.cpp
INFO: * Applying fix-cfi-failures-with-unbundled-libxml.patch (2/16)
(Stripping trailing CRs from patch; use --binary to disable.)
patching file third_party/blink/renderer/core/xml/parser/xml_document_parser.cc
Hunk #1 succeeded at 140 (offset 2 lines).
Hunk #2 succeeded at 159 (offset 2 lines).
Hunk #3 succeeded at 212 with fuzz 2 (offset 8 lines).
Hunk #4 succeeded at 296 with fuzz 2 (offset 16 lines).
(Stripping trailing CRs from patch; use --binary to disable.)
patching file third_party/blink/renderer/core/xml/xsl_style_sheet_libxslt.cc
(Stripping trailing CRs from patch; use --binary to disable.)
patching file third_party/blink/renderer/core/xml/xslt_extensions.cc
(Stripping trailing CRs from patch; use --binary to disable.)
patching file third_party/blink/renderer/core/xml/xslt_processor_libxslt.cc
Hunk #1 succeeded at 104 (offset 1 line).
(Stripping trailing CRs from patch; use --binary to disable.)
patching file third_party/blink/renderer/core/xml/xslt_unicode_sort.cc
(Stripping trailing CRs from patch; use --binary to disable.)
patching file third_party/libxml/chromium/xml_reader.cc
INFO: * Applying gpu-timeout.patch (3/16)
(Stripping trailing CRs from patch; use --binary to disable.)
patching file gpu/ipc/service/gpu_watchdog_thread.cc
Hunk #1 succeeded at 40 (offset 1 line).
INFO: * Applying windows-disable-reorder-fix-linking.patch (4/16)
(Stripping trailing CRs from patch; use --binary to disable.)
patching file chrome/BUILD.gn
Hunk #1 FAILED at 59.
Hunk #2 succeeded at 129 with fuzz 2 (offset -1 lines).
1 out of 2 hunks FAILED -- saving rejects to file chrome/BUILD.gn.rej
(Stripping trailing CRs from patch; use --binary to disable.)
patching file chrome/test/chromedriver/BUILD.gn
Hunk #1 succeeded at 360 (offset 8 lines).
(Stripping trailing CRs from patch; use --binary to disable.)
patching file tools/perf/chrome_telemetry_build/BUILD.gn
Hunk #1 succeeded at 43 (offset 1 line).
Traceback (most recent call last):
  File "build.py", line 220, in <module>
    main()
  File "build.py", line 182, in main
    patches.apply_patches(
  File "C:\Users\Jonathan\Desktop\ChromiumBuild\ungoogled-chromium-windows\ungoogled-chromium\utils\patches.py", line 132, in apply_patches
    subprocess.run(cmd, check=True)
  File "C:\Users\Jonathan\AppData\Local\Programs\Python\Python38-32\lib\subprocess.py", line 512, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['C:\\Users\\Jonathan\\Desktop\\ChromiumBuild\\ungoogled-chromium-windows\\build\\src\\third_party\\git\\usr\\bin\\patch.exe', '-p1', '--ignore-whitespace', '-i', 'C:\\Users\\Jonathan\\Desktop\\ChromiumBuild\\ungoogled-chromium-windows\\patches\\ungoogled-chromium\\windows\\windows-disable-reorder-fix-linking.patch', '-d', 'C:\\Users\\Jonathan\\Desktop\\ChromiumBuild\\ungoogled-chromium-windows\\build\\src', '--no-backup-if-mismatch', '--forward']' returned non-zero exit status 1.

C:\Users\Jonathan\Desktop\ChromiumBuild\ungoogled-chromium-windows>

Specifically:

INFO: * Applying windows-disable-reorder-fix-linking.patch (4/16)
(Stripping trailing CRs from patch; use --binary to disable.)
patching file chrome/BUILD.gn
Hunk #1 FAILED at 59.
Hunk #2 succeeded at 129 with fuzz 2 (offset -1 lines).
1 out of 2 hunks FAILED -- saving rejects to file chrome/BUILD.gn.rej

ninja path problem

Problem

ninja not found

Env

  • git tag: 86.0.4240.183-1.1

Error Message

...
Traceback (most recent call last):
  File "tools\gn\bootstrap\bootstrap.py", line 143, in <module>
    sys.exit(main(sys.argv[1:]))
  File "tools\gn\bootstrap\bootstrap.py", line 129, in main
    [ninja_binary, '-C', gn_build_dir, '-w', 'dupbuild=err', 'gn.exe'])
...

Debug

ninja_binary = os.getenv('NINJA', 'ninja') 

with NINJA not define, ninja_binary = "ninja" but it should be "third_party/ninja/ninja"

If I download ninja.exe, put it where it could be found by PATH(sys env var), the error gone.

Ref

#28

Chromium 92 update

Windows is the only binary with a version significantly behind the current ungoogled-chromium version. Is there a reason that this is the case?

Would you use the builds I build?

@Eloston Hey, as tangelbert919 is not building for now, I thought if I could. So, would you publish my builds?

I am not experienced, I will just follow instructions from Readme file, and test if the build is working or not.

[build] unable to build application

I get this error. I see others have gotten it yet I can't figure out how to fix. Maybe it should be added to the build instructions.

C:\Windows\System32\ungoogled-chromium-windows>py build.py
Python 3.9.5
Traceback (most recent call last):
  File "C:\Windows\System32\ungoogled-chromium-windows\build.py", line 220, in <module>
    main()
  File "C:\Windows\System32\ungoogled-chromium-windows\build.py", line 134, in main
    _test_python2(parser.error)
  File "C:\Windows\System32\ungoogled-chromium-windows\build.py", line 87, in _test_python2
    result.stdout.strip()))
AttributeError: 'NoneType' object has no attribute 'strip'

...and to show I have setup path variable for both:


C:\Windows\System32\ungoogled-chromium-windows>py -2
Python 2.7.16 (v2.7.16:413a49145e, Mar  4 2019, 01:37:19) [MSC v.1500 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> ^Z


C:\Windows\System32\ungoogled-chromium-windows>py -3
Python 3.9.5 (tags/v3.9.5:0a7dcbd, May  3 2021, 17:27:52) [MSC v.1928 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> ^Z

If it matters I used git checkout --recurse-submodules 89.0.4389.114-1.1 (also, where is version 91? the main reason for trying ungoogled chromium is so I can test jpeg xl when it comes out in 92 since ff hasn't implemented it yet)

Any help in building would be appreciated.

Building version 90 fails when patching

Hello everyone!

I have tried several times to compile version 90 (both 90.0.4430.93 and the current 90.0.4430.212) but it always fails to apply the patches, showing me the following error:

patching file third_party/libxml/chromium/xml_reader.cc
INFO: * Applying windows-disable-reorder-fix-linking.patch (3/20)
patching file chrome/BUILD.gn
Hunk #2 FAILED at 99.
1 out of 2 hunks FAILED -- saving rejects to file chrome/BUILD.gn.rej
patching file chrome/test/chromedriver/BUILD.gn
patching file tools/perf/chrome_telemetry_build/BUILD.gn
Hunk #1 succeeded at 58 (offset 18 lines).
Traceback (most recent call last):
File "C:\ungoogled-chromium-windows\build.py", line 220, in
main()
File "C:\ungoogled-chromium-windows\build.py", line 182, in main
patches.apply_patches(
File "C:\ungoogled-chromium-windows\ungoogled-chromium\utils\patches.py", line 132, in apply_patches
subprocess.run(cmd, check=True)
File "C:\Python39\lib\subprocess.py", line 528, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['C:\ungoogled-chromium-windows\build\src\third_party\git\usr\bin\patch.exe', '-p1', '--ignore-whitespace', '-i', 'C:\ungoogled-chromium-windows\patches\ungoogled-chromium\windows\windows-disable-reorder-fix-linking.patch', '-d', 'C:\ungoogled-chromium-windows\build\src', '--no-backup-if-mismatch', '--forward']' returned non-zero exit status 1.

Has this same error occurred to someone else?

Finish updating windows-fix-building-without-safebrowsing.patch

So, d2674a9 made windows-fix-building-without-safebrowsing.patch a bit of a mess.

The approach of these new changes is to remove as much of Safe Browsing as possible, so much so that the code doesn't even reference the safe_browsing namespace (in the C++ code). The idea is since Google's been the most progressive with Safe Browsing in Windows, stubbing out the code may not sufficient to create a stable and reliable browser (i.e. not only does it compile, it must also run with no crashes or data corruption).
safe_browsing_remaining_files.txt contains a list of files that may need modification in order to fulfill this goal (i.e. files that contain the strings safe_browsing or safebrowsing, case-insensitive). Maybe this idea is too progressive or maybe it won't be practical going forward; I'm not too sure at this point. What do you guys think?

Also, I was a bit overly aggressive when updating this patch, so some of these changes aren't necessary; notably changes that removed code guarded by the #if (FULL_SAFE_BROWSING) macro in C++, or if (safe_browsing_mode != 0) in GN (or some variant thereof). We also technically don't need to fix unittest or browsertest code since we aren't running tests, but we will eventually want to do this if we want to run unit tests on our changes in the future.

EDIT: There will probably be more issues that will need to be fixed during compiling, linking, and (unfortunately) runtime after finishing the changes here, unless we're really careful about these changes. Safe Browsing has become quite ingrained in the browser at this point.

AttributeError: 'NoneType' object has no attribute 'strip'

D:\ungoogled-chromium-windows>py build.py
Python 3.7.7
Traceback (most recent call last):
File "build.py", line 220, in
main()
File "build.py", line 134, in main
_test_python2(parser.error)
File "build.py", line 87, in _test_python2
result.stdout.strip()))
AttributeError: 'NoneType' object has no attribute 'strip'

Modern CPU instruction sets

I've noticed that RobRich builds include compile-time optimizations for modern CPUs. Considering that the time cost to include those optimizations in the build configuration is (nearly) frugal, is there any chance to include the same optimizations on this build?

I understand that optimizing for instructions sets can be a controversial move, but things like thinlto and polly are compatible with the llvm version used to build and shouldn't change much on the build process (longer compilation times, maybe?) so it would be interesting to hear consideration on this kind of optimizations.

HTMLparser module

ModuleNotFoundError: No module named 'HTMLParser'
[152/21839] CXX obj/base/base/base_jumbo_5.obj
ninja: build stopped: subcommand failed.

Not sure why am I getting this issue. HTMLParser is a python 2 module, but I guess it should work with python 3 with 2to3.
Did anyone have a same issue?

Problems with build on Windows 10 x64

1.AttributeError: 'NoneType' object has no attribute 'strip'(my python-2 version is 2.7.9)
D:\ungoogled-chromium-windows>py build.py
Python 3.6.8
Traceback (most recent call last):
File "build.py", line 210, in
main()
File "build.py", line 127, in main
_test_python2(parser.error)
File "build.py", line 86, in _test_python2
result.stdout.strip()))
AttributeError: 'NoneType' object has no attribute 'strip'
finally, i comment the method '_test_python2' line at 127 in build.py, so it will skip python-2 test.

2.next, i encounter this unknown problem!. so i need my guys help! thanks!!!
INFO: * Applying flag-fingerprinting-canvas-image-data-noise.patch (85/85)
patching file chrome/browser/about_flags.cc
patching file content/browser/renderer_host/render_process_host_impl.cc
patching file content/child/runtime_features.cc
patching file third_party/blink/public/platform/web_runtime_features.h
patching file third_party/blink/renderer/platform/BUILD.gn
patching file third_party/blink/renderer/platform/exported/web_runtime_features.cc
patching file third_party/blink/renderer/platform/graphics/image_data_buffer.cc
patching file third_party/blink/renderer/platform/graphics/static_bitmap_image.cc
patching file third_party/blink/renderer/platform/graphics/static_bitmap_image.h
patching file third_party/blink/renderer/platform/runtime_enabled_features.json5
INFO: * Applying chromium-skia-harmony.patch (1/16)
patching file third_party/skia/src/ports/SkFontHost_FreeType.cpp
INFO: * Applying fix-cfi-failures-with-unbundled-libxml.patch (2/16)
patching file third_party/blink/renderer/core/xml/parser/xml_document_parser.cc
Hunk #1 succeeded at 137 (offset -2 lines).
Hunk #2 succeeded at 156 (offset -2 lines).
Hunk #3 succeeded at 203 (offset -2 lines).
Hunk #4 succeeded at 279 (offset -2 lines).
patching file third_party/blink/renderer/core/xml/xsl_style_sheet_libxslt.cc
patching file third_party/blink/renderer/core/xml/xslt_extensions.cc
patching file third_party/blink/renderer/core/xml/xslt_processor_libxslt.cc
patching file third_party/blink/renderer/core/xml/xslt_unicode_sort.cc
patching file third_party/libxml/chromium/libxml_utils.cc
Hunk #1 FAILED at 23.
1 out of 1 hunk FAILED -- saving rejects to file third_party/libxml/chromium/libxml_utils.cc.rej
Traceback (most recent call last):
File "build.py", line 210, in
main()
File "build.py", line 175, in main
source_tree
File "D:\ungoogled-chromium-windows\ungoogled-chromium\utils\patches.py", line 54, in apply_patches
subprocess.run(cmd, check=True)
File "X:\zhouwenkun\Python36\lib\subprocess.py", line 438, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['D:\ungoogled-chromium-windows\build\src\third_party\git\usr\bin\patch.exe', '-p1', '--ignore-whitespace', '-i', 'D:\ungoogled-chromium-windows\patches\inox-patchset\fix-cfi-failures-with-unbundled-libxml.patch', '-d', 'D:\ungoogled-chromium-windows\build\src', '--no-backup-if-mismatch', '--forward']' returned non-zero exit status 1.

--disable-encryption on Ungoogled Chromium 85.0.4183.121-1.1 Windows does not work.

Every time there is no "os_crypt":{"encrypted_key":"%insert_base64_key_here"} in "user-data-dir\Local State", Ungoogled Chromium 85.0.4183.121-1.1 Windows will generate a random one
Despite --disable-encryption is passed to chrome.exe, new cookies and saved password values are still encrypted with said keys. Changing the key will render those encrypted data invalid, for example, when "user-data-dir\Local State", or when starting a fresh installation.

Error during build.py

error

I get this error during build.py and i have tried refreshing build\download_cache & build\src

Remove "Get image descriptions from Google" from context menu

Context menu with "Get image descriptions from Google", after right clicking on an about:blank page

Even if turned off in settings, (advanced > accessibility > get image desc) it still appears. Not sure if this should even be here, as it uses Google. Other than that, it's just a minor annoyance.

89.0.4389.114
Windows 10 OS Version 2009 (Build 19042.1110)

[Build problem] Build.py says no module downloads found

$ py build.py
Python 3.7.4
Traceback (most recent call last):
  File "build.py", line 220, in <module>
    main()
  File "build.py", line 134, in main
    _test_python2(parser.error)
  File "build.py", line 87, in _test_python2
    result.stdout.strip()))
AttributeError: 'NoneType' object has no attribute 'strip'


.

.

Cannot install extensions in CRX format with any method

Hey there. I'm running the last version 78.0.3904.87. the option chrome://flags/#extension-mime-request-handling is set to Always prompt for install. When you try to install a crx, it hangs to: adding to chromium. I've tried with manually download and install via drang and drop but nothing happens. Previous version worked good.

Long incremental build with no changes

Since version 86, once I start ninja build on already compiled build with no changes to source files, it starts building ~2000 actions.
It is mostly rebuilding //third_party/devtools-frontend/.
I'm sure that was not the case with previous versions.
macOS build works fine with ~200 actions on 87.

How to reproduce:
finish build.py
run third_party\\ninja\\ninja.exe -C out\\Default chrome chromedriver

Ungoogled Chromium Does Not Support WebGL

Hello there, I found an issue with Ungoogled Chromium where I tried to use a Website called StreamRaiders and upon entering a Match, the website showed an error that reads "Your browser does not support WebGL" as seen by the screenshot here:
chrome_oVQGmYWthJ

WindowsError: [Error 2] The system cannot find the file specified

git tag 85.0.4183.121-1.1

log

> "C:\Users\aaa\Python27\python.EXE" "tools\gn\bootstrap\bootstrap.py" "-o" "out\Default\gn.exe" "--skip-generate-buildfiles"
Traceback (most recent call last):
  File "tools\gn\bootstrap\bootstrap.py", line 143, in <module>
    sys.exit(main(sys.argv[1:]))
  File "tools\gn\bootstrap\bootstrap.py", line 129, in main
    [ninja_binary, '-C', gn_build_dir, '-w', 'dupbuild=err', 'gn.exe'])
  File "C:\Users\aaa\Python27\lib\subprocess.py", line 185, in check_call
    retcode = call(*popenargs, **kwargs)
  File "C:\Users\aaa\Python27\lib\subprocess.py", line 172, in call
    return Popen(*popenargs, **kwargs).wait()
  File "C:\Users\aaa\Python27\lib\subprocess.py", line 394, in __init__
    errread, errwrite)
  File "C:\Users\aaa\Python27\lib\subprocess.py", line 644, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

build.py Python versioncheck fails

Trying to run build.py fails
I have Python 3.7.4 for "All Users" installed under C:\Program Files\Python37
Env variable path starts with
Path=C:\Program Files\Python37\Scripts\;C:\Program Files\Python37\;[...]

Output is
D:\ungoogled-software\ungoogled-chromium-windows>py build.py Python 3.7.4 usage: build.py [-h] [--disable-ssl-verification] [--7z-path SEVENZ_PATH] build.py: error: Could not detect Python 3 version from output:

Cannot open include file: 'stddef.h': No such file or directory

VS2019 community
Windows 10 SDK 10.0.19041.0

fatal error C1083: Cannot open include file: 'stddef.h': No such file or directory
fatal error C1083: Cannot open include file: 'crtdbg.h': No such file or directory
fatal error C1083: Cannot open include file: 'stdio.h': No such file or directory

What is the problem?

Automating the process

Is it possible to automate the process? If yes, Then:

  1. How do I precede with it.
  2. What skill set do i need.
  3. Where can I learn how to do so.

I am asking because someone told me that the process is really simple and not really hard, but time consuming.
Well, time is all I have.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.