uniomni / pyarr

Python code to implement the Australian Rainfall and Runoff algorithms

PyARR

Python code to post process ANUGA sww files for Australian Rainfall and Runoff 2019 data

Petar Milevski and Ole Nielsen 2021

pyarr's Issues

Make root directory a command line argument

Currently, the data directory is specified in the config file.
That makes it hard to reproduce runs on different setups.

It should be possible to specify it on the command line but maybe keep it in there as a default.

Gracefully deal with clobbering of directories

Currently, the script 1_sww2maxTIF.py reruns from scratch every time. This is time consuming.

It would be better to have it compute only those files that need to and leave existing results be.
If a rerun is needed, the procedure should be to delete all output files (see Issue #2) and then rerun.

Create new directory for post processing data

Currently post processing data is stored with the raw input data making it difficult to clean out and rerun.
Suggest making a new director for post processing data which can easily be deleted without affecting the raw input data.

Better error message when script 2 runs out of data

('data_directory', '/home/petar/media/petar/TOSHIBA EXT/PyARR-data/1%AEP/')
('proc_directory', '/home/petar/media/petar/TOSHIBA
EXT/PyARR-postprocessed-data/1%AEP/')
Postprocessing storm 1 for quantity WL at all specified locations
Traceback (most recent call last):
File "2_critical_duration_patterns.py", line 17, in
points_dict = post_process(durations=durations, locations=locations,
storm=storm, quantity=quantity, proc_directory=proc_directory,
blockage=blockage)
File "/home/petar/PyARR/ARR2019_post_processing.py", line 198, in
post_process
points_dict = critical_duration_pattern(fromdir, locations)
File "/home/petar/PyARR/ARR2019_post_processing.py", line 142, in
critical_duration_pattern
mean, (one_up_filename, value) = find_average_element(filename_list)
File "/home/petar/PyARR/ARR2019_post_processing.py", line 68, in
find_average_element
raise BaseException('Got an empty list: %s' % filename_list)
BaseException: Got an empty list: []

Make generic run-scripts

There are lots of runscripts that are almost identical. Work on a more data driven approach.
Also, the config file in this project should be split up into two:

One which is about real configuration - i.e. things that don't change often such as MyTimeStep or Cellsize or quantities.
Another one which is 'per run' and 'per user'