GithubHelp home page GithubHelp logo

Comments (4)

bmesuere avatar bmesuere commented on June 27, 2024

Should we add an alias and mark the old name as deprecated as a first step? Because otherwise this will break for existing users.

from unipept-visualizations.

pverscha avatar pverscha commented on June 27, 2024

Good point, I'll update it as you suggested :)

from unipept-visualizations.

pverscha avatar pverscha commented on June 27, 2024

After some more investigating, I found out that all settings related to color behave identically to how they behaved in version 1 of the visualizations, except for one: nodeFillColor.

Setting nodeFillColor to (d) => "#00FF00" results to this in v1.0 of the treeview:
image

And has no effect in v2.0:
image

This is due to the fact that no fill is set for the nodes in v2.0, which we should fix. I propose that we do not rename the option and that I fix the nodeFillColor setting. All behaviour will then be identical to v1.0

from unipept-visualizations.

pverscha avatar pverscha commented on June 27, 2024

Fixed in #68.

from unipept-visualizations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.