uniswap / swap-router-contracts Goto Github PK

1. In some cases, excess dust is left after the swap portion of the swap+add
2. Noah will make the changes today/tomorrow
3. Review w/moody and try to share address EOD Tuesday before Thursday launch

Did SwapRouter02 deploy in Optimism goerli testnet?

contracts/swap-router-contracts/contracts/base/PeripheryPaymentsExtended.sol:12:9: DeclarationError: Undeclared identifier. "unwrapWETH9" is not (or not yet) visible at this point.
unwrapWETH9(amountMinimum, msg.sender);
^---------^

contracts/swap-router-contracts/contracts/base/PeripheryPaymentsExtended.sol:22:9: DeclarationError: Undeclared identifier. "sweepToken" is not (or not yet) visible at this point.
sweepToken(token, amountMinimum, msg.sender);
^--------^
Can anyone help?

Thank you!

The repository is not compatible to integrate with newer versions of the solidity.
for instance, swap-router-contracts/contracts/interfaces/ISwapRouter02.sol interface includes interface IApproveAndCall has locked compiler version to =0.7.6.

A third party contract with new solidity compiler that wants to integrate ISwapRouter interface will give compile error.
Error (5333): Source file requires different compiler version

closing, as we're not going to consider supporting this

• support swapping against uniswap v2
• support flashbots via additional #ethBribe method [a la SwapBriber] no longer 'riskless' due to eip 1559 (https://github.com/ScopeLift/zeneth/blob/main/contracts/contracts/SwapBriber.sol)
• allow using address 0 to represent msg.sender for swaps, in order to make calldata more portable
• optional deadline validation

--

• allow calling into the nft manager post-swap, e.g. to add as much liquidity as possible
• allow calling into a swap and add liquidity contract post-swap, e.g. to add the full balance of two tokens after multiple swaps (swap from unrelated token and add liquidity)

--

• maybe support weiroll style calls via delegatecall for the above workflows

not a bug or feature request, just a question, namely: what is the problem that swap-router-contracts is solving compared to uniswap's already existing routers?

is it to provide a more convenient and possibly unified API?
is it to provide a more concise API, that is only concerned with swapping (and not liquidity providing)?
is it to safe gas, or solve some other technical issues with pure routers?

thanks in advance for any infos!

support flashbots via additional #ethBribe method [a la SwapBriber] no longer 'riskless' due to eip 1559 (https://github.com/ScopeLift/zeneth/blob/main/contracts/contracts/SwapBriber.sol)

#50

p1

• ApproveAndCall for tokens that require ApprovalType.MAX_MINUS_ONE-style approves
• PeripheryPaymentsExtended
• PeripheryPaymentsWithFeeExtended
• every slippage check
• fee-on-transfer token swaps

since they're closely related to swapping, we should probably make this repo the official source for the quoter contracts

makes calldata more portable

We could consider allowing splitting/merging of trades (examples below). tagging as wontfix until a compelling design for this feature is proposed.

merging:

50% ETH → WBTC ↘
50% ETH → USDC → DAI → USDT

splitting:

100% ETH → USDC → DAI → USDT (.3%)
                      ↘ USDT (.05%)

https://security.snyk.io/package/npm/@openzeppelin%2Fcontracts

https://security.snyk.io/vuln/SNYK-JS-OPENZEPPELINCONTRACTS-1570170

recipient, hasAlreadyPaid, sqrtPriceLimitX96, and path vs tokenIn/fee/tokenOut are all prime candidates for optional overloads, but the number of permutations is fairly overwhelming

this way calls we always want to succeed (like the first add liquidity for a pool) don't need to fail or can fail fast

also removes duplicate deadline checks

this is only on exact input but not exact output

i think it's because it's for split/merge and that doesn't work with this pattern for exact output but would be good to document the thoughts there

Is the MixedRouteQuoter deployed? If so, what are the deployment addresses? I couldn't find anything on it.

https://github.com/dethcrypto/TypeChain/blob/4d628968281f8404d4d49a75d5518ae15b7b3545/packages/hardhat/src/index.ts#L65

we should probably start at 1 for our dummy values, to avoid overloading the default value case

What is the address of SwapRouter02 on avax?

Hello
Implement token ERC223 for swap and liquidity pools please
Bounty : 5000 SaTT
Thanks

The following contracts require the relevant functions to be marked public instead of external so that we can inherit from/extend the periphery contracts rather than re-implement

• Multicall
• PeripheryPayments
• PeripheryPaymentsWithFee