unshiftio / requests Goto Github PK

Hello. Something that would make this library more approachable would be some improved documentation. In particular, although the events are enumerated, there is no description of what is passed to event handlers. This is also confusing:

The API is a mix between the Fetch API, mixed with EventEmitter API for the event handling.

It's not clear if this means that the Promise-based interface of the fetch API is available to use in addition to the documented API or if it's just the API as documented that can be used.

When I first ran the tests, two failed. It took me a minute to figure out the reason -- I was already running something at localhost:8080. Could you use a package like freeport to handle this issue?

The devDependency browserify was updated from 16.3.0 to 16.4.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

browserify is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Chrome now supports ReadableByteStream for more efficient streaming of chunked-transfer encoded responses. If you'd like to use it in this library, here's an implementation that could serve as a starting point.

Version 14.2.0 of browserify just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As browserify is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

the title says everything, I need something to somehow use DNS Server like Cloudflare 1.1.1.1 to make requests because the website only works with it, any idea how? Thanks

Was reading the code and it doesn't look like this exists. Not a huge problem, just trying to understand if this is even possible in the browser. My gut tells me not since it would bypass the security settings of the browser itself if users had not made the security exception themselves beforehand.

I'm curious to known how this happen on the module, someone can help?

There is also a bug in firefox that will default content to an xmldocument if there is no content and no content type specified which will throw an exception when parsed.

https://bugzilla.mozilla.org/show_bug.cgi?id=521301

This works for me to get around the problem, but can certainly be improved upon (line 86 of browser.js):

var chunk = data.documentElement 
? (!window.JSON ? '' : JSON.stringify(data)) 
: data.slice(requests.offset);

npm test is not passing for the master branch of this repository. I have run this with node v4 and v6.

$ npm test

> [email protected] test /Users/me/Code/requests
> node test/index.js



  requests
    ✓ is exported as function


  1 passing (8ms)

# phantomjs:


  requests
    ✓ is exported as function
    ✓ increments the internal `.id` for each instance
    ✓ sets the stream's booleans
    ✓ stores active requests
    ✓ does not receive content for 204 requests
    1) can handle large files with streaming
Error: I should never be called
      at test/requests.browser.js:64
      at node_modules/eventemitter3/index.js:150
      at browser.js:89
      at node_modules/eventemitter3/index.js:151
      at node_modules/loads/index.js:112
    2) does not receive content for 204 requests
    3) "after each" hook
    Requested
      ✓ is exported as a function
      #typeof

  6 passing (2s)
  3 failing

  1) requests can handle large files with streaming:
     Uncaught Error: I should never be called (http://localhost:50749/js/bundle:6735)
  

  2) requests does not receive content for 204 requests:
     done() called multiple times
  

  3) requests "after each" hook:
     Uncaught Error: Unknown assertation failure occured, assumed 0 to be greater than 1 (http://localhost:50749/js/bundle:1178)
  



    ✓ knows the difference between an array and object
    4) "after each" hook for "knows the difference between an array and object"


  7 passing (2s)
  4 failing

  1) requests can handle large files with streaming:
     Uncaught Error: I should never be called (http://localhost:50749/js/bundle:6735)
  

  2) requests does not receive content for 204 requests:
     done() called multiple times
  

  3) requests "after each" hook:
     Uncaught Error: Unknown assertation failure occured, assumed 0 to be greater than 1 (http://localhost:50749/js/bundle:1178)
  

  4)  "after each" hook for "knows the difference between an array and object":
     undefined is not an object (evaluating 'fn.call')



Error: Exit 1

Hey, just had a look at the source and saw this: https://github.com/unshiftio/requests/blob/master/browser.js#L106

Just a heads up if it's misspelled :)