untemps / read-per-minute

Class to parse a string and return an estimated reading time based on a lang rate

Vincent Le Badezet

Paris®

Standalone front-end developer

since 2003

:link :link

read-per-minute's Issues

ReadPerMinute.parse returns 1 for time and words if content is null or empty

ReadPerMinute.parse function returns {time: 1, words: 1} if the string passed in is null or empty so far.
We'd like the values to be 0 in this case.

Feature Request: Override rate values

To extend @webJose's work in this PR, it can be useful to add the ability to override the default rate values for a particular instance.

In this case, we either add an argument in the constructor, or we add a setRates method (and a reset one), or both.

We should be careful with the type and the format of the constructor or method argument, especially the default value management (e.g. the default value does not exist among the custom values).

CAUTION: This will result in a breaking change. To check the existence of the lang set, we need to make the isLangExist dynamic

Upgrade node version in actions

When running GitHub Actions displays a warning message :

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

We should fix it.