GithubHelp home page GithubHelp logo

docs's Issues

Rename TOTP section

The current title, "Time-Based One-Time Password (TOTP)", is getting truncated in the navigation sidebar:

Screenshot 2019-03-11 at 16 51 22

Could we come up with a shorter title that won't get truncated?

API sandbox

Is there a plan to add a sandbox API, or tokens, to make it possible to commit a transaction without loosing money to the transaction fees, for testing purposes?

Update `X-RateLimit-*` mentions

The documentation should be updated to highlight the fact that X-RateLimit-* headers will be renamed, and all the older names' occurrences should be replaced accordingly.

How can I athenticate by client credentials flow in Sandbox env?

Recently I tried to authenticate using my sandbox business user by client credentials flow. I did the following request

curl -X POST https://api-sandbox.uphold.com/oauth2/token \
>   -H "Content-Type: application/x-www-form-urlencoded" \
>   -u <client-id>:<client-secret> \
>   -d 'grant_type=client_credentials'

But I receive as response

{"error":"unauthorized_client"}

Could anyone please help me with this? Thanks!

Error response for transactions is different?

Most errors responses I see from the API are in this format:

{"code":401,"error":"invalid_token","error_description":"The access token provided is invalid."}

However, I just noticed that when attempting to create an invalid transaction, I get an error of a different format:

# Note that I used a wrong value for the destination field

curl "https://api.bitreserve.org/v0/me/cards/OMITTED_CARD_ID/transactions" \
  -X POST \
  -H "Authorization: Bearer OMITTED_TOKEN" \
  -d "denomination[currency]=BTC&denomination[amount]=0&destination=this_email_does_exist"

{"code":"validation_failed","errors":{"destination":[{"code":"invalid","message":"This value is not valid"}]}

Is this intendend?

Card settings vs position

The documents state that a card entity has a position attribute. But instead, the current JSON I'm getting has a settings attribute, which in turn has position and starred

Which one of these is the correct one?

Expose all tickers

Right now just some of the tickers are available for public consumption. It would be nice to get all of the combinations, especially when asking for the ticker to a specific currency.

Any plans for this?

Thanks.

Issue creating a PAT token

Hey, apologies if this is a stupid question, I wanted to script some trades with my Uphold account, as I'm not a corporate partner, PAT tokens seemed to be the best fit. However, in order to create a PAT token, you seem to need a normal Bearer token. However, I can't see how to get a Bearer token, unless you register an app, which I thought was for the corporate partners etc? I can see you used to be able to use your username and password to create a PAT token but it was removed?

Get Card Details by bitcoin address

It seems this endpoint accepts not only a card id, but also a bitcoin address id. I tested it with the following values:

  • 1LbHhVFjLeC3hVhW4FXrwu7MNUCkoGTwA5
  • 2daa59e8-89c5-4cbe-99fc-f66435024bcf

And for both of them I get the same result:

@address={"bitcoin"=>"1LbHhVFjLeC3hVhW4FXrwu7MNUCkoGTwA5"},
 @addresses=[{"id"=>"1LbHhVFjLeC3hVhW4FXrwu7MNUCkoGTwA5", "network"=>"bitcoin"}],
 @available="0.001",
 @balance="0.001",
 @currency="XAU",
 @id="2daa59e8-89c5-4cbe-99fc-f66435024bcf",
 @label="XAU card",
 @last_transaction_at="2014-12-02T00:29:45.507Z",
 @position=7>

I realize this is probably intended, but shouldn't it be documented as well?

Public Transactions API

The returned information for transactions doesn't match the entity description. And even between different methods for getting transaction(s), the values are slightly different

  • List Card Transactions Doesn't have type
  • Get All Transactions (Public) has a quotedAt which I don't see documented anywhere (what is it?) and doesn't have type
  • Get Transaction (Public) I would assume it returned the same values as the one above, but it doesn't look like it, from the docs

There are possibly other cases I didn't check (like Create Transaction)
I also didn't check if the actual returned JSON has the same inconsistencies. This was just by looking at the docs

I also understand that some of these values might not make sense under the context of certain endpoints, which is OK, but it doesn't look like that's the case for all of them

how to change all the money in a card.

Each time i'm trying to transfert all the money from a single card i have got this error : denomination: validation_failed probably because the value has changed after my last check.

How can i transfert all the money from a single card ?

Thanks for your time !

Status page

It would be nice to have a public status page for the API.

Improve error documentation

The current error documentation could be improved by stating the actual object structure of the errors, as well as clearly stating the reasoning and distinction between the OAuth errors and the application errors.

Refs #38.

Add `normalized` to cards

Card-related endpoints now contain a normalized key that contains the available and balance in every supported currency.

Oauth endpoint

The endpoint for getting a token is /oauth2/tokens, making it the only one without the version prefix.

Is there a way to make it work with the version, or is it really an edge case and no way around it?

Update `X-Uphold-Request-Id` mentions

The documentation should be updated to highlight the fact that the X-Uphold-Request-Id header will be renamed, and all the older name occurrences should be replaced accordingly.

Add section for advance warning on breaking changes

It would be useful to add a section to the developer docs that states the official policy on advance warning for breaking changes. (is it one week? two weeks?)

Also, how will this process happen? Will the changes be fully documented a week before they are deployed?

help getting started

Apologies for asking such a basic question, but by following the docs I'm just going round and round in circles.

How do you create an API key?

I'm not writing an application for the public, I just need to use the API.

Missing Currency Filter

The /me/cards endpoint supports filtering by currency but that is not reflected on the Doc.

Here is an example of the filter:

GET /v0/me/cards?q=currency:BAT

The documentation should be updated with all the fields that are supported for filtering.

Update `X-Bitreserve-OTP-*` mentions

The documentation should be updated to highlight the fact that X-Bitreserve-OTP-* headers will be renamed, and all the older names' occurrences should be replaced accordingly.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.