uportal-project / announcementsportlet Goto Github PK

With some high-usage scenarios (Announcements backing alerts and notices) performance is important. Adding a short cache in front of the announcement collection process would help.

We are moving to support at least jQuery 1.12 in uPortal 5. There are Announcement JSPs that import jQuery 1.11 and other old libraries. These JSPs should be updated to use the current version or rely on uPortal to import the correct version.

Benito,

The DBA’s indicate, this is the SQL associated with these lingering database connections:

c6336hwdk1vv2
delete from ANNOUNCEMENT where END_DISPLAY<:1

Just stating the obvious, if we have 10 servers in the pool, and we do not bounce the servers for 2 months, 60 days, that is 600 lingering/unused uPortal database connections.

Any ideas what process may be auto-scheduled to execute such a query at 3 am?

Thanks,
Steven

https://www.w3schools.com/xml/rss_tag_enclosure.asp

Type Attribute

Required. Defines the type of media file

Logging has been configured with logback.xml, but the related slf4j bridge is missing.

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined

For rendering images in the web components carousel, enclosures need to support various image formats. Currently PNG is missing. This is a shortcoming with Java's default. (PNG is added in Java 9.)

https://github.com/Jasig/AnnouncementsPortlet/blob/master/src/main/java/org/jasig/portlet/announcements/mvc/servlet/RssFeedController.java#L234

Replace fileTypeMap with Spring's ConfigurableMimeFileTypeMap and add png entry.

Having the Title of Topic & Announcement set to text in Hibernate is causing issues with Oracle. This should be changed to string as it is an INPUT on the add/edit forms whereas Description is 'text' and is a TEXTAREA on the forms.

Describe the bug
When attempting to delete an announcement, the user is greeted with the following message

HTTP Status 405 - Request method 'GET' not supported

To Reproduce
Steps to reproduce the behavior:

1. Create create announcement
2. Attempt to delete announcement

Expected behavior
The announcement being deleted

We should provide the documentation into the project and move from the wiki https://wiki.jasig.org/display/PLT/Announcements+Portlet

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• fix(deps): update dependency org.projectlombok:lombok to v1.18.34
• fix(deps): update slf4j monorepo to v2.0.16 (org.slf4j:jcl-over-slf4j, org.slf4j:log4j-over-slf4j, org.slf4j:jul-to-slf4j, org.slf4j:slf4j-api)
• chore(deps): update dependency org.apache.maven.plugins:maven-checkstyle-plugin to v3.4.0
• chore(deps): update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.8.0
• fix(deps): update dependency com.fasterxml.jackson.core:jackson-databind to v2.17.2
• fix(deps): update dependency com.rometools:rome to v1.19.0
• fix(deps): update dependency org.jasig.portal:uportal-spring to v5.16.1
• fix(deps): update dependency org.springframework.data:spring-data-releasetrain to v1.4.6.release
• chore(deps): update actions/checkout action to v4
• chore(deps): update actions/setup-java action to v4
• chore(deps): update dependency org.apache.maven.plugins:maven-release-plugin to v3
• chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3
• chore(deps): update dependency org.apache.maven.scm:maven-scm-api to v2
• chore(deps): update dependency org.apache.maven.scm:maven-scm-provider-gitexe to v2
• fix(deps): update dependency com.rometools:rome to v2
• fix(deps): update dependency com.sun.xml.bind:jaxb-impl to v4
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update dependency ch.qos.logback:logback-classic to v1.3.12 [security]
• fix(deps): update dependency org.hsqldb:hsqldb to v2.7.1 [security]
• fix(deps): update dependency com.fasterxml.jackson.core:jackson-core to v2.17.2
• fix(deps): update dependency com.sun.xml.bind:jaxb-impl to v2.3.9
• fix(deps): update resource-server.version to v1.5.0 (org.jasig.resourceserver:resource-server-utils, org.jasig.resourceserver:resource-server-content)
• chore(deps): update dependency javax.portlet:portlet-api to v3
• chore(deps): update dependency javax.servlet:javax.servlet-api to v4
• chore(deps): update dependency org.codehaus.mojo:jaxb2-maven-plugin to v3
• fix(deps): update dependency org.hibernate:hibernate-core to v6
• fix(deps): update dependency org.jasig.portlet.notification:notification-portlet-api to v4
• fix(deps): update dependency org.springframework:spring-framework-bom to v6
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Describe the bug
When a topic is not given a description and the "Offer Public RSS" checkbox is checked, the feed URL results in a 500 error

To Reproduce
Steps to reproduce the behavior:

1. Add a new topic without a description and check the "Offer Public RSS" checkbox
2. Go to the user-facing interface and click the RSS icon for the topic created in step 1

Expected behavior
An RSS feed

Stacktrace
No stacktrace, but you'll see the following in the log (Campus Spotlight was the topic in question at our institution)

WARN [http-apr-4443-exec-9] servlet.RssFeedController.[] 2018-08-28 11:44:09,458 - Failed to create SyndFeedOutput for topic 'Campus Spotlight'

Remove JASIG repo reference that has been taken down.

https://github.com/Jasig/AnnouncementsPortlet/blob/master/pom.xml#L81

References may need to be updated.

With security restrictions, GETs with action URLs are now prevented. Removing users from assigned roles still uses an anchor and needs to be rewritten to use a POST form.

Added two different literal users as editors fails. The first addition works; however, the second fails.

When there are no alerts or messages, the resource endpoints, 'emergencies' and 'announcements', return an empty string. This should be an empty JSON array.