upsight / dinghy Goto Github PK

I am experimenting with dinghy using 3 nodes each in their own container. I noticed that when I shutdown 2 of the nodes the remaining node becomes the leader. This would mean, i think, that if there was a network issue such that the node "a" was cut off from nodes "b" and "c", then node "a" would become a leader and "b" and "c" would elect a leader as well.

This was different from my assumption in that I expected that in the case where a consensus could not be reached no leader would be elected. Is my assumption just incorrect for this implementation?

It looks like the errors returned by OnFollower and OnLeader are just logged, is that the intended behavior?

I feel like if OnLeader returns an error, the node should StepDown, not sure what a OnFollower error should do though.

If you agree w/ that change, for symmetry how do you feel about adding an OnCandidate that if it returns a non-nil error, just goes back to being a Follower instead of trying to initiate an election for itself?