uraneptus / sullys-mod Goto Github PK

https://gist.github.com/BugmanBugman/8e41e3ec2ceda4de00675074c929a455

Jade ore doesn’t generate. Could possibly I’m getting super duper unlucky, but I cannot seem to find any jade at all. I was definitely in a jungle too I think

also, there’s no recipe for smwlting raw jade to actual jade

This basically, perhaps caused by BlueprintRenderTypes#getUnshadedCutoutEntity

I download the mod I have any jade blocks but not more, Fix this please.

sully's keeps crashing me when exploring after a while and the crash is described as "feature placement". judging by the other mod issue with the bouldering zombie spawner, I feel it may be that at fault. that one looks similar.

Uploading crash-2024-06-21_21.59.04-server.txt…

crash-2024-04-20_22.47.52-server.txt

I find in mod animation files: copper golem json, but in game he not have animations.

Lanternfish can sometimes spawn in flowing water.
Extra information:
In vanilla only salmon can spawn in flowing water, according to sully.
I'm putting this here because I always forget about this bug.

Having a jade shield in your offhand and scrolling to equip a two-handed weapon with Better Combat causes insanely fast attack speed.
The attack speed returns to normal after scrolling away from the weapon, and pressing F to unequip the shield.
However, with what I believe is from Quark, pressing F on an empty slot in the inventory to unequip the shield causes the attack speed to remain super fast as long as you don't scroll away from the weapon.

Right now, flinger can only face one of four cardinal directions. It would allow for a lot more freedom to control projectiles if they were able to face up and down.

You can right click with modded blocks and their polished version will be made
Mods that could have this functionality would include:
Quark
Unearthed
Unusual End
Abundant Atmosphere
Twigs
Regions Unexplored
Darker Depths
Architect's Palette
Enlightend
Stoneworks
Sculpt
NotEnoughBlocks

Alternative solution:
Possibly use a script to automatically recognize these types of blocks

I get disconnected when trying to join the server

I don't have any custom recipes
Do the fallbacks in the fromJson also properly apply to the fromNetwork (I don't know how recipes work in that regard)?
(Since the recipes you provide are missing some of the fields it would try to read here)

[28Sep2023 07:55:42.739] [Netty Play IO Thread #3/ERROR] [com.mrbysco.spititout.SpitItOut/]: Exception caught in connection handler!
 io.netty.handler.codec.EncoderException: java.io.UTFDataFormatException: malformed input around byte 2
	at TRANSFORMER/[email protected]/net.minecraft.network.FriendlyByteBuf.m_130081_(FriendlyByteBuf.java:514)
	at TRANSFORMER/[email protected]/net.minecraft.network.FriendlyByteBuf.m_130260_(FriendlyByteBuf.java:494)
	at TRANSFORMER/[email protected]/net.minecraft.network.FriendlyByteBuf.m_130267_(FriendlyByteBuf.java:554)
	at TRANSFORMER/[email protected]/com.uraneptus.sullysmod.common.recipes.GrindstonePolishingRecipe$Serializer.fromNetwork(GrindstonePolishingRecipe.java:148)
	at TRANSFORMER/[email protected]/com.uraneptus.sullysmod.common.recipes.GrindstonePolishingRecipe$Serializer.m_8005_(GrindstonePolishingRecipe.java:106)
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ClientboundUpdateRecipesPacket.m_133647_(ClientboundUpdateRecipesPacket.java:45)
	at TRANSFORMER/[email protected]/net.minecraft.network.FriendlyByteBuf.m_236838_(FriendlyByteBuf.java:152)
	at TRANSFORMER/[email protected]/net.minecraft.network.FriendlyByteBuf.m_236845_(FriendlyByteBuf.java:168)
	at TRANSFORMER/[email protected]/net.minecraft.network.protocol.game.ClientboundUpdateRecipesPacket.<init>(ClientboundUpdateRecipesPacket.java:22)
	at TRANSFORMER/[email protected]/net.minecraft.network.ConnectionProtocol$PacketSet.m_178327_(ConnectionProtocol.java:433)
	at TRANSFORMER/[email protected]/net.minecraft.network.ConnectionProtocol.m_178321_(ConnectionProtocol.java:485)
	at TRANSFORMER/[email protected]/net.minecraft.network.PacketDecoder.decode(PacketDecoder.java:32)
	at MC-BOOTSTRAP/[email protected]/io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:510)
	at MC-BOOTSTRAP/[email protected]/io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:449)
	at MC-BOOTSTRAP/[email protected]/io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at MC-BOOTSTRAP/[email protected]/io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
	at MC-BOOTSTRAP/[email protected]/io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:299)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at MC-BOOTSTRAP/[email protected]/io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
	at MC-BOOTSTRAP/[email protected]/io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:299)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at MC-BOOTSTRAP/[email protected]/io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at MC-BOOTSTRAP/[email protected]/io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
	at MC-BOOTSTRAP/[email protected]/io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
	at MC-BOOTSTRAP/[email protected]/io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
	at MC-BOOTSTRAP/[email protected]/io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at MC-BOOTSTRAP/[email protected]/io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.io.UTFDataFormatException: malformed input around byte 2
	at java.base/java.io.DataInputStream.readUTF(Unknown Source)
	at MC-BOOTSTRAP/[email protected]/io.netty.buffer.ByteBufInputStream.readUTF(ByteBufInputStream.java:301)
	at TRANSFORMER/[email protected]/net.minecraft.nbt.NbtIo.m_128930_(NbtIo.java:275)
	at TRANSFORMER/[email protected]/net.minecraft.nbt.NbtIo.m_128934_(NbtIo.java:225)
	at TRANSFORMER/[email protected]/net.minecraft.network.FriendlyByteBuf.m_130081_(FriendlyByteBuf.java:512)
	... 48 more

Tried to throw bomb from Supplementaries and it worked fine, however when I did it again from other directions it just almost always getting stuck.

This happens when I throwing bombs in:
Direction of south
Direction of east
Upwards

Hey. Not to be stupid but, is the Chameleon coded in yet?

Just curious of things, that's all.

Latest log https://pastebin.com/ft6itMfH

cant right click to push the tortoise shell on blue ice

Hey! I was hoping to add some extra recipes to Valhelsia 5 that make use of the Grindstone Polishing mechanic, but it would cut down significantly on the number of recipes if ingredients could be tags, not just limited to item IDs.

Example use case: Biomes o' Plenty and Create both add Rose Quartz. If they both have the same tag (such as forge:gems/rose_quartz) then only one recipe would be needed to allow for both to be polished into Create's Polished Rose Quartz.

Here a null check is missing, which leads to a NullPointerException.

Also, I don't think it's appropriate to store an entity in the class, which would prevent the game from releasing memory. The default implementation is fast enough.

The lanternfish is spawning in my world in almost every area that can fit water.
Latest seen in a frozen ocean biome. Freshly opened world with no cave entrances nearby.

^ this screenshot is taken in a single-biome deep dark world using sully's mod 3.1.1, but the same issue happens in a regular world (and they spawn a LOT)

no mods were installed except sully's, blueprint 7.0.0 & geckolib 4.3.1 (and forge 47.2.0)

We're filing an issue for sully's peeves considering this is an actual tracker and the respack is ARR. Soz. Bother sully for me thanks.

Vanila:

Sully's Peeves:

shown in fabric 1.20.1

Firing an arrow to a jade block causes the server to crash on impact. Seems to be related with ProjectileImpactEvent
I haven't tested if there is a specific version of neoforge where it works

debug-2.log

In vanilla, all the ores have a smelting recipe to be made into their respective ingot/gem. But Jade Ore does not.

This suggestion is based on this conversation: Link
Basically if two polishing recipes have the same input item but different outputs, it is unclear which result item should be used.
Two solve that, a system to select one item from a list of possible results, could work. This idea is inspired by the Polymorph mod!
I have tested this system to some extend in a private repo, however this is not the current focus of the team. Whether or not and how such a system is to be implemented is yet to decide.

What currently happens if you polish an item that has several outputs in different recipes, is that the player gets all possible result items and two items are removed from the player's hand. (doesn't work like this when shift clicking)

Alternatives to the selection system could be:

• How it currently works
• Randomly selects one of the possible results

Upon attempting to join server,

Internal Exception: io.netty.handler.codec.DecoderException:
io.netty.handler.codec.EncoderException: java.io.UTFDataFormatException:
malformed input around byte 2

Log:
latest (1).log

sully's keeps crashing me when exploring after a while and the crash is described as "feature placement". judging by the other mod issue with the bouldering zombie spawner, I feel it may be that at fault. that one looks similar.

Uploading crash-2024-06-21_21.59.04-server.txt…

For some reason, smoothed rough jade stairs aren't showing up in JEI.

JEI : 15.3.0.4
Sullysmod : 3.1.2-beta
Forge : 47.2.20
Minecraft : 1.20.1

I set "Jade generates naturally" to false, but it still generates.

sullysmod-1.1.4-beta for 1.18.2

https://github.com/Uraneptus/Sullys-Mod/blob/1.19.x/src/main/java/com/uraneptus/sullysmod/core/events/SMPlayerEvents.java#L79
This seems to be causing this.

Hi there,

Adding Sullys Mod to a pre-existing world (with no other new mods or datapacks) caused "Errors in currently selected datapacks prevented the world from loading." Attempting to load in safe mode says the world is corrupted.

When trying to create a new world with Sullys installed, the screen hangs indefinitely on "preparing for world generation."

Removing Sullys (and Blueprint) allows the 'corrupted' world to load normally, and also allows for new world generation.

I have attached the latest crash log below.

2024-03-03-7[1].log

Details:
Minecraft 1.20.1
Forge-47.2.20
Sullys 3.1.2-beta
Blueprint 1.20.1-7.0.1.jar

Happy to provide any other details as needed.

https://pastebin.com/YqaZjR0C
↑Crash Log