GithubHelp home page GithubHelp logo

orderly's People

Contributors

admad avatar jadb avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

orderly's Issues

Callback seems to be ignored in some cases

Hi there

I am trying to make the Callbacks work, but they seem to be ignored in some cases.

Here's my code:

$this->addBehavior('Muffin/Orderly.Orderly', [
            'order' => [$this->aliasField('Users.first_name') => 'ASC'],
            // Callback checks if Users table is contained, as that is the only case where the Ordering makes sense.
            'callback' => function (\Cake\ORM\Query $query, \ArrayObject $options, $primary) {
                if(empty($query->getContain())) {
                    return false;
                }

                return true;
            }
        ]);

The callback is always ignored, even if I only return false.

I suspect that the following bit of code is the culprit.
OrderlyBehavior.php line 40-46:

if ((!empty($config['callback'])
                    && call_user_func_array($config['callback'], $args)
                ) || !$query->clause('order')
            ) {
                $query->order($config['order']);
                break;
            }

Specifically, I notice that if there's no order clause provided, it will always add the order, no matter the return value of the callback.

I may very well be wrong though!
Can someone shed some light on this? Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.