GithubHelp home page GithubHelp logo

Comments (5)

MarkSonghurst avatar MarkSonghurst commented on July 19, 2024 1

@cpick If you want I can submit my files as a PR. It's your code though so I don't want to take the glory ;-)

from go-onfido.

MarkSonghurst avatar MarkSonghurst commented on July 19, 2024

@cpick Many thanks for your work, I need to list webhooks so I copied your diff into my own fork and also added unit tests.
I made some minor changes to suit my Go coding style, such as creating a new source file for your code.
It's all cosmetic stuff.
I've since abandoned making PRs into this parent fork, but if you want my changes you can find them here:
https://github.com/MarkSonghurst/go-onfido/blob/webhook/webhookref.go
https://github.com/MarkSonghurst/go-onfido/blob/webhook/webhookref_test.go

Thanks again, you saved me a days work :-)

from go-onfido.

SpeedyCoder avatar SpeedyCoder commented on July 19, 2024

@cpick this looks good, we would be happy to add it to this repo. I can't think of any better name than WebhookRef . Though I would prefer to have things in separate files like @MarkSonghurst did on his branch, as interacting with the webhook api and parsing webhook calls are two quite different things.

Sorry for being super slow to respond, I was busy with other stuff and forgot about the PRs and issues on this repo 😅 I have now cleaned up most of the pending PRs and I will try to be more responsive from now on.

from go-onfido.

cpick avatar cpick commented on July 19, 2024

@MarkSonghurst that would be great, please do!

from go-onfido.

SpeedyCoder avatar SpeedyCoder commented on July 19, 2024

This was added in #25

from go-onfido.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.