Concurrency Question about go-onfido

[SpeedyCoder]

Hi Mark

The client uses an instance of the following interface to call the api

type HTTPRequester interface {
	Do(*http.Request) (*http.Response, error)
}

If you use one of the provided constructors, then it will use http.DefaultClient, which is safe for concurrent use (check the docs for more info) and therefore the onfido.Client is as well (technically this is only true if you don't change the fields of the struct after initialisation, but that's the responsibility of the user). This is also the case if you use an instance of the http.Client (you might want to do this to specify timeout for example). In case you use your own implementation of the onfido.HTTPRequester interface, you need to make sure that it's safe for concurrent use.

I don't think that we have considered contacting Onfido folks to list this library in their docs, but we might do that after using the library a little longer.

[MarkSonghurst]

Thanks.