vaishnavishri / hello-world Goto Github PK

Fixes #1646

Overrode the function forgotPassCode() in PassCodeActivity to display confirmation dialog. The user is logged out and login activity is launched ( startLoginActivity() is called) after the user selects "Logout" in the confirmation dialog.

Summary: Selecting "Forgot passcode, login manually" option in the PassCodeActivity logs out the user before the confirmation dialog opens up. The option should only open the dialog and the user should be logged out if "Logout" is chosen in the confirmation dialog.

Steps to reproduce

• Login using id and password. Set passcode for the app.
• Restart the app such that it asks for passcode.
• Choose "Frogot passcode, login manually" option.
• Select "Cancel" in the dialog box and try entering passcode now.
• On restarting the app, the log in screen opens up showing the user was logged out.

Expected behavior: When the user selects the forgot passcode option, the confirmation dialog should open up and selecting "Logout" should log the user out while "Cancel" should simply dismiss the dialog without any action.

Observed behavior: User should is logged out on selecting the forgot passcode option before the confirmation dialog shows up. If "Cancel" is selected in the dialog and passcode is entered again, incorrect passcode error is shown.

Device and Android version: Redmi Note 7 Pro, Android 9.0 Pie

Screenshots

passcode.issue.mp4

Steps to reproduce

• Have Talkback switched on
• Launch the app and select the three dots for Menu
• Try to navigate to the "Settings" or "Save to collection" option guided by Talkback only. (Closing your eyes and navigating might help understand the issue)

Expected behavior

While using the app through Talkback only there should be information conveyed about a few more options being present in the menu other than one present on the screen. This would give an idea of the menu list being scrollable which might not be intuitive for a lot of users, especially ones with some sort of visual disability.

Actual behavior

There is no way to access the "Settings" and few other options in the menu unless you can see the half displayed option "Add to home screen" or are aware of the remaining options of the menu being accessible after scrolling.
This behavior not being very intuitive has been mentioned in #18914 but I feel the issue should be looked at from the perspective of enhancing the accessibility of the app too.

Video of the above-mentioned step (please turn up the volume):

talkback.bug.fenix.mp4

Device information

• Device vendor / model and Android version: Redmi Note 7 Pro and Android 10
• Firefox for Android version: 1.0.2114 (Build #1)
  AC: 75.0.20210402143051, 0e4d25a96
  GV: 89.0a1-20210402094809
  AS: 74.0.1

mentioned in #18914