validark / roblox-ts-libraries

Various libraries I have posted on npm

Roblox-TS-Libraries

A collection of libraries hosted on npm written by yours truly, Validark, for use with roblox-ts.

roblox-ts-libraries's Issues

(@rbxts/signal) Add support for RBXScriptSignal.Once

BindableEvents already support this under the hood, so this should just be a copy-paste of Connect in init.lua and index.d.ts.

https://create.roblox.com/docs/reference/engine/datatypes/RBXScriptSignal#Once

When Roblox is unable to load a player's appearance, yield-for-character yields infinitely

mans is still functional and should probably be classified as loaded

This might be completely out of your scope to fix as I'm assuming the only way to prevent this would be to no longer include all of the scale values under humanoid and BodyColors in the tree

typeof rig doesn't satisfy instanceTree

type doesn't satisfy the InstanceTree of the module "validate-tree"
export declare type CharacterRigR6 = EvaluateInstanceTree<typeof CharacterRigR6>; export declare type CharacterRigR15 = EvaluateInstanceTree<typeof CharacterRigR15>;

(@rbxts/make) Implement attribute setting

It would be nice to be able to set attributes on the instances created with @rbxts/make, perhaps if possible, with a generic to specify the attributes' types.

validate-tree: passing 'game' as object throws SecurityContext error.

If the "root" of the tree is game, validateTree will hit a point where it tries to index services it doesn't have access to (due to SecurityContext restrictions) - and therefore, error.

Take the example:

const tree = {
    $className: "DataModel",
    Workspace: "Workspace",
    ReplicatedStorage: {
        $className: "ReplicatedStorage",
        sysNetwork: {
            $className: "Folder",
            getSelfShip: "RemoteFunction",
        },
    },
    ServerStorage: {
        $className: "ServerStorage",
        vehicles: "Folder",
    },
} as const;

if (!validateTree(game, tree)) {
    throw "Tree validation failed! Are you sure you did not forget anything?";
}

it will error with

The current identity (2) cannot Class security check (lacking permission 6)

(Note: I think this actually used to work, but a Roblox update may have inadvertently broken it)

Add license attribution

Some of these projects appear to be derivative works or redistributions of other projects. In particular, the spring library contained here appears to be a transcription of Fraktality's spr library.

Listing a username here is not generally enough to satisfy the MIT license. It's generally required to include the original license.

I recommend reviewing the other modules in the repo and their attribution. License violations are no good, and respecting each other's work is what makes open source hum!

Typing the tree constant as InstanceTree results in any child Instance being never

Using the InstanceTree type to type the const tree parameter results in its children being never.

Using InstanceTree type

Using as const

This is not expected behaviour as the tree parameter expects type InstanceTree

Infinite yield possible on ...path.Head

The yieldForR15CharacterDescendants promise never revolves because this part of the CharacterRigR15 table:
Head = { ["$className"] = "Part", Mesh = { ["$className"] = "SpecialMesh", OriginalSize = "Vector3Value", }, ... }
needs to be changed to:
Head = { ["$className"] = "MeshPart", ... }

side note: this is my first issue report so please don't mind if it's poorly written