validkeys / ember-beam Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 1.0 194 KB

License: MIT License

JavaScript 97.29% HTML 2.71%

ember-beam's People

Contributors

Watchers

Forkers

msalahz

ember-beam's Issues

Clean up everything like a bastard

TODO: Decide what to cleanup and how

Update the transforms to return an object

Transforms should be able to transform the entire event, not just the payload. Transforms should be required to return an object with:

{ eventName: "", payload: "" }

Change setUserInfo on the service to work more like the following:

  setCurrentUser(userObject, key = "email", newSignup = false) {
    this.currentUser = userObject;

    _.each(this._providers, (provider, providerName) => {
      if (newSignup) {
        provider.identify(userObject[key]);
      }
      provider.alias(userObject[key]);
      provider.setUserInfo(this.currentUser);
    });
  }

Added the globals option to the beam envConfig to allow for static settings to be applied to all events

I should be able to define keyFormat at the config level for each provider.

beam: {
  mixpanel: {
    auth:   {},
    config: {}
  }
}

Move sanitization options over to new config compiler.

Need to ensure we are passing around a reference to the original event name in all eventPackages

If a user changes the eventName in an application transform, we will no longer be able to look that transform up on the provider -- because we'll have no idea that the name has changed.

Add this.client() method to adapters so that transforms and hooks have clean access to client object.

//mixpanel adapter
this.client() // -> mixpanel global

Add configuration option to attach current user to all events

Would have to optionally allow for a key:

beam: {
  providers: {},
  config:    {
    attachCurrentUserToAllEvents: true,
    currentUserKey:               "user" //default
  }
}

Move the context attr on all service calls to be the last argument. It's not always necessary

Update the _getApplicationDefaults and getProviderDefaults to only pass in the payload. It's the only thing defaults should be able to change

keen addon

Add new option to the adapter options obj to automatically add the currentUser to all events

If setCurrentUser has been called on the service, the service then has access to the currentUser object from that point forward.

This is a standard thing to want to track, so allowing the developer to simply say "attachCurrentUserToAllEvents: True" would just make things that much easier.