valiec / deepercaves Goto Github PK

I was messing with configs for metallurgy 3 with the intention of making a progression system based on deeper cave depth when I discovered that ores from other mods don't generate in the custom stone. I'm unsure if it's because the stone types are lacking hooks or if those ores can only generate in vanilla stone but in either case it's a bit of a disappointment to me. Would it be possible to either enable modded ores to generate in Abandoned Caves and below or have a config option to change the stone back to vanilla?

####What type of issue is this? (e.g. bug, feature request)
Unoptimization
####Issue Description:
keeping all 12 dims loaded for no good apparent reason results in lag
####Steps to Reproduce: (if applicable)
look at your registry code you registry your providers with the boolean of true to keep them loaded
####System info: (only needed for bug reports)

Java version:
JRE 8
Minecraft version:
mc 1.7.10
Deeper Caves version:
1.0.0? all the files say 1.0.0 but, the zip files says something else. Also your website is down again
Other mods (if any):

Crash report:

####What type of issue is this? (e.g. bug, feature request)
Incompatibility/Other Issue

####Issue Description:
Crafting with Water Bottles places a new Empty Bottle in your inventory, regardless of if the bottle is consumed with the recipe.
####Steps to Reproduce: (if applicable)
Install this mod alongside any other mod which adds a recipe containing a water bottle which produces an output in a bottle; craft that recipe, and the bottle will be duplicated.
####System info: (only needed for bug reports)
Almost Certainly Irrelevant
Java version:
Irrelevant?
Minecraft version:
1.7.10
Deeper Caves version:
1.0.0
Other mods (if any):
Enviromine, for the recipes involving Water Bottles.
Crash report:
N/A.

####What type of issue is this? (e.g. bug, feature request)
Crash

####Issue Description:
The game crashes to desktop after loading a world.

####Steps to Reproduce: (if applicable)
Create a new Minecraft instance, install Forge, create a new world.

####System info: (only needed for bug reports)

Java version:
According to my Minecraft log: 1.8.0_131

Minecraft version:
1.7.10

Deeper Caves version:
1.0.0

Other mods (if any):
None

Crash report:
https://pastebin.com/e7Sx7Yh2
https://pastebin.com/E9nEXPBt (Contains an excerpt from the log file with more errors; the whole file was too big for pastebin, and couldn't be processed by GitHub)

That's really all there is to it... I'm really confused because I have no other mods installed and I can't even get into the world... I've looked at the CurseForge page, the MinecraftForum page, and the GitHub issues, and I appear to be the only person experiencing this issue... I must be missing something very basic, but I can't figure out what it is. I tried the latest version of Forge for 1.7.10 (build 1614), and also the version you listed in your notes (build 1291), but that didn't fix the problem either.

What type of issue is this? (e.g. bug, feature request)

This is a mod interaction issue with Extra Utilities.

Issue Description:

The Fragmented Cobblestone recipe conflicts with the Extra Utilities Gravel Bricks recipe.

Steps to Reproduce: (if applicable)

1. Try to craft Gravel Bricks
2. Get Fragmented Cobblestone
   ####System info: (only needed for bug reports)
   Minecraft version:
   1.7.10
   Deeper Caves version:
   0.4.2

Notes: Either add alternate recipe config or detect extra utilities and change deeper caves recipe to not conflict.

Are there any general style guidelines for this mod?
Style guidelines would be like "opening brackets on a new line", "no space after a cast", etc.

The game always crash after Enter the First Underground Level. I can not play it. Pls fix this problem, I want to play this mod.
I'm using Shiginima Launcher 2.0 with Forge 10.13.3.1374
(First I'm using Team Extreme Launcher But got same problem, And I'm tries on Forge 10.13.2.1291 But same problem too.)

---Here is Crash Log
http://www.mediafire.com/download/v6iivf79b54ii0q/crash-2558-04-17_16.14.45-server.txt

Pls. Fix this.

There are too few or no lava falls in the Drop level, but instead water falls.

####What type of issue is this? (e.g. bug, feature request)
Crash

####Issue Description:
A few layers (so far, Drop and Bedrock Plains) will attempt to generate a vanilla-style village, and it will cause a crash as one modded building or another fails to properly generate. One crash in particular makes the game crash every time that world is loaded afterwards. The Bedrock Plains one appears on top of the roof (visible with certain map mods) but is otherwise inaccessible. The Drop one never actually generates but tries to.

####Steps to Reproduce: (if applicable)
Fly around in the Drop or Bedrock Plains until a village generates with either a Matter Overdrive Mad Scientist house or one of the Chromaticraft village buildings.

####System info: (only needed for bug reports)

Java version:
8
Minecraft version:
1.7.10
Deeper Caves version:
1.0.0w
Other mods (if any):
Relevant mods: Chromaticraft, Matter Overdrive
Crash report:
Matter Overdrive (one-time crash): https://gist.github.com/Shahelion/ffa7aba7c97ac77701969f8b72742e1a
Chromaticraft (crashes every time): https://gist.github.com/Shahelion/770102b8920ff570cfbcb91e58332e40

What type of issue is this? (e.g. bug, feature request)

Bug

Issue Description:

Falling out of the world in other dimensions leads to cave dimensions, but not the same one depending on which world. For example, while falling out of the Overworld leads to the Drop level as it should (0 to -2, in my case) falling out of one of my Mystcraft ages (ID 6 for this one) takes me to the Maze level (ID -3). I also die from fall damage upon arriving every time.

Steps to Reproduce: (if applicable)

-Add the Mystcraft mod
-Make some Descriptive Books (and Linking Books to get back unless in Creative)
-Travel to an Age dimension and fall out of the world, and see where you end up.

System info: (only needed for bug reports)

Java version:

Minecraft version:
1.7.10
Deeper Caves version:
DeeperCaves-0.4.1-mc1.7.10
Other mods (if any):
mystcraft-1.7.10-0.12.3.01
Crash report:

When you enter the Near void level, you spawn below the terrain in midair.

The Lava level is too similar to the drop level. It should be unique.

The suggestion says that there should be ametrine pickaxes. They have not been added yet.

The Lava level does not have a higher-than-normal amount of lava, which it should. Also, it should have bedrock and cobblestone scattered on the walls. It has neither.

What type of issue is this? (e.g. bug, feature request)

Time Out Crash

Issue Description:

Hey Mr Modmaker!
Iam stucked in Maze dimension because everytime i joined the server i get a time out and cant connect again! Server says iam on server already ! Restart server .... join .... time out ... stuck forever XD is there any solution pls help me pls

In Drop Dimension all works perfect!

Steps to Reproduce: (if applicable)

System info: (only needed for bug reports)

Java version:
last Java

Minecraft version:
1.7.10

Deeper Caves version:
last for 1.7.10

Other mods (if any):
many but no dimension or biome conflict

Crash report:
no crash only time out

That is all.

In most levels, the game can sometimes start lagging/freezing every few seconds (or less) for a time.

Cause still unknown.

I love the mod and I want to try it out (as a player) but I cant find the download... Sorry about putting it in the issues folder... i am probably just blind.

When you leave a dimension, the chunks do not unload.

I've noticed this mod has some code in the net.minecraft package (MaterialMoltenIron and RenderDeepSpider). Minecraft mods should never have code in the net.minecraft package unless they know exactly what they are doing. The two files mentioned above can easily be moved into com.kpabr.DeeperCaves without issue (Right-click > Refactor/Rename in most IDEs).

Also, there is a large opportunity for cleaning up the mod by putting classes in proper packages (BiomeGen classes in com.kpabr.DeeperCaves.world.gen, Block classes in com.kpabr.DeeperCaves.block, ChunkProvider classes in com.kpabr.DeeperCaves.world.chunk, etc.).

Package organization is all personal preference, but it helps greatly in making code more manageable and readable.

####What type of issue is this? (e.g. bug, feature request)
game freezes
####Issue Description:
on a flat world with the seed of 2 the game freezes and refuses to load
####Steps to Reproduce: (if applicable)
input seed of 2
input creative mod
create flat world
notice it goes black and refuses to do anything even after 30 seconds
####System info: (only needed for bug reports)

Java version:
JRE 8
Minecraft version:
mc 1.7.10
Deeper Caves version:
1.0.0?
Other mods (if any):

Crash report:

Get rid of the obsidian platforms that spawn with you and have the code select a possible spawn location without hollowing out the ground.

Sometimes something relating to liquid physics will trigger infinite recursion.

Cause still unknown.

Just what the title says. Apparently, fall damage is still counted when you switch dimensions. I might try giving the player 1-2 seconds of resistance V on that teleport to fix it.

I was messing with configs for metallurgy 3 with the intention of making a progression system based on deeper caves depth when I discovered that ores from other mods don't generate in the custom stone types found in the abandoned caves and lower depths. Would it be possible to enable that feature or add in a config option to change it to vanilla stone?

Aquamarine Block is registered blockSapphire.

Aquamarine Block is also registered as oreAquamarine, not blockAquamarine.

Ametrine Block is registered as blockAquamarine instead of blockAmetrine.

Aquamarine Ore is not registered as anything.

Abandoned Caves Stone is registered as both cobble and stone (intended?)

"Dark" and "Abandoned Caves" ores are not registered as anything (Compressed and Deep Compressed are fine).

There are no portals on the Bedrock Plains level, meaning that to get out, you would have to dig through bedrock to y=0, which is impossible in survival.

Whenever I enter that layer, my console is filled to nearly the point of freezing with this:

[22:57:22] [Server thread/INFO] [STDOUT]: [com.kpabr.DeeperCaves.world.biome.DeeperDecorator:func_150513_a:233]: Lava: 94, 10, 122
[22:57:22] [Server thread/INFO] [STDOUT]: [com.kpabr.DeeperCaves.world.biome.DeeperDecorator:func_150513_a:233]: Lava: 91, 22, 121
[22:57:22] [Server thread/INFO] [STDOUT]: [com.kpabr.DeeperCaves.world.biome.DeeperDecorator:func_150513_a:233]: Lava: 101, 17, 121
[22:57:22] [Server thread/INFO] [STDOUT]: [com.kpabr.DeeperCaves.world.biome.DeeperDecorator:func_150513_a:233]: Lava: 97, 43, 127
[22:57:22] [Server thread/INFO] [STDOUT]: [com.kpabr.DeeperCaves.world.biome.DeeperDecorator:func_150513_a:233]: Lava: 90, 43, 124
[22:57:22] [Server thread/INFO] [STDOUT]: [com.kpabr.DeeperCaves.world.biome.DeeperDecorator:func_150513_a:233]: Lava: 101, 17, 125
[22:57:22] [Server thread/INFO] [STDOUT]: [com.kpabr.DeeperCaves.world.biome.DeeperDecorator:func_150513_a:233]: Lava: 96, 46, 126
[22:57:22] [Server thread/INFO] [STDOUT]: [com.kpabr.DeeperCaves.world.biome.DeeperDecorator:func_150513_a:233]: Lava: 100, 32, 131
[22:57:22] [Server thread/INFO] [STDOUT]: [com.kpabr.DeeperCaves.world.biome.DeeperDecorator:func_150513_a:233]: Lava: 90, 9, 123
[22:57:22] [Server thread/INFO] [STDOUT]:

Attempting to use an empty bucket on certain liquids simply destroys them. Narrowed it down to this mod causing it. Using current latest release.

Fluids that cannot be picked up with a bucket from in the world:
Life Essence (Blood Magic)
Oil and Fuel (Builcraft)
All Chromaticraft fluids
Tinkers Construct molten metals and Slime
Liquid Death and Purifying Fluid (Thaumcraft)
Liquid Coralium and Liquid Antimatter (Abyssalcraft)

Things that CAN be picked up:
Water
Lava
Mushroom and Vishroom Soup (Automagy)
Venenium (DeeperCaves)
ExtraTiC molten metals
Honey and Formic Acid (Erebus)
Spectral Dew (Netherlicious)
Spirit and Hollow Tears (Witchery)

Those materials should have block forms, but they do not.

####What type of issue is this? (e.g. bug, feature request) bug

####Issue Description: Inability to place water from buckets as the water disappears immediately. Also,
(As far as I can tell) if there's a block next to the water, it doesn't fill the bucket.

####Steps to Reproduce: (if applicable)

####System info: (only needed for bug reports) Alienware 15, 64 bit, Windows 10, 8 Gigabytes of RAM

Java version: 64-bit

Minecraft version: 1.7.10

Deeper Caves version: 0.5.0

Other mods (if any): Tekkit, Galacticraft

Crash report: The game doesn't crash.

What type of issue is this? (e.g. bug, feature request)

Level transition bug.

Issue Description:

Every level sends you to the Maze level.

Steps to Reproduce: (if applicable)

Fall out of the bottom of any level.
Reappear at the top of the Maze level.

System info: (only needed for bug reports)

Mac OS X 10.11
Java version:
Java 8
Minecraft version:
1.7.10 (Forge 1614)
Deeper Caves version:
0.4.1
Other mods (if any):
None
Crash report:
N/A (did not crash)

Shouldn't it be unbreakable? And even if not, it shouldn't drop anything.

The Silk Touch enchantment does not cause compressed ores to drop their block form. They still drop their normal drops.

Is this code under a license? If there's no official one, what are the general rules of attribution, modification, and redistribution?

Going through either the Drop or return portals puts you at the exact same coordinates in the destination dimension that you were at in the starting dimension when you went through the portal.

In the custom levels, vanilla ores still generate at their default y levels.

self explanatory ;-;

(I couldn't make a pull request)