GithubHelp home page GithubHelp logo

valor-software / ngm-cli Goto Github PK

View Code? Open in Web Editor NEW
33.0 33.0 13.0 717 KB

Simple way to manage angular submodules from one repository

License: MIT License

JavaScript 6.71% TypeScript 91.60% HTML 1.21% CSS 0.48%

ngm-cli's People

Contributors

dukakent avatar ilyasurmay avatar valorkin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

ngm-cli's Issues

task will not skip

in <utils.tasks-watch.ts>


let changedModule: number;
……
taskQueue.tasks.forEach((task: any, i: number) => {
task.skip = () => changedModule && i !== changedModule;
});


all task's skip will to be undefined! all task will not skip.

Template and style files still in the dist folder after inlining

Hi,

Great job for the inlining + css post-processing build, it works great.
I don't know if it's on purpose or not but the template and style files are still present in the dist folder.
Shouldn't they be deleted as they are already inlined in the component file?

Build error with the last version

Using the last version 1.0.4 I am not able to build anymore:

Error: spawn ngc ENOENT

I am executing ./node_modules/.bin/ngm build --clean and I get the error Error: spawn ngc ENOENT.

Even using the ---verbose option, which does not show more than usual, I don't have any clue of what's happening.
Where does the error could come from, the ngm-cli or the angular compiler?

when error, why not exit?

in <utils.tasks-watch.ts>


  .catch(err => {
    if (err) {
      console.error(err);
    }
    isRunning = false;
  });

why not process.exit(1) ?

Html support

Current only inline support on classes are supported but templateUrl breaks. Can you add it to webpack task html loader?

ENOENT: no such file or directory, open 'src/dist/package.json'

Hi,

I'm using this command:
ngm build -p src --clean

But it fail to clean the dist folder properly because I have this error : ENOENT: no such file or directory, open 'src/dist/package.json'

Here the full log:

ng2-dashboard jaumard$ npm run ngm

> [email protected] ngm /Users/jaumard/LISAProjects/ng2-dashboard
> ngm build -p src --clean

[18:38:30] Clean dist folders [started]
[18:38:30] Cleaning src/dist [started]
[18:38:30] Cleaning src/dist [completed]
[18:38:30] Cleaning src/dist [started]
[18:38:30] Cleaning src/dist [completed]
[18:38:30] Clean dist folders [completed]
[18:38:30] Copy md files and license [started]
[18:38:30] Copy md files and license [completed]
[18:38:30] Build package.json files [started]
[18:38:30] Build package.json files [failed]
[18:38:30] → ENOENT: no such file or directory, open 'src/dist/package.json'

ENOENT: no such file or directory, open 'src/dist/package.json'

If I look the dist folder package.json is still here with LICENSE and README.md. If I delete them then it works great.

I'm using node v7.9.0 on Mac OS X

Thanks for this module, it save me a lot of trouble packing my module ! :D

--watch not working, the issue is in the tasks-watch.js file, please see my proposed fix.

Hello guys,

First, thanks for building this useful tool.

Recently we upgraded to "ngm-cli": "1.0.4" and the --watch doesn't work for us anymore. So I did a little bit of research. Here is what I found.

When use command "ngm build -p src --watch=true --skip-bundles" and save any changes, the application is not automatically built again due to the error below.
image

The issue is caused by this

.then(taskQueue => tasksWatch({project, taskQueue, watch, paths: null}));
. The path passed into tasksWatch is specifically null.

There is another issue with tasks-watch.js file at

task.skip = () => changedModule && i !== changedModule;
.
There are two issues with this code.

  1. The first time the runTasks() runs, changedModule && i !== changedModule is undefined, which means every taks.skip would be undefined.
  2. The file changes, if somehow changedModule is 0. changedModule && i !== changedModule would return the value 0 instead of a boolean value.

I kind of fixed it like screenshot below.
image

feat(docs): add more docs!

@ocombe
okay
first thing: more docs, maybe with a project demo
second thing: it would be nice to have some kind of "init my lib" cli command, to start a new library with everything configured just the way it works

in the "more docs" sections, let people know how their lib will be consumed (is it import "mylib" or import "mylib/mylib", or how do you configure systemjs? where does it export the actual bundles? what kind of bundles? is it umd?)****

Failed build: handler is not a function

When trying to compile ng2-bootstrap repository I got the following error:

Windows 10, node v6.9.4:

λ npm run build

[email protected] build D:\www\angular2\ng2-bootstrap
ngm build -p src --clean
[02:55:56] Clean dist folders [started]
[02:55:56] Cleaning dist [started]
[02:55:56] Cleaning dist [completed]
[02:55:56] Clean dist folders [completed]
[02:55:56] Copy md files and license [started]
[02:55:56] Copy md files and license [completed]
[02:55:56] Build package.json files [started]
[02:55:56] Build package.json files [completed]
[02:55:56] Build projects [started]
[02:55:56] Building ng2-bootstrap (src) [started]
[02:56:15] Building ng2-bootstrap (src) [completed]
[02:56:15] Build projects [completed]
[02:56:15] Bundling umd version [started]
[02:56:15] Bundling ng2-bootstrap [started]
[02:56:16] Bundling ng2-bootstrap [failed]
[02:56:16] Bundling umd version [failed]

handler is not a function

Ubuntu 16.04.1 LTS:

root@c671d0baaf6d:/mnt/www/angular2/ng2-bootstrap# node -v
v6.9.4
root@c671d0baaf6d:/mnt/www/angular2/ng2-bootstrap# npm run build

[email protected] build /mnt/www/angular2/ng2-bootstrap
ngm build -p src --clean

[21:59:55] Clean dist folders [started]
[21:59:55] Cleaning dist [started]
[21:59:59] Cleaning dist [completed]
[21:59:59] Clean dist folders [completed]
[21:59:59] Copy md files and license [started]
[21:59:59] Copy md files and license [completed]
[21:59:59] Build package.json files [started]
[21:59:59] Build package.json files [completed]
[21:59:59] Build projects [started]
[21:59:59] Building ng2-bootstrap (src) [started]
[22:00:29] Building ng2-bootstrap (src) [completed]
[22:00:29] Build projects [completed]
[22:00:29] Bundling umd version [started]
[22:00:29] Bundling ng2-bootstrap [started]
[22:00:31] Bundling ng2-bootstrap [failed]
[22:00:31] Bundling umd version [failed]

handler is not a function

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.