vany0114 / signalr-core-sqltabledependency Goto Github PK

Hi,

Thanks for your netcore20 sample. I created a sample database on my azure sql server. On launch of the SignalCore.Web I get that exception

System.Data.SqlClient.SqlException
HResult=0x80131904
Message=Invalid object name 'sys.login_token'.
Source=Core .Net SqlClient Data Provider
StackTrace:
at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction) at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose) at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady) at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData() at System.Data.SqlClient.SqlDataReader.get_MetaData() at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString) at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds) at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior) at TableDependency.SqlClient.SqlTableDependency1.CheckIfUserHasPermissions(String connectionString)
at TableDependency.TableDependency1..ctor(String connectionString, String tableName, IModelToTableMapper1 mapper, IUpdateOfModel`1 updateOf, ITableDependencyFilter filter, DmlTriggerType dmlTriggerType, Boolean executeUserPermissionCheck)
at SignalRCore.Web.Hubs.InventoryDatabaseSubscription.Configure(String connectionString) in C:\Source\VSTS\SignalR-Core-SqlTableDependency\src\SignalRCore.Web\Hubs\InventoryDatabaseSubscription.cs:line 30
at SignalRCore.Web.ApplicationBuilderExtensions.UseSqlTableDependency[T](IApplicationBuilder services, String connectionString) in C:\Source\VSTS\SignalR-Core-SqlTableDependency\src\SignalRCore.Web\Extensions\ApplicationBuilderExtensions.cs:line 15
at SignalRCore.Web.Startup.Configure(IApplicationBuilder app, IHostingEnvironment env) in C:\Source\VSTS\SignalR-Core-SqlTableDependency\src\SignalRCore.Web\Startup.cs:line 76
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
at Microsoft.AspNetCore.ApplicationInsights.HostingStartup.ApplicationInsightsLoggerStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder builder)
at Microsoft.ApplicationInsights.AspNetCore.ApplicationInsightsStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder app)
at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.b__0(IApplicationBuilder builder)
at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
at Microsoft.AspNetCore.Hosting.WebHostBuilder.Build()
at SignalRCore.Web.Program.Main(String[] args) in C:\Source\VSTS\SignalR-Core-SqlTableDependency\src\SignalRCore.Web\Program.cs:line 21

Hope you can help me
best
Eric

I understand the need of EF factory, but is it really neccessary in Core version?
Isn’t simpler to use built in scope factory and default EF core scope lifetime.
So every time the shorter than request (or longer) is required use:

using(var scope = scopeFactory.CreateScope())
{
   var context = scope.ServiceProvider.GetRequiredService<DbContext>();
}

This should result with exactly the same purpose, but will allow greater flexibility with sharing context between different repositories for transactions.

Another thing is related about finalizer inside subscription code. You should never use it unless there are unmanaged resources. Here is great article about this:
https://ericlippert.com/2015/05/18/when-everything-you-know-is-wrong-part-one/

Third one: why scoped IHubContext. Why scoped. As far as I know it is by default singleton. So why to change it?

Awesome tutorial thanks, I get this exception when trying to initilise the TableDependency object
Object:

System.IO.FileLoadException: 'Could not load file or assembly 'System.Data.SqlClient, Version=4.2.0.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)'

Also get this warning in NuGet dependencies:

Package 'SqlTableDependency 6.1.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.0'. This package may not be fully compatible with your project.

Hello El Vany

I downloaded the project and tried it out. After making a few adjustments, the SignlaRCore.Web project runs successfully. However, when I click on the sell button, I am receiving a javascript error - Cannot send data if the connection is not in the 'Connected' State.
at c.HttpConnection.send (signalr-client-1.0.0-alpha2-final.min.js:1)
at signalr-client-1.0.0-alpha2-final.min.js:1
at new Promise ()
at c.HubConnection.invoke (signalr-client-1.0.0-alpha2-final.min.js:1)

When the page loads, it does say connection opened. I tried a lot but am not able to resolve this. Can you please let me know what the issue could be? Thanks