GithubHelp home page GithubHelp logo

vapok / adventurebackpacks Goto Github PK

View Code? Open in Web Editor NEW
15.0 15.0 11.0 2.41 GB

A Valheim Mod to add Adventuring Backpacks to the Game. These packs grow and become more useful as the game progresses.

License: MIT License

C# 98.99% ShaderLab 1.01%

adventurebackpacks's People

Contributors

deathdaisy avatar lopezp9492 avatar rysson avatar shudnal avatar vapok avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

adventurebackpacks's Issues

Backpack inventories getting cleared on reloading

Describe the bug
On reloading a world, every player's equipped backpacks are sometimes empty. I haven't been able to make it consistent. Also, sometimes a player will instead see their backpack filled with old items from a previous reload, but I haven't been able to replicate that in singleplayer.

To Reproduce
Steps to reproduce the behavior:

  1. Put items in backpack (any will do)
  2. Save the game.
  3. Close out the world (either fully close game or logout to menu)
  4. Load back in.
  5. See empty backpack.

Expected behavior
Items put into the backpacks shouldnt be deleted on loading.

i18n of Base Game doesn't work since last update

Describe the bug
Variables have their variable names instead of the values since last update

To Reproduce
Steps to reproduce the behavior:
1·Set the game in French (for exemple)
2·Start the game modded

*Using Thunderstore Mod Manager

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
20230129154355_1

Mod List (please list your mods that are being used):

  • AdventureBackpacks by Vapok
  • BepInExPack_Valheim by denikson

Additional context
Worked fine before last update

Show cape instead of backpack

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
I would like to be able to see the standard cape instead of the backpack.

Describe alternatives you've considered
None

Additional context
None

Backpack has no storage slots

Describe the bug
Backpack has no storage space

To Reproduce
Craft backpack, open backpack inventory

Expected behavior
To have slots for backpack to put things in

Screenshots
screenshot attached

Mod List (please list your mods that are being used):
Player Log attached

Additional context

Untitled
Player.log

VNEI search bar locks interface/soft locks game

If you're using VNEI, and use the search bar and press 'i' in the search bar, it soft locks the game. The HUD disappears, but the simulation continues. The player can't move or do anything. Can't even press escape to open the menu, but there is still access to console commands. I just run the save command and ALT+F4. This issue doesn't seem to affect clients tho.
LogOutput.log

Issue loading plugin after latest update

The plugin currently breaks some things on server/client load.

Start the game or a dedicated server and be greeted with this error:

[Warning:  HarmonyX] AccessTools.DeclaredMethod: Could not find method for type ZInput and name GetKeyDown and parameters (UnityEngine.KeyCode)
[Error  :vapok.mods.adventurebackpacks] [AdventureBackpacks.Patches.InventoryGuiPatches+InventoryGuiUpdateTranspiler+<Transpiler>d__0.MoveNext] InventoryGui.Update Transpiler Failed To Patch
[Warning:vapok.mods.adventurebackpacks] [AdventureBackpacks.Patches.InventoryGuiPatches+InventoryGuiUpdateTranspiler+<Transpiler>d__0.MoveNext]  patchedHideBackpackMethod True
[Warning:vapok.mods.adventurebackpacks] [AdventureBackpacks.Patches.InventoryGuiPatches+InventoryGuiUpdateTranspiler+<Transpiler>d__0.MoveNext]  patchedShowBackpackMethod True
[Warning:vapok.mods.adventurebackpacks] [AdventureBackpacks.Patches.InventoryGuiPatches+InventoryGuiUpdateTranspiler+<Transpiler>d__0.MoveNext]  patchedDetectInputHideMethod False
[Warning:vapok.mods.adventurebackpacks] [AdventureBackpacks.Patches.InventoryGuiPatches+InventoryGuiUpdateTranspiler+<Transpiler>d__0.MoveNext]  patchedDetectInputShowMethod True
[Error  :vapok.mods.adventurebackpacks] [AdventureBackpacks.Patches.InventoryGuiPatches+InventoryGuiUpdateTranspiler+<Transpiler>d__0.MoveNext] Please inform Mod Author.

after which the console is filled with
[Error : Unity Log] MissingMethodException: Method not found: bool .ZInput.GetKeyDown(UnityEngine.KeyCode)

Tested with only the backpacks mod installed, same results

I think it's because of the latest update adding controller input, it's possible they switched over to the new Unity Input Manager or simply changed how it's implemented which gave me relatable errors on another Unity project I'm working on, but that's just a guess/pointer.

Lox Hide Knappsack from Lox Cape loses Frost resist

Describe the bug
When you craft the Lox Cape. it offers Frost resist similar to Wolf Cape. in vanilla Valheim people may have preferred this one as it was cheaper and in some cases looked better overall on other gear. However when you get/craft the Lox Backpack it no longer has Frost Resist.

To Reproduce
Steps to reproduce the behavior:
Craft Lox cape.
Upgrade to Backpack.
See the loss

Expected behavior
It should transfer the same bonuses as the Cape.

Screenshots
image

Mod List (please list your mods that are being used):

  • Adventure Backpacks 1.7.5

Additional context
Basically without having Frost Resist this is a pure downgrade, and in my opinion, not worth crafting/pursuing.

More settings.

To be more clear, i would be really happy to see speed/carry bonus/weight settings for each level, not for backpack overall.
And speed setting being relative to how many weight backpack actually have, but that seems way too complex to code imo.
Besides that - any way to remove some of backpacks entirely(making them a separate files or something like that maybe?).
But thats my obsessive compulsive disorder speaking - i just really dont like some of models(atm solved that by removing ability to craft for ones i dont like/editing player data and clear recipe data from it).
Thats all i can think of. Thanks for keeping this alive.

Backpack Inventory Modal Does Not Display

Describe the bug

When installed, player presses 'i' to call the backpack inventory modal to view and interact with contents. Inventory opens as expected and all other actions appear normal. The player's game inventory screen indicates the weight limit increase due to pack, however player cannot see visually the modal panel with the backpack slots and is unable to interact with items and backpack.

Notes:

  1. This is a hosted server with Valheim+
  2. We do use Valheim Minus patcher mod to allow Bepinex but disable/unload V+
  3. Other players are using AdventureBackpacks with no issues.

A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Player installed AdventureBackpacks on client using R2modman
  2. Player loads valheim using R2modman 'start modded'
  3. Game loads correctly.
  4. Player gathered ingredients for Rugged Backpack
  5. Player crafted and equipped Rugged backpack
  6. Player pressed 'i' to view backpack slots
  7. Player inventory opened, but no backpack modal displayed. (however player's weight capacity increased by 10)

Expected behavior
Like other server players, expected backpack contents to display.

Mod List (please list your mods that are being used):
Player uses the following mods: EquipmentAndQuickSlots, Cats, AdventureBackpacks (and bepinex ofcourse). All have been reinstalled including R2modman to be sure latest Hildir updates.

Cats is server-side and dll is installed correctly and working.

Additional context
Add any other context about the problem here.

Thank you for taking the time to review!!! This is a brilliant mod and look forward to all my players using it!! Hoping it is just a mistake on our end. Tonight I plan to have the player completely uninstall and reinstall their mods just to be certain unless you identify a clear issue. I can try to obtain a log tonight if that may assist.

Polish Translations

{
"vapok_mod_item_backpack_meadows": "Tornister",
"vapok_mod_item_backpack_meadows_description": "Mały plecak zdolny pomieścić przedmioty.",

"vapok_mod_item_backpack_blackforest": "Wytrzymały Plecak",
"vapok_mod_item_backpack_blackforest_description": "Wytrzymały plecak, w komplecie z klamrami i delikatnymi skórzanymi paskami.",

"vapok_mod_item_backpack_swamp": "Krwawy Wodoodporny Plecak",
"vapok_mod_item_backpack_swamp_description": "Wytrzymały plecak uszczelniony przy użyciu wodoodpornych worków na krew.",

"vapok_mod_item_backpack_mountains": "Arktyczny Plecak",
"vapok_mod_item_backpack_mountains_description": "Arktyczny plecak, nadający się na długie wędrówki po górach.",

"vapok_mod_item_backpack_plains": "Plecak ze Skóry Loxa",
"vapok_mod_item_backpack_plains_description": "Plecak poszukiwaczy przygód wykonany z niezwykle wytrzymałej skóry loxa",

"vapok_mod_item_backpack_mistlands": "Plecak Odkrywcy",
"vapok_mod_item_backpack_mistlands_description": "Perfekcyjnie wykonany, mistyczny plecak. W komplecie z własnym pudełkiem do przechowywania. Nikt nie jest pewien, jak to działa.",

"vapok_mod_item_rugged_backpack": "Stary Wytrzymały Plecak",
"vapok_mod_item_rugged_backpack_description": "Wytrzymały stary plecak, w komplecie z klamrami i delikatnymi skórzanymi paskami.",

"vapok_mod_item_arctic_backpack": "Srary Arktyczny Plecak",
"vapok_mod_item_arctic_backpack_description": "Srary arktyczny plecak, w dalszym ciągu nadający się na długie wędrówki po górach.",

"vapok_mod_no_inception1": "Nie rozgniewaj bogów.",
"vapok_mod_no_inception2": "Zostałeś ostrzeżony.",
"vapok_mod_no_inception3": "Rozgniewałeś bogów!",
"vapok_mod_no_inception4": "Ehh... Thor wkrótce się z tobą rozprawi.",
"vapok_mod_no_inception5": "Thor pozbawił cię mocy!!!",

"vapok_mod_thor_saves_contents": "W tym plecaku były rzeczy. Thor zachował je dla ciebie.",

"vapok_mod_useful_backpack": "Twój plecak sprawia wrażenie użytecznego.",
"vapok_mod_you_droped_bag": "Upuściłeś plecak!",
"vapok_mod_level": "Poziom",
"vapok_mod_effect": "Efekt",
"vapok_mod_quick_drop_unavailable": "Szybki Drop Niedostępny.",

"vapok_mod_se_cold_immunity": "Odporność na zimno",
"vapok_mod_se_frost_resistance": "Odporność na mróz",
"vapok_mod_se_wet_resistance": "Odporność na wodę",

"item_friendlyskeletonwand_spectralshroud_backpack": "Widmowy Całun Utrzymania"
}

Suggestion: Add other armour set bonuses

As the title says, please add the other armour set bonuses.

Possibly as totally optional additions, or as new, alternative backpacks for the zone.

Abominable Bag (Root Armour)
Hairy Sack (Fenris Armour)

Issue: "Drop Backpack" key triggers when entering sign text

Hi, just wanted to let you know that the Quickdrop Backpack function still occurs when typing in the sign/portal windows.

To reproduce:

  1. equip a backpack
  2. build a sign or portal
  3. press whichever key "Quickdrop Backpack" is assigned to.
    Your backpack will be unintentionally quickdropped.

Maybe related (should I open a new issue?) but even though the "Open Backpack" and inventory keys (with Open with Inventory) don't open the backpack while the enter text window is open, they'll queue and open up right afterwards. Not nearly as problematic, but still unintentional and annoying.

Limiting total backpacks in player inventory.

Is your feature request related to a problem? Please describe.
Allowing players to carry multiple backpacks can cause issues such as hording or worse.

Describe the solution you'd like
a configuration setting which allows 0-10 backpacks per player inventory. If a player tries to pickup another pack or craft one, its instantly thrown on the ground.

Describe alternatives you've considered
Telling players not to make too many backpacks.

Additional context
Thanks!

Repo out of sync with Thunderstore releases

Describe the bug
Thunderstore is showing the release as 1.7.6, while this repo is at 1.7.1
Is this codebase being maintained somewhere else? Where can we go to see release notes and what is being fixed/added/updated?

To Reproduce
Steps to reproduce the behavior:

  1. Look at Thunderstore release version
  2. Look at repo release version

Expected behavior
I would expect the releases to be in sync.

Additional context
Thank you for the amazing work!

JewelCrafting Update issue?

JewelCrafting updated and is in conflict with AdventureBackpacks.... I think.

Steps to reproduce the behavior:

  1. Go to any wooden chest
  2. Place items in top row and separate items in bottom row of chest
  3. Click "Take All"
  4. The items that were stored in the bottom row of the chest will return to your inventory, the items in the top row will disappear.
    Expected behavior
    Items from the entire chest to return to my inventory.

New playthrough as of today, haven't gotten the satchel yet to see how the backpack performs.
ModsList.txt

Editing/Adding weight bonuses don't show weight bonuses in the item description

Describe the bug
Editing/Adding weight bonuses don't show weight bonuses in the item description.

To Reproduce
Steps to reproduce the behavior:

  1. Edit config file
  2. Add weight bonuses to Rugged or Arctic backpacks
  3. Save config file
  4. Run the game and load the world
  5. Item description doesn't show the weight bonus.

Expected behavior
It should show the weight bonus.

Mod List (please list your mods that are being used):
LogOutput.log

Additional context
I'm using Project AUGA. I'm not sure if that's the issue, I think it shouldn't be.

Backpack won't open

Describe the bug
Pressing I doesn't open the backpack

To Reproduce
Steps to reproduce the behavior:

  1. Right click to equip backpack
  2. Click I to open
  3. Backpack doesn't open
  4. See error

Expected behavior
Seeing backpack inventory.

Mod List (please list your mods that are being used):
Player.log

Explorer's Whipsack resets the effects when you use tools/weapons.

Describe the bug
When Explorer's Whipsack [upgrade level 4] is equipped: whenever you use any tools or weapons it resets the effects added by the backpack - so it respawns wisps constantly, most noticeable while switching the hammer on/off.

To Reproduce
Steps to reproduce the behavior:

  1. Equip explorer's whipsack
  2. Equip any tool or weapon
  3. See error

Expected behavior
Effect stays on whether you use any tools/weapons or not.

Screenshots
Can't screenshot this particular issue, the description should be enough

Mod List (please list your mods that are being used):
mods.zip

Additional context
There is also a visual issue with the Bloodbag Wetpack - the backpack belts are sticking out pretty significantly.

fish in backpack on load cause an error in log

Describe the bug
For each fish in a worn backpack, upon character load, the following error appears once in the log:

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
Fish.GetPointDepth (UnityEngine.Vector3 p) (at <035307060cbb4b30b916cd82ebd80490>:0)
Fish.RandomizeWaypoint (System.Boolean canHook) (at <035307060cbb4b30b916cd82ebd80490>:0)
Fish.onCollision () (at <035307060cbb4b30b916cd82ebd80490>:0)
Fish.OnCollisionEnter (UnityEngine.Collision collision) (at <035307060cbb4b30b916cd82ebd80490>:0)

To Reproduce
Steps to reproduce the behavior:

  1. Catch a fish
  2. Put it in your backpack
  3. Log out of the game
  4. Log back in.

Expected behavior
I didn't expect a bunch of red error text in my bep window, lol

Additional context
This appears to cause no further issues, I just figured you might be interested.

Unity console error during startup on Valheim 0.217.22

Describe the bug
On the current version of Valheim (0.217.22) patched on 2023/10/05, starting Valheim with Adventure Backpacks loaded throws an error in the Unity console.

To Reproduce

  1. Install Valheim 0.217.22, AdventureBackpacks 1.6.27, and BepInExPack 5.4.2200.
  2. Run Valheim with BepInEx and observe the Unity console. An error logs out. When you reach the main screen, any previously loaded character will not appear, with the placeholder "Ragnar" if you click to start a game.
  3. Roll back to previous stable Valheim using the default_old beta branch; install BepInExPack 5.4.2105.
  4. Run Valheim with BepInEx and check the Unity console again. With these versions, no error appears.

Expected behavior
Error free console. Possible this doesn't have functional impact, I haven't yet been able to tell, but worth investigating!

Screenshots
The exact error I see:

[Error  : Unity Log] MissingFieldException: Field 'FejdStartup.m_connectionFailedError' not found.
Stack trace:
(wrapper dynamic-method) FejdStartup.DMD<FejdStartup::ShowConnectError>(FejdStartup,ZNet/ConnectionStatus)
(wrapper dynamic-method) FejdStartup.DMD<FejdStartup::Start>(FejdStartup)

Mod List (please list your mods that are being used):
I first spotted this using a fairly extensive list, but while troubleshooting was able to reproduce the error with nothing installed except Adventure Backpacks and its prereq.

Unable to load World.

After extensive testing to figure out what mod was causing the issue this was the only mod that put out errors.

Version is Current Stable Release Steam. R2Modmanager was used and Manual install was also attempted to same errors.

I get this when game loads with this mod only.

[Error : Unity Log] MissingMethodException: StatusEffect ObjectDB.GetStatusEffect(string)
Stack trace:
ItemManager.PrefabManager.Patch_ObjectDBInit (ObjectDB __instance) (at <6ff225bf58af4b23b00f9294ae14e63c>:0)
(wrapper dynamic-method) ObjectDB.DMDObjectDB::Awake(ObjectDB)
UnityEngine.GameObject:AddComponent()
FejdStartup:SetupObjectDB()
FejdStartup:DMDFejdStartup::Start(FejdStartup)

[Error : Unity Log] MissingMethodException: StatusEffect ObjectDB.GetStatusEffect(string)
Stack trace:
ItemManager.PrefabManager.Patch_ObjectDBInit (ObjectDB __instance) (at <6ff225bf58af4b23b00f9294ae14e63c>:0)
(wrapper dynamic-method) ObjectDB.DMDObjectDB::CopyOtherDB(ObjectDB,ObjectDB)
FejdStartup.SetupObjectDB () (at <447b19510f604ca3807cd6cce3a7c1ef>:0)
(wrapper dynamic-method) FejdStartup.DMDFejdStartup::Start(FejdStartup)

This Error when I try to load up a world.

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
FejdStartup.OnWorldStart () (at <447b19510f604ca3807cd6cce3a7c1ef>:0)
UnityEngine.Events.InvokableCall.Invoke () (at <80fe1a4e36fe44618284312cb721a597>:0)
UnityEngine.Events.UnityEvent.Invoke () (at <80fe1a4e36fe44618284312cb721a597>:0)
UnityEngine.UI.Button.Press () (at :0)
UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at :0)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at :0)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at :0)
UnityEngine.EventSystems.EventSystem:Update()

AzuCraftyBoxes Integration

I play with AzuCraftyBoxes to allow me to build and craft using resources from nearby containers and although I have tried configuring it to find the backpacks from this mod based on their item ids, it can't seem to find resources inside of backpacks.

It would be great if the backpack protection inventory guard was modified to all AzuCraftyBoxes to pull resources from backpacks while crafting, much like how it lets Quick Stack Store deposit them.

Alternatively, if the item IDs for spawning the backpacks are actually different than the internal IDs for the containers associated with the backpack them simply listing them in the readme so AzuCraftyBoxes can be configured to find them could be great solution as well. I did search through the repo on github but couldn't discern if there were separate container IDs (not very familiar with C# though).

Anyways, thanks for the great mod!

Configurable backpack status effect string

Pls make string statusEffects.Effect.m_name at Assets.Backpacks.UpdateStatusEffects() configurable.
It's so long and spammy entry at the effect list.
statusEffects.Effect.m_name = $"{backpackName} $vapok_mod_level {backpackQuality} $vapok_mod_effect";
I can set $vapok_mod_effect to "" but not $vapok_mod_level as it breaks Extensions.InventoryExtensions.IsBackPackInventory()

I don't think anyone needs to know their backpack quality all the time.
As we can't equip more than one backpack all the info except backpack name and icon is irrelevant.

I couldn't find any string comparison on Effect.m_name so it looks safe.
As a simple solution string could be localized whole with {0} and {1} parameters for name and quality.

Integration Request with Cheb's Necromancy

Necromancer's Backpack

A user wants to combine the cloak from my mod with a backpack from yours.

Is your feature request related to a problem?

  • Yes - the inability to wear both the cloak and the backpack at the same time.

Describe the solution you'd like

  • Detect if your mod is installed as well as my mod
  • If it is, a special backpack prefab is added which has the Spectral Shroud cloak's script on it and maybe a nice texture

If you have a better idea, please let me know.

Additional context

The user's exact request and issue:

Necromancer's Backpack: Made from the Necromancer's Shroud, this backpack scale as you upgrade it to the end game with the Adventure Backpacks Mod. This way we can have the advantages that come with the shroud (ghost summon and increase to necromancy) without having to give up the carrying capacity the backpacks introduce to modded games.

Armor stand duplicates items in backpacks

Describe the bug
Duping items in the backpack when using armor stands

To Reproduce
Steps to reproduce the behavior:

  1. Place a backpack with items in it onto an armor stand.
  2. All items will be thrown out onto the ground while also staying in the backpack. Duping the items.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.