Comments (2)
vasturiano
commented on July 22, 2024
@micrology thanks for your report.
I can imagine it was difficult to trace the source of the issue back to the DOCTYPE declaration. I've just fixed the problem.
Essentially, some width, height css properties were being set without the respective units (px). This generally works fine in most browsers and thus remained undetected, but was causing an issue in Aframe (the VR framework) if the DOCTYPE was set to html, because it relies on monitoring the DOM properties in the background.
You can see the simple fix here: d84a7f2
So, if you upgrade to the latest version of this module you should no longer experience the issue.
from 3d-force-graph-vr.
micrology
commented on July 22, 2024
Thanks – it works now.
Professor Nigel Gilbert, CBE, ScD, FREng, FAcSS, Professor of Sociology,
University of Surrey, Guildford GU2 7XH, UK. +44 (0)1483 689173
From: Vasco Asturiano ***@***.***>
Date: Monday, 7 February 2022 at 21:56
To: vasturiano/3d-force-graph-vr ***@***.***>
Cc: Gilbert, Nigel Prof (Sociology) ***@***.***>, Mention ***@***.***>
Subject: Re: [vasturiano/3d-force-graph-vr] Adding <!DOCTYPE html> at the top of the source code causes basic example to fail (Issue #30)
@micrology<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrology&data=04%7C01%7Cn.gilbert%40surrey.ac.uk%7C9f53e033ea824a01477308d9ea84a9b9%7C6b902693107440aa9e21d89446a2ebb5%7C0%7C0%7C637798677767038110%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xtYXnRzQqmAsXSNiwpp5Gl9KJcjF3naim9sOz%2FLWnQo%3D&reserved=0> thanks for your report.
I can imagine it was difficult to trace the source of the issue back to the DOCTYPE declaration. I've just fixed the problem.
Essentially, some width, height css properties were being set without the respective units (px). This generally works fine in most browsers and thus remained undetected, but was causing an issue in Aframe (the VR framework) if the DOCTYPE was set to html, because it relies on monitoring the DOM properties in the background.
You can see the simple fix here: d84a7f2<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvasturiano%2F3d-force-graph-vr%2Fcommit%2Fd84a7f22d25efd2db0bf8d49a63255214d71d72f&data=04%7C01%7Cn.gilbert%40surrey.ac.uk%7C9f53e033ea824a01477308d9ea84a9b9%7C6b902693107440aa9e21d89446a2ebb5%7C0%7C0%7C637798677767038110%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=QFQOrm2IysmOzzK4J7jVnjeSBTSsr6LCyQ5T4RHwCBI%3D&reserved=0>
So, if you upgrade to the latest version of this module you should no longer experience the issue.
—
Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvasturiano%2F3d-force-graph-vr%2Fissues%2F30%23issuecomment-1031971287&data=04%7C01%7Cn.gilbert%40surrey.ac.uk%7C9f53e033ea824a01477308d9ea84a9b9%7C6b902693107440aa9e21d89446a2ebb5%7C0%7C0%7C637798677767038110%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YTf9fcDw9XOnkaMtW2ih6KEMcsrnQ2JgMStL58ZN%2F3M%3D&reserved=0>, or unsubscribe<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAALCAAVXQBD6G3EOO4ZTDB3U2A5X3ANCNFSM5NV3V3XA&data=04%7C01%7Cn.gilbert%40surrey.ac.uk%7C9f53e033ea824a01477308d9ea84a9b9%7C6b902693107440aa9e21d89446a2ebb5%7C0%7C0%7C637798677767038110%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=kyGRbqn54DLVG%2BZYZk6r73JtwBwRtbWakOCFe9%2BJLGQ%3D&reserved=0>.
Triage notifications on the go with GitHub Mobile for iOS<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cn.gilbert%40surrey.ac.uk%7C9f53e033ea824a01477308d9ea84a9b9%7C6b902693107440aa9e21d89446a2ebb5%7C0%7C0%7C637798677767038110%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=bT8v5nGhZGYZFDzQUF%2FybiQGHaY7abEbMFXNi74g4ms%3D&reserved=0> or Android<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cn.gilbert%40surrey.ac.uk%7C9f53e033ea824a01477308d9ea84a9b9%7C6b902693107440aa9e21d89446a2ebb5%7C0%7C0%7C637798677767038110%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Zy1Ms3eTSPv98CQuJnnsaQbC4lJTyzjxzC5mOvTHB7U%3D&reserved=0>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
from 3d-force-graph-vr.
Related Issues (20)
- Graph disappears when in VR mode? HOT 1
- import ForceGraphVR in js module gives multiple instances of Three.js imported and A-frame <script>in head warnings HOT 2
- Nodes names not displayed HOT 4
- Text + Nodes causes errors HOT 1
- Not sure how to add a bg video HOT 4
- Movement doesn't work on Oculus HOT 1
- Differentiating same name nodes HOT 1
- Graph with ~150 nodes and ~300 crashes HOT 2
- How to render an image sprite and display text at the same time ?
- How to make the nodes look at the camera at all times without calling refresh ? HOT 4
- Node Labels not Displayed on Mobile HOT 4
- Background Image option instead of background color HOT 1
- Click to expand / collapse in VR?
- interaction to nodes
- Cannot read properties of undefined (reading 'xr') HOT 1
- Is there a way to render the passthrough background for XR headsets (e.g. Oculus Pro)? HOT 1
- Mobile navigation HOT 1
- Which combination to get started HOT 2
- Re-enable touch screen movement controls? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 3d-force-graph-vr.