GithubHelp home page GithubHelp logo

brec-base's People

Contributors

beiyi0207 avatar jpsilva avatar kentmw avatar m-obrien avatar mandragorn avatar mattwillis avatar michaelpelletier avatar stonecalvin avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

brec-base's Issues

Remove slash on disabled buttons

The slash added to disabled buttons are often in wrong places and raise questions of why they are there. The slash should be removed for now, and eventually the styles of disabled buttons will be updated/replaced with the newer BREC.

Styling hides all checkboxes but doesn't replace all with icons

There's this style rule defined in the buttons module (line 244 of _buttons.scss)

  // Hide radio buttons and checkboxes within button groups
  input[type=checkbox], input[type=radio] {
    position: absolute;
    left: -9999em;
  }

This hides all checkboxes and radio buttons. It's accompanied by a whole set of other style rules that replace standard checkboxes and radio buttons with icomoon icons and style the label elements to look like buttons. However, these rules are only applied to checkboxes accompanied by labels with the class "btn". This results in checkboxes that aren't accompanied by "btn" labels being hidden but not replaced with anything.

You can see the issue in lines 135-242 of _buttons.scss.

$link-hover-color hardcoded to bright blue

in _default-settings.scss, there are the following definitions:

First,
$link-hover-color: #00b6f2;

and later,
// Links
$link-default-color: #0090bf !default;
$link-visited-color: lighten(desaturate($link-default-color, 30%), 10%) !default;
$link-hover-color: lighten($link-default-color, 10%) !default;
$link-active-color: lighten($link-default-color, 20%) !default;

The first link-hover-color is the one that is chosen and that makes it impossible to just overwrite the link-default-color and get the rest for free.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.