veelasky / laravel-hashid

HashId Implementation on Laravel Eloquent ORM

Live long and prosper! 🖖

laravel-hashid's Issues

Impossible Migration to v2?

Hi

from what I can see, it seems impossible to migrate from v1 to v2, as v2 dropped the functionality to make reproducable keys? But maybe i just don't see how to do it...

So, in version one, we had the functionality to have a user-defined salt-generator by using makeHashedIdSalt() on each model. With this is was possible to replace the generic, laravel-key-based salt and use reproducable salts. But now, this method was removed and it was hardcoded in Repository::get() without any way of custimization. Is that correct?

Why this is an issue:
Assume you have an URL /device/MyH4sh1D stored to your bookmarks, as this is your personal device and you check it occasionally. Now a dev upgrades the package, which will change the "salt-generator", and ultimately, every link to your application is broken. This also applies for example if mails with a link were sent out or if the user somewhat stores the HashId somewhere.

Use the same hashIds between projects

Is it possible to have the same Hash IDs in different Laravel projects?

I set $hashKey on the models in the two different projects to be the same, but the hash IDs are different.

When I put the same APP_KEY for both projects, the hash IDs match, but obviously this is not practical.

Wrong exception on invalid hash string

Hi
When the hash string is invalid, an Illuminate\Database\QueryException throws via the byHashOrFail method. It supposed to have a not found exception.

Unexpected exception on invalid hash string

Hi
When the hash string is invalid, an Illuminate\Database\QueryException throws via the byHash method. It supposed to return a null value.